Commit Graph

2930 Commits

Author SHA1 Message Date
TreeHugger Robot
3704899fc9 Merge changes from topic "settings-action-button"
* changes:
  Remove setButtonPositive method
  Apply new action button visual design
  Create a new visual design for action buttons
2018-11-16 10:45:29 +00:00
Stanley Wang
83680c7c98 Merge "Layout updated for file size text wrapping with largest display" 2018-11-15 07:10:49 +00:00
tmfang
8f65efa8f9 Create a new visual design for action buttons
- Create a new style for two action buttons.
- Change the layout of two_action_buttons.
  Since we use same style for positive/nagative
  buttons now, we only remain button1/button2 for
  this layout.
- Create a setButtonIcon interface in ActionButtonPreference.
  So, user can set icon for each button in this preferece.

Test: visual, robotest
Bug: 116346008
Change-Id: I511272cba5fd961349b85cae6d30004ddabe2c8e
2018-11-15 10:15:58 +08:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
TreeHugger Robot
d6cdafc0d7 Merge "Enabled the floating search bar feature" 2018-11-14 04:50:13 +00:00
Sunny Shao
2c93ec8ae3 Enabled the floating search bar feature
Added the CoordinatorLayout as the top level layout
Added the AppBarLayout to enclose the search bar
Added the app:layout_behavior="@string/appbar_scrolling_view_behavior" to NestedScrollView

Bug: 118886724
Test: manual test
Change-Id: I4a8ef14637dc1dc7cf9618eca00e4b7d7a77c725
2018-11-13 17:04:21 +08:00
Emily Chuang
6cf3591645 Add dismissal mechanism for contextual cards.
In the homepage, we should allow cards to be dismissed.

- Implement card flipping upon card long pressing.

Bug: 113783548
Test: robotests, visual
Change-Id: I2ddb498321ba5c5078d6944aa2ef32f1386bdb10
2018-11-13 14:46:44 +08:00
Emily Chuang
0b6a3000e0 Restrict the number of contextual cards shown in suggestion area.
In order to make static IA visible in the homepage, we have to limit the
number of cards.

Bug: 118691898
Test: robotest
Change-Id: Iefb8b7e874ec1334e93be2d196b7cb72624b17b0
2018-11-12 14:17:47 +08:00
TreeHugger Robot
74f3077729 Merge "Update new UI layout of Conditional cards" 2018-11-09 17:49:25 +00:00
TreeHugger Robot
c32de1a2d9 Merge changes from topic "entity_ui"
* changes:
  Do not show installation status on Q
  New UI design for entity header on Q
2018-11-09 05:51:21 +00:00
Mill Chen
c89c4ceabb Update new UI layout of Conditional cards
Bug: 113451905
Test: visual
Change-Id: I20ec526bd2b5b2679cd7e0e4388a2a897fe6a24d
2018-11-09 11:21:58 +08:00
tmfang
3ea0143ae5 New UI design for entity header on Q
- Implement a new entity header on Q.
- The new layout can be used for small screen,
  so delete useless layout.

Test: visual
Change-Id: I08eee26daef7ba707d6479eec501ddbe3e211370
Fixes: 116340579
2018-11-09 10:05:00 +08:00
TreeHugger Robot
4b83f9099b Merge "Do not tint app-icon of admin" 2018-11-09 00:11:27 +00:00
Philip P. Moltmann
6bd48be1dd Do not tint app-icon of admin
Only if no app-icon is used a tint should be applied to the ic_info
icon.

Change-Id: I92332110f99d14e86dc01700fa00b189c1d7d8ad
Fixes: 118879012
Test: Looked at dialog with default icon and with app-icon
2018-11-08 10:23:41 -08:00
Fan Zhang
2a98c843e8 Loading suggestions via legacy SuggestionService sometimes
When legacy_suggestion flag is turned on, load Suggestions from
SuggestionService instead of contextual homepage, because contextual
homepage infrastructure might not be availble on all devices.

Bug: 118842099
Test: robo
Change-Id: I91710c005e11be5a9b3dd39ceff670106e7f80c3
2018-11-07 11:55:09 -08:00
Mill Chen
0ca7130403 Update new UI of conditional cards
- Add half-width and full-width layouts for conditional cards
- Keep origin strings of conditional cards, that could make conditional
cards truncate its title and summary in half-width card.
- Add default value of isHalfWidth to each condition controller.

Bug: 113451905
Test: robotests, visual
Change-Id: Ib0055f32c4ab9e73c0e0a57c6b0ef586d52942e0
2018-11-07 16:06:31 +08:00
Sunny Shao
201f1f6146 Merge "Added the icon displayed on no account in search bar" 2018-11-05 05:31:03 +00:00
Sunny Shao
6dc1cc2a77 Added the icon displayed on no account in search bar
Mofidied the search_bar layout and added this icon in the right side of the search_bar.
Added the hasAccount api in AvatarViewMixin and display this icon when there is no any account in device.
Added the test case of the AvatarViewMixin.

Bug: 117509285
Test: robotest
Change-Id: I6ceaa457af4fb20acd0211ca840df5b530c47e0f
2018-11-05 10:52:11 +08:00
Emily Chuang
7d1fc0d3db Update the layout of contextual cards.
Fixes: 118849830
Test: visual
Change-Id: Ia3f7f155271a22f4f6214fad861475442c23c2f6
2018-11-05 10:49:19 +08:00
Cosmo Hsieh
c842290974 Merge "Implement NetworkRequestDialog architecture" 2018-11-02 01:39:47 +00:00
Kevin Chyn
0e11b18cf0 Merge changes from topic "biometric-cc"
* changes:
  3/n: Make CDCA transparent and add BiometricPrompt
  2/n: Add comments to launchConfirmationActivity parameters
  1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
2018-11-02 00:37:24 +00:00
Kevin Chyn
e5a016e076 1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
CDC is going to use BiometricPrompt instead. This change
removes FingerprintManager from CDC. BiometricPrompt
will show before pin/pattern/pass is shown.

Bug: 111461540

Test: modified BiometricPromptDemo to use
      KeyguardManager#createConfirmDeviceCredentialIntent,
Test: Fingerprint is gone from CDC, rotation works
Test: atest SettingsRoboTests

Change-Id: I9ce2aad71961af8a0d5ee636600e2fbdb6154e47
2018-11-01 14:11:57 -07:00
Emily Chuang
4b08270d8c Remove "See more" from wifi/bluetooth slices
- Also set the height of SliceView back to wrap_content as the space our
content needs can be satisfied with MODE_LARGE.

Change-Id: Ibaa514ac9c022c2723d99e5104f8d5ec63f14661
Fixes: 118763869
Test: robotests, visual
2018-11-01 12:32:51 -07:00
Fan Zhang
e4b4923dd0 Merge "Fix slice card layout so show more button works correctly" 2018-11-01 19:14:40 +00:00
cosmohsieh
cd192209ef Implement NetworkRequestDialog architecture
Bug: 117399926
Test: RunSettingsRoboTests

Change-Id: Ibf0a62a84bc3de080e4537ba084b0ff9a5e0e9a9
2018-10-31 11:26:00 +08:00
Fan Zhang
2fa9b7b652 Fix slice card layout so show more button works correctly
Change padding top/bottom to margin, so the sliceview can use the full
288dp height (4 rows + see more button).

Side effect is that ripple doesn't fill the entire cardview. But it
never did anyway.

Change-Id: Ie57187fbe2b8caa2cf9d0dc31d7678eee07085f4
Fixes: 118398695
Test: visual
2018-10-31 11:09:28 +08:00
jackqdyulei
2aae67a061 Rename a bunch of mobile network files
1. Make them have "MobileNetwork" prefix
2. Also update WifiCallingPreference to remove its category
if it is invisible

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I25871d579d6495e902e5583030889942ed2506a8
2018-10-30 16:28:56 -07:00
TreeHugger Robot
f93b925588 Merge "Use ImeAwareEditText in FingerprintSettings" 2018-10-29 22:48:29 +00:00
Yohei Yukawa
af4426bb65 Use ImeAwareEditText in FingerprintSettings
Like we did the same thing in the Settings app [1][2][3],
FingerprintSetting is another instance that should use
ImeAwareEditText to make sure InputMethodManager#showSoftInput() is
called after the EditText gains IME focus.

This approach should be more robust and easier to maintain than trying
to control the software keyboard visibility with
SOFT_INPUT_STATE_ALWAYS_VISIBLE, which is more complicated that people
think.

This CL also removes RenameDialog#mTextHadFocus since
RenameDialog#mDialogTextField is always focused when the dialog is
shown [4].

This CL also removes the following fields since they can just be a
local final variables that will be captured into callback.

 * RenameDialog#mFingerName
 * RenameDialog#mTextSelectionStart
 * RenameDialog#mTextSelectionEnd

 [1]: I182b05d3ff59fb3b4732d60d0d5a464f0e0e0235
      f6af093e2d
 [2]: I892d639f3cc5d43db553b682d5278b8ce2fe72da
      4803267106
 [3]: Ib75ba0f361b8b46c3b717cc1ffb864726958ed82
      b0bcbed372
 [4]: I5bb1b7227c1323595bf7f483e11e87e2c3550093
      7a1d52eb06

Fix: 118473687
Test: Manually verified as follows.
      1. Build and flash aosp_taimen-userdebug to Taimen
      2. Set up a fingerprint unlock.
      3. Rotate the device to landscape mode.
      4. Open Settings -> Security & location -> Fingerprint
      5. Re-enter password if necessary
      6. Tap "Finger 1"
      7. Make sure that AOSP Keyboard shows up
Change-Id: I2a137aa8f6a1ee2b67923bcf40e82320a56c7b59
2018-10-29 13:09:12 -07:00
Fan Zhang
444b5107e3 Animate contextual cards in after loading.
After initial loading, all cards slide down per material guideline.

Test: visual
Change-Id: I115e086a43fc9a2d4b4da3acad20be689fdee09d
2018-10-26 19:49:35 +00:00
Fan Zhang
c82b7494ea Delete some unused resources
Test: rebuild
Change-Id: Idbb639605bf92888d71a07a62553e2d943494635
2018-10-26 10:02:04 -07:00
Fan Zhang
5e6e6a14f2 Move all contextual card related classes.
... from homepage to contextualcards.

Test: rebuild
Change-Id: Id7889566ce1e7257eb699d963ae996906fdb58ff
2018-10-26 10:02:04 -07:00
Raff Tsai
db55661271 Change homepage layout
- merge PersonalSettingsFragment and TopLevelSettings together

Bug: 118224579
Test: manual
Change-Id: Ieee50a22babb25023e2a1767793e220862a38363
2018-10-23 19:37:19 +08:00
Johnson Lu
deb0000d86 Merge "Add preference for WiFi MAC randomization." 2018-10-22 00:53:54 +00:00
Johnson Lu
7a5719ff5b Add preference for WiFi MAC randomization.
Preference visibility contolled by feature flag -
settings_wifi_mac_randomization.

Bug: 1227787
Test: RunSettingsRoboTests

Change-Id: Ibad8d3ea2bfa3879acc1ec883b8c03f1979bde45
2018-10-19 11:54:25 +08:00
Lei Yu
0ff2f2d4d2 Merge "Update id for Toolbar" 2018-10-19 01:59:33 +00:00
jackqdyulei
1fccc048f5 Update id for Toolbar
If you use action_bar, it will show blank action bar.

Bug: 114749736
Test: Manual
Change-Id: I459eb00262e667446c88d7ff638b9a425a6eada2
2018-10-18 13:54:01 -07:00
TreeHugger Robot
31a59e56d3 Merge "Give SliceView a height to support four rows and show more button." 2018-10-18 16:31:52 +00:00
TreeHugger Robot
5477ffe081 Merge "Update toolbar for mobile network settings" 2018-10-17 20:20:08 +00:00
TreeHugger Robot
deaded12c7 Merge "Sync style of filter component in data usage" 2018-10-17 18:38:45 +00:00
jackqdyulei
52b08e42ba Update toolbar for mobile network settings
Bug: 114749736
Test: Manual
Change-Id: I9b01df83215ca6974b096060fa8d6669307c96e1
2018-10-17 10:02:46 -07:00
Emily Chuang
8d9b265620 Give SliceView a height to support four rows and show more button.
The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.

Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
2018-10-17 20:50:20 +08:00
Raff Tsai
cb6b34e893 Merge "Use the same layout style for contextual cards" 2018-10-17 10:02:40 +00:00
Fan Zhang
9c072cd621 Merge "Remove second_button from condition tile. It's never used." 2018-10-16 21:42:05 +00:00
tmfang
6e16b69887 Sync style of filter component in data usage
Settings have new filter component with settings style.
This CL replaced Spinner to SettingsSpinner in data usage page.

Change-Id: I212b6b6ed203f8bffd094c0180873060b93c39cb
Fixes: 117568930
Test: robotests, visual
2018-10-17 05:14:46 +08:00
Fan Zhang
e3e7387105 Remove second_button from condition tile. It's never used.
Change-Id: I69e50d3b777d36731eee024a437facdab67e7ffa
Fixes: 117823082
Test: visual
2018-10-16 12:12:21 -07:00
Raff Tsai
f7bb72c60c Use the same layout style for contextual cards
Test: manual
Change-Id: I41d86df5147290a17ef698f4f6a192081d1e0742
2018-10-16 21:47:58 +08:00
Raff Tsai
2493587202 Use DayNight theme in factory reset page
Change-Id: I3cc75a34aaec71c97d1dd83eaf40232de1fd4168
Fixes: 73738836
Test: Manual
2018-10-16 04:21:15 +00:00
Philip P. Moltmann
92f3a8afe3 Use renamed restricted icon size config-value
Bug: 116797641
Test: Built
Change-Id: I913d7fece475e19969f9d932c0992242308bb02f
2018-10-11 12:42:26 -07:00
Fan Zhang
3181e1aceb Change search fab to search bar.
- Remove search fab from layout xml
- Change RelativeLayout to CoordinatorLayout so we can use prebuilt
  scrolling behavior
- Minor update to theme so search bar background works in dark mode for
  the homepage activity.

Change-Id: If7408c12684be65137e04ae3bb4137204c2d77e0
Fixes: 117508596
Test: robotests, visual
2018-10-10 16:29:22 -07:00