Commit Graph

48548 Commits

Author SHA1 Message Date
TreeHugger Robot
3704899fc9 Merge changes from topic "settings-action-button"
* changes:
  Remove setButtonPositive method
  Apply new action button visual design
  Create a new visual design for action buttons
2018-11-16 10:45:29 +00:00
TreeHugger Robot
3f31a7820d Merge "Make UI refresh when there is only one contextual card left." 2018-11-16 09:50:31 +00:00
Yanting Yang
5b5d4c6d33 Merge "Add Low Storage slice to Contextual Settings Homepage" 2018-11-16 07:36:02 +00:00
tmfang
5c7f4de999 Remove setButtonPositive method
Since new UI design only exist two button in layout,
we don't need these methods anymore.

Test: robotest
Bug: 116346008
Change-Id: If2e8f7dddb9c13e480438f36fe3c5d6affa4e9ff
2018-11-16 14:33:16 +08:00
tmfang
3adb74ea60 Apply new action button visual design
- Add some icon resources.
- Add icon for each button in action button preference.
- Update "Enable" and "Disable" string to "Install" and "uninstall".
- Remove unused string.
- Add divider between entity header and action buttons.

Test: visual, robotest
Fixes: 119203074
Bug: 116346008
Change-Id: Ib8d7aeb2943d39d257e977b84f165f002bf47559
2018-11-16 14:33:03 +08:00
Emily Chuang
9c52951ba6 Make UI refresh when there is only one contextual card left.
After having card dismissal mechanism implemented, it is possible that
the card list loaded from the card loader will be empty (users may
dismiss all cards). When there is only one card remaining on the screen
and user dismiss it, the card should go away.

Fixes: 119580732
Test: robotest
Change-Id: I7ae3b03f16a0b8b009d8aa77811b5a6d39c359e7
2018-11-16 14:15:54 +08:00
Raff Tsai
d103f8eb81 Fix testcase fail
-Ignore testcase in RemoteDeviceNameDialogFragmentTest
-Fix SettingsPreferenceFragmentTest and ApnEditorTest testcase fail

Test: make RunSettingsRoboTests
Change-Id: I63053cd2256c9c00f92b57a813513e5df05fd60a
Bug: 119592320
2018-11-16 12:26:23 +08:00
Raff Tsai
6c731f4631 Merge "Fix crash on AppInfoDashboardFragment" 2018-11-16 02:14:23 +00:00
Beverly Tai
4fa2b88556 Merge "Add new settings page for apps overriding dnd" 2018-11-15 18:06:06 +00:00
tmfang
5659fc6ac9 Fix crash on AppInfoDashboardFragment
When AppInfoDashboardFragment launch a new page,
it sets SUB_INFO_FRAGMENT(1) as request code.

This request code is same as REQUEST_REMOVE_DEVICE_ADMIN(1).
So, when AppInfoDashboardFragment got onActivityResult callback,
it will handle the event about REQUEST_REMOVE_DEVICE_ADMIN.

So, we change REQUEST_REMOVE_DEVICE_ADMIN to a unique value.

Test: manual test, robotest
Fixes: 118841475

Change-Id: Idabd62c5062ccfbf4b8acee82df7401fc9ce7484
2018-11-15 16:58:29 +08:00
Yanting Yang
04eb082bce Add Low Storage slice to Contextual Settings Homepage
Bug: 114808204
Test: robotests, visual
Change-Id: I0c1a02dc40a0a72b7a2ad8f46505325e52bee942
2018-11-15 16:32:12 +08:00
Leon Liao
d6f13c1c49 Merge "Implement a11y UI for Accessibility timeout feature." 2018-11-15 07:17:40 +00:00
Stanley Wang
83680c7c98 Merge "Layout updated for file size text wrapping with largest display" 2018-11-15 07:10:49 +00:00
TreeHugger Robot
6f93c8bb31 Merge "Fix App permission doesn't show summary" 2018-11-15 04:10:40 +00:00
Leon Liao
fc29b1c331 Implement a11y UI for Accessibility timeout feature.
This UI control the Accessibility Timeout API in Settings App.
Add a user control to set timeout length to suit their need.

Bug: 119283926
Test: atest AccessibilityTimeoutControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=CodeInspectionTest
Test: atest UniquePreferenceTest
Change-Id: Ic8f7337e6bd7739c1189382cc87d45465b64c6ed
2018-11-15 10:24:43 +08:00
tmfang
8f65efa8f9 Create a new visual design for action buttons
- Create a new style for two action buttons.
- Change the layout of two_action_buttons.
  Since we use same style for positive/nagative
  buttons now, we only remain button1/button2 for
  this layout.
- Create a setButtonIcon interface in ActionButtonPreference.
  So, user can set icon for each button in this preferece.

Test: visual, robotest
Bug: 116346008
Change-Id: I511272cba5fd961349b85cae6d30004ddabe2c8e
2018-11-15 10:15:58 +08:00
TreeHugger Robot
ac6377199e Merge "Show device name in About Phone summary." 2018-11-15 02:13:35 +00:00
Raff Tsai
12b3c70d7b Merge "Change function modifier" 2018-11-15 02:09:54 +00:00
TreeHugger Robot
1a2d01b8a6 Merge "Use ColorDisplayManager" 2018-11-15 00:40:26 +00:00
Kevin Chyn
4cb30c6656 Merge "Fix ConfirmDeviceCredentials for work profiles" 2018-11-15 00:24:09 +00:00
Doris Ling
97d0593298 Show device name in About Phone summary.
- change from using device model to device name for the top level about
phone preference summary.

Change-Id: I6c1891f3867f55cf1501baf76ea147e2df49111e
Fixes: 119157622
Test: make RunSettingsRoboTests
2018-11-14 14:52:41 -08:00
Beverly
7973c635c9 Add new settings page for apps overriding dnd
Close starred contacts cursor

Test: atest ZenModeAllBypassingAppsPreferenceControllerTest
Test: atest ZenModeBypassingAppsPreferenceControllerTest
Bug: 111475013
Change-Id: I84d259aaef1bc5cc907ec5bef08beade91a8b904
2018-11-14 15:56:29 -05:00
TreeHugger Robot
8208d28461 Merge "Add setup chooselock internal activity to manifest." 2018-11-14 19:15:30 +00:00
Kevin Chyn
127da9c73c Fix ConfirmDeviceCredentials for work profiles
1) Fixed the theme for CDCA$InternalActivity to be transparent
2) CDCA only cares about biometrics, which are tied to userId
3) Moved shared methods to a util class

Fixes: 119296586

Test: Followed the steps in comment#1 of the bug linked above


Change-Id: Ie47fc7c3a53dfb7780087937e1ca83287cc52d71
2018-11-14 11:03:57 -08:00
TreeHugger Robot
2167b7deab Merge "Update delete user strings in multiple users page" 2018-11-14 18:12:24 +00:00
TreeHugger Robot
c052bcb8be Merge "Update strings" 2018-11-14 13:18:38 +00:00
Edgar Wang
22e29a28ee Update delete user strings in multiple users page
Change-Id: I3ab25e491af3894f8163d9ef9a88c446575ebbc3
Fixes: 111723127
Test: visual
2018-11-14 20:32:59 +08:00
Edgar Wang
913790b4cb Update strings
Bug: 118399687
Test: visual
Change-Id: I0b5f86235b7fd7530ba8eeed9649f0c3dc3b94bf
2018-11-14 18:17:32 +08:00
Eran Messeri
8e9e32e1b9 Merge "Private DNS: Add policy transparency" 2018-11-14 10:07:33 +00:00
Raff Tsai
3dbd1651d8 Change function modifier
- We need to use getName() function in different package

Test: rebuild
Bug: 79698338
Change-Id: I2e7eb71863fee14f58e84efd8064891f7e34fd3c
2018-11-14 17:42:25 +08:00
Yanting Yang
3085eac41f Merge "Add description into strings.xml for missing comment" 2018-11-14 09:25:16 +00:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
tmfang
057539f186 Fix App permission doesn't show summary
Since AppPermissionsPreferenceController assigns
a fixed preference key in constructor, so it can't
be used by same controller in Privacy page.

So, we change contructor directly, let controller
read preference key from xml file.

- Also remove unused imports.

Test: visual
Bug: 116628158
Change-Id: I42d6e978e91f0a2fe796d290cb9f34db596aa1f4
2018-11-14 16:25:48 +08:00
Fan Zhang
97d993fb3e Merge "Update logging: switch a bunch of action() logging calls." 2018-11-14 07:27:14 +00:00
Yanting Yang
0bfbdf1b1f Add description into strings.xml for missing comment
The comment of string "show_connected_devices" was missing from
ag/5336877.

Fixes: 119534057
Test: robotests
Change-Id: I445413cdcbb647e068a51312fa16f8c93abee36f
2018-11-14 15:24:06 +08:00
Fan Zhang
a6c7db1888 Update logging: switch a bunch of action() logging calls.
Use generic action(int, int, int, String, int) instead of
action(Context, int, string, Pair...) when possible.

Bug: 117860032
Test: robotests
Change-Id: I5213b52b2b10d80a3c488c37718df81b3b0a428f
2018-11-13 21:50:34 -08:00
TreeHugger Robot
d6cdafc0d7 Merge "Enabled the floating search bar feature" 2018-11-14 04:50:13 +00:00
TreeHugger Robot
345e154b89 Merge "Sort contextual cards based on their score." 2018-11-14 04:33:23 +00:00
Emily Chuang
f7f1b9b233 Sort contextual cards based on their score.
Fixes: 119493779
Bug: 111822376
Test: robotests
Change-Id: I254cba3c92ca1b58633f2ea6b2fa381607549e0c
2018-11-14 10:37:25 +08:00
Cosmo Hsieh
e57e432160 Merge "Implement NetworkRequestDialog architecture(cont.)" 2018-11-14 01:43:47 +00:00
Bill Yi
1361f73e3f [automerger skipped] Merge "Import translations. DO NOT MERGE" into pi-dev am: 1ba1a70dfb -s ours
am: 778b6372aa  -s ours

Change-Id: I73f12b6b2be25355e521a3cb90de69a5ee6bbf1c
2018-11-13 17:01:02 -08:00
Bill Yi
778b6372aa [automerger skipped] Merge "Import translations. DO NOT MERGE" into pi-dev
am: 1ba1a70dfb  -s ours

Change-Id: I190d08a244052ea324a288252848acf87fd12b53
2018-11-13 16:58:03 -08:00
TreeHugger Robot
1ba1a70dfb Merge "Import translations. DO NOT MERGE" into pi-dev 2018-11-14 00:49:33 +00:00
Doris Ling
069d293ba5 Add setup chooselock internal activity to manifest.
Declare SetupChooseLockGeneric$InternalActivity in AndroidManifest.xml
so that it can be launched properly.

Change-Id: Ia924f759c16d01c17a4f6a99d7c43bf13c0f494a
Fixes: 112706989
Test: atest com.android.settings.password.SetupChooseLockGenericTest
2018-11-13 16:42:35 -08:00
TreeHugger Robot
9ed341b9f0 Merge "Import translations. DO NOT MERGE" 2018-11-14 00:26:00 +00:00
Bill Yi
0301470757 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ic00cbf2b25c019d77c85c93203e58f4a1cf102c1
2018-11-13 14:42:50 -08:00
Bill Yi
2efeec49e7 Import translations. DO NOT MERGE
Change-Id: I4a3e3210380b6f4404c6b5a478eb64638431dd8e
Auto-generated-cl: translation import
2018-11-13 13:33:26 -08:00
John Reck
f68130c7c7 Merge "Add force SmartDark dev setting" 2018-11-13 20:33:37 +00:00
Risan
2ebf61cd61 Merge "Allow StubVolume to be browseable in Settings" am: 8f516adef7 am: e613923d66
am: 1670c69b7c

Change-Id: Id567d995f6f25a46225a2080609048051cca2337
2018-11-13 12:13:14 -08:00
Risan
1670c69b7c Merge "Allow StubVolume to be browseable in Settings" am: 8f516adef7
am: e613923d66

Change-Id: I8eea682dec3eba70a2d44c32ba6e28641118300a
2018-11-13 11:57:54 -08:00