When updating errorprone from 2.23.0 -> 2.32.0, more issues are found.
Bug: 253827323
Flag: EXEMPT refactor
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Iebb442f5e616861d1f2a2e2dc56a8ac72b18cb95
Show an error on tap instead. According to a11y guidelines this is preferrable.
Fixes: 369942776
Test: atest ZenModeEditDonePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ib5e47a4151c1515e5085a776d538a27c2ef41574
* Show contacts from personal and work profile.
* Open personal or work profile Contacts app when choosing settings.
* Skip conversations with no ShortcutInfo (they are returned for a disabled work profile but we cannot show an icon for them).
Fixes: 371513451
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: Id8653a85ee4fd15dfccbecb3ea2d31e615d29f8c
Extra information may be or may not be provided as this is given from the Carriers, therefore it is needed to hide when there is no given URL string
Bug: 360265682
Flag: EXEMPT bugfix
Test: manually test when extra information is valid and when extra information is empty
https://b.corp.google.com/issues/360265682#comment2 for UI test
result
Change-Id: Icf7f06e6af8580d0e84382a2598be75e321cf657
If the list isn't visible, we shouldn't allow HUNs to be
Test: ZenModeNotifVisFragmentTest, manual
Fixes: 367222597
Flag: EXEMPT bugfix
Change-Id: I1dc72061dfb99aed8b644c703214b17d62b0532e
With this change whenever private space is unlocked and has its own lock
different from device lock, it shows a custom title for PS in the unlock
screen.
Custom title for private profile will be shown in the auth screen while
authentiation of private lock for the below usecase inside PS settings.
- Auth shown while Delete private space from PS settings
- Switching to device screen lock from a separate private space lock
- Changing the private space lock type(Ex: from pattern to PIN)
- Adding a biometric(face/fingerprint) for private profile
When auth screen with custom title is put to background and the screen
is in the recents list and if private space is locked then the auth
scren with the title is removed from recents list along with the other
settings task.
Bug: 323835257
Test: Manual
Change-Id: Ia0cc0b9bb54a429ebe027dc0937320e7fd23cb81
Flag: android.multiuser.show_custom_unlock_title_inside_private_profile
In addition to looking nicer, this fixes two accessibility issues ("no hint when text is entered" and "reason for disabled button is unclear").
This requires a bit of theme merging black magic, because TextInputLayout requires a Theme.AppCompat descendant, which the Settings theme isn't.
Fixes: 356398157
Fixes: 370654542
Fixes: 369942776
Test: atest ZenModeEditNamePreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I92d8ec044dabc6daed5d755e206120ec7abc143e
If USER_TYPE_FULL_RESTRICTED is disallowed, addUserPreference is renamed to only mention user. But search results still state default name "Add user or profile". This change updates this entry in the search index.
Bug: 365899560
Test: atest UserSettingsTest#testGetRawDataToIndex_returnAllIndexablePreferences && atest UserSettingsTest#testGetRawDataToIndex_addRestrictedProfileAllowed_addUserTitleIsCorrect && atest UserSettingsTest#testGetRawDataToIndex_addRestrictedProfileDisallowed_addUserTitleIsCorrect
Flag: EXEMPT bugfix_only
Change-Id: I3c26180225491e4916141a3fca9d2e7ab36e8cfc
When atest on aosp_cf_x86_64_only_phone-trunk_staging-userdebug,
it said the "java.lang.NoSuchMethodError: No static method getCurrentCarrierNameForDisplay(Landroid/content/Context;)Ljava/lang/CharSequence; in class Lcom/android/settings/network/telephony/MobileNetworkUtils;"
Bug: 370884447
Bug: 370425683
Change-Id: I76bfc4c1cabaf569d74309e9e9ad6612f5649d9b
Test: atest MobileNetworkUtilsTest
Flag: EXEMPT bugfix
When failure occurs after scanning wifi QR code, only "Check connection
and try again" will show, which is confusing for user to understand the
errors and take next action.
Add more string resources to cover different errors.
Co-authored-by: Yufan Cao <Yufan.Cao@sony.com>
Flag: EXEMPT bugfix
Test: manual test
Bug: 362305039
Change-Id: I85145eb67eecdc3aa06bb7b8a7b3e7f0ffea1f62
