Commit Graph

54469 Commits

Author SHA1 Message Date
TreeHugger Robot
1bcc2ff789 Merge "Separate auto click preference controller from accessibility" 2019-06-28 03:01:21 +00:00
Winson Chung
7c896fa1c0 Merge "Adding unique task affinity for FallbackHome activity" into qt-dev am: 9591c3f963 am: 8bf207bab6
am: 27424848e8

Change-Id: Ifce634aa74f79829ba618b0d8b20c75e04a38532
2019-06-27 17:10:57 -07:00
Winson Chung
27424848e8 Merge "Adding unique task affinity for FallbackHome activity" into qt-dev am: 9591c3f963
am: 8bf207bab6

Change-Id: I6461b114459160029df2caf8bfe86ad761cfd9be
2019-06-27 16:37:13 -07:00
Winson Chung
8bf207bab6 Merge "Adding unique task affinity for FallbackHome activity" into qt-dev
am: 9591c3f963

Change-Id: Ie07033339ce3ed1ee57d5ab68e56b9a51135ac77
2019-06-27 16:24:53 -07:00
Winson Chung
9591c3f963 Merge "Adding unique task affinity for FallbackHome activity" into qt-dev 2019-06-27 22:47:14 +00:00
TreeHugger Robot
48d5ca1692 Merge "Separate power button preference controller from accessibility" 2019-06-27 18:19:26 +00:00
TreeHugger Robot
ea670560a2 Merge "Fix RTL issue of Deferred Setup card" 2019-06-27 16:32:42 +00:00
Mill Chen
c786ae184b Separate power button preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: Ia3c2134bd9f88a39a796e4201f7bdf8c3015baa1
2019-06-27 22:59:55 +08:00
TreeHugger Robot
10fc07e72e Merge "Separate text contrast preference controller from accessibility" 2019-06-27 14:50:56 +00:00
Mill Chen
081ae31e7d Separate auto click preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I5125fd79d0bc257ebf8108dd84d520d25a0ed669
2019-06-27 22:40:45 +08:00
TreeHugger Robot
9ce9dd848b Merge "Update Settings overlayed icons." 2019-06-27 14:12:28 +00:00
TreeHugger Robot
9b1cf314b7 Merge "Separate large pointer preference controller from accessibility" 2019-06-27 14:11:59 +00:00
Yanting Yang
c200df360c Fix RTL issue of Deferred Setup card
Correct layout gravity to "start" to apply RTL layout.

Fixes: 131913172
Test: visual
Change-Id: I5935c5c1415070803141634ff4e92f1c65fc94f6
2019-06-27 21:26:16 +08:00
Mill Chen
5da94319aa Separate text contrast preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: Ia28d8038f341a1a74385d168f78da8a10cca8fcd
2019-06-27 21:17:37 +08:00
Louis Chang
397cdd6ead Adding unique task affinity for FallbackHome activity
Settings activities were launched and resided on home task
which was originally started by FallbackHome. Adding a
unique task affinity for FallbackHome activity in order to
prevent the task being reused by other Settings activities.

Bug: 135696366
Test: starting Settings activity before FallbackHome finishes
Change-Id: I3fe41dd3b77e37236b11006dbf08727783b6a2ec
2019-06-27 09:57:54 +08:00
Joshua Imbriani
5d00bdbdc5 Merge "Making changes to TTS pitch and rate also apply to work profiles" 2019-06-26 15:23:32 +00:00
Sunny Shao
a1a0f7d7ea Merge "Fixed the IllegalStateException on removing account" into qt-dev am: 5a69fac694 am: 27067657f2
am: 1ae1523a91

Change-Id: Idb9b4c65846d3b37bb7920f49712d16a0668ceb0
2019-06-26 04:53:03 -07:00
Sunny Shao
c15fd54810 Merge "Fixed the IllegalStateException on removing account" into qt-dev am: 5a69fac694 am: bfffb2ae74
am: e4310ea096

Change-Id: I51ee1d27e136d2e5be4ecfa29892125debefe80c
2019-06-26 04:51:29 -07:00
Sunny Shao
1ae1523a91 Merge "Fixed the IllegalStateException on removing account" into qt-dev am: 5a69fac694
am: 27067657f2

Change-Id: I86a40d4016d185fee5f45e2bb69cbf0814d9fbeb
2019-06-26 04:44:02 -07:00
Sunny Shao
e4310ea096 Merge "Fixed the IllegalStateException on removing account" into qt-dev am: 5a69fac694
am: bfffb2ae74

Change-Id: I51cbaf932b7dac50a2fd246d47f3fb69cd421c27
2019-06-26 04:43:25 -07:00
Sunny Shao
27067657f2 Merge "Fixed the IllegalStateException on removing account" into qt-dev
am: 5a69fac694

Change-Id: I6d87742bd0925237cb73171561118e4bdd363b8a
2019-06-26 04:35:26 -07:00
Sunny Shao
bfffb2ae74 Merge "Fixed the IllegalStateException on removing account" into qt-dev
am: 5a69fac694

Change-Id: I085502786e8883c7ffb346592bfebc1a3bb08209
2019-06-26 04:35:26 -07:00
TreeHugger Robot
5a69fac694 Merge "Fixed the IllegalStateException on removing account" into qt-dev 2019-06-26 11:15:35 +00:00
Mill Chen
d828275411 Separate large pointer preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: Id8e81f70d5121a97b6766b444298379f7ce062ea
2019-06-26 17:42:57 +08:00
TreeHugger Robot
01823a53af Merge "Separate disable animations preference controller from accessibility" 2019-06-26 08:42:03 +00:00
TreeHugger Robot
d5888bbf84 Merge "Separate a11y timeout preference controller from accessibility" 2019-06-26 08:38:11 +00:00
Mill Chen
223bf1b520 Separate a11y timeout preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: I00d40451b40c0a4d5e214b23d78139195d98e42b
2019-06-26 15:10:04 +08:00
Mill Chen
d2deb850d3 Separate disable animations preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I14f322d91179779f2d758c58a2ed729efc0b45f5
2019-06-26 14:58:44 +08:00
Antony Sargent
20b2f8ab50 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev am: 3288037bd2 am: fb52368873
am: dd3a072ce6

Change-Id: I7c2d2b76ac9cfb863d315401b7665885973a1038
2019-06-25 23:20:29 -07:00
Antony Sargent
8abc3d914d Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev am: 3288037bd2 am: e4e1f08781
am: 85a2cd23f7

Change-Id: I9b1c25d6b2a0ad36aee5134db0d831f640f97bf8
2019-06-25 23:19:13 -07:00
Antony Sargent
dd3a072ce6 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev am: 3288037bd2
am: fb52368873

Change-Id: Ib5a9f6d77ce599c8f0892c78fdd49105e0fc7fdd
2019-06-25 23:11:46 -07:00
Antony Sargent
85a2cd23f7 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev am: 3288037bd2
am: e4e1f08781

Change-Id: I5142d6a71e16dca999c4370ab65a371d90563aed
2019-06-25 23:11:15 -07:00
Antony Sargent
e4e1f08781 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev
am: 3288037bd2

Change-Id: I0edcbba1f4c19052daeb2e69c2dc36e839641d9f
2019-06-25 23:02:14 -07:00
Antony Sargent
fb52368873 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev
am: 3288037bd2

Change-Id: I5833f9ece2590b16ef3184f8d315fd092f683207
2019-06-25 23:02:14 -07:00
TreeHugger Robot
3288037bd2 Merge "Check isWfcProvisionedOnDevice in WifiCallingSettings" into qt-dev 2019-06-26 05:35:29 +00:00
Bill Yi
daec0749c3 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev am: 9905cc9b50 -s ours
am: 9e8e6dffa0 -s ours
am skip reason: subject contains skip directive

Change-Id: Ic9cc8b30718cac28df42090d4ddff0010b5953a6
2019-06-25 22:30:15 -07:00
Bill Yi
9e8e6dffa0 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am: 9905cc9b50 -s ours
am skip reason: subject contains skip directive

Change-Id: I62d2bdcc5dbdb6dcdc38184e063d9825a6b1c5cc
2019-06-25 22:22:11 -07:00
TreeHugger Robot
9905cc9b50 Merge "Import translations. DO NOT MERGE" into qt-r1-dev 2019-06-26 04:00:28 +00:00
Joshua Mccloskey
c4f18bb77c Merge "Adding slice for Face Enrollment" into qt-r1-dev am: 35252d1b9f
am: ef3d1939c8

Change-Id: I3c3b28e6ac2e67a588f970d8eae706390f666bc1
2019-06-25 19:31:34 -07:00
Joshua Mccloskey
ef3d1939c8 Merge "Adding slice for Face Enrollment" into qt-r1-dev
am: 35252d1b9f

Change-Id: Ic36d9fd8f00b01fe4c35e005cd9192b9cfe900e9
2019-06-25 18:58:54 -07:00
Joshua Mccloskey
35252d1b9f Merge "Adding slice for Face Enrollment" into qt-r1-dev 2019-06-26 01:15:50 +00:00
Vishwath Mohan
4964ad847e Change fingerprint reference to biometric for lockdown am: 947a93ea75
am: f035e6212b

Change-Id: I66a03fb04f0d2b6c1f9eb91f4360f840f0c54407
2019-06-25 17:20:35 -07:00
Vishwath Mohan
f035e6212b Change fingerprint reference to biometric for lockdown
am: 947a93ea75

Change-Id: I08cb46d1752fcc5c317378c8838b39906ef9e389
2019-06-25 17:04:09 -07:00
Bill Yi
a311a7f16f Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 134640169
Change-Id: Ifd9077857dbae28a18cf494a4c318669ec2b1519
2019-06-25 15:43:36 -07:00
Bill Yi
ce9197b1c0 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev am: 01d889815d -s ours
am: f6fd739942 -s ours
am skip reason: subject contains skip directive

Change-Id: Ie174a01aafefb1e84e422ea360ed61f05f5eac62
2019-06-25 14:28:05 -07:00
Antony Sargent
46d819272a Check isWfcProvisionedOnDevice in WifiCallingSettings
On the SIM details page, the preference leading to a page for
configuring wifi calling will appear based on the results of the
MobileNetworkUtils#isWifiCallingEnabled helper function. That helper
uses the ImsManager to check several conditions, among them both
isWfcEnabledByPlatform and isWfcProvisionedOnDevice.

The page for configuring wifi calling has a tabbed UX, with one tab for
each active subscription that supports it. The WifiCallingSettings class
gets a list of the active subscriptions to determine which tabs to show,
and removes any that don't support wifi calling, but was only using the
isWfcEnabledByPlatform test to do so. This is a problem because the code
for showing the contents inside the tab, in WifiCallingSettingsForSub,
includes a sanity check of isWfcProvisionedOnDevice and calls finish()
if that returns false.

What this meant in practice is that if you happened to have 2
subscriptions where one returns true for both isWfcEnabledByPlatform and
isWfcProvisionedOnDevice, but the other only returned true for
isWfcEnabledByPlatform, then you'd never be able to succesfully use the
wifi calling page at all because the tab for the subscription you
*aren't* trying to configure would always call finish() early.

The right long term solution to this problem is probably to remove the
tabbed UX entirely from this page, since we probably don't need it given
the overall new multi-SIM UX. But there may still be legacy uses and
that is likely a bigger change than we want to make right now.

As a stopgap, this CL just adds a check of isWfcProvisionedOnDevice to
the code for filtering out ineligible subscriptions from the tabbed
interface, which we should have always had anyway.

Fixes: 135591718
Test: make RunSettingsRoboTests
Change-Id: I656c3d3fb30cb6fabcb86685eae38c5f0cd0c6f2
2019-06-25 14:16:53 -07:00
Vishwath Mohan
947a93ea75 Change fingerprint reference to biometric for lockdown
Changes the lockdown description to reference biometric unlocks more
generally, and not just fingerprint unlock.

Bug: 135282412
Test: The string for lockdown does not refer to fingerprint
Change-Id: I8f1cf43bc8d42288d96a272b3243a7863c8d4941
2019-06-25 20:41:58 +00:00
Bill Yi
f6fd739942 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-r1-dev
am: 01d889815d -s ours
am skip reason: subject contains skip directive

Change-Id: I27937e9386711f9d177e23aff8ac382b0e26c794
2019-06-25 13:36:27 -07:00
TreeHugger Robot
01d889815d Merge "Import translations. DO NOT MERGE" into qt-r1-dev 2019-06-25 19:24:19 +00:00
Antony Sargent
8532344531 Merge "Add a listener for subscription changes to SimDialogFragment" into qt-dev am: 87fadeeb4a am: 48c61f173d
am: d7c09b1a65

Change-Id: I63c7402a440d21777a297982da73ee755a8459f4
2019-06-25 12:19:38 -07:00