Commit Graph

60062 Commits

Author SHA1 Message Date
Jeff Sharkey
1a703c4846 Revert "Ignore a lot of failed test cases on Settings"
This reverts commit d9d08ebd4f.

Bug: 154727109
Test: make RunSettingsRoboTests
Exempt-From-Owner-Approval: re-enabling tests
Change-Id: I4ed490f0199683ee84d687be17f7e90091deb7f1
2020-04-22 18:08:41 +00:00
TreeHugger Robot
d579af4d22 Merge "[Wi-Fi] Fix a fail WifiEnhancedMacRandomizationPreferenceControllerTest" into rvc-dev 2020-04-22 15:11:10 +00:00
Bonian Chen
673251973b Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 14:27:31 +00:00
Tom Hsu
49b82f8532 Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev 2020-04-22 12:16:09 +00:00
tom hsu
fa3c931ab6 Make ApnEditor can show the customized default value on UI.
- Edittext on edittextpreference
 - Summary on edittextpreference

Bug: 142440775
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest -j
Test: Sanity test pass with customized carrier data
   - data in summary and text of edittext preference correctly correctly
   display on.
Change-Id: I3162de19659df79c5873c730d7d32e4ed998bcbe
2020-04-22 12:15:50 +00:00
PETER LIANG
a83a8e29c3 Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev 2020-04-22 11:42:27 +00:00
Bonian Chen
0fef82fbd1 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ie1870523ce83e6a1fc56fe9bc4c61708e0e745c4
2020-04-22 18:22:35 +08:00
Bonian Chen
a4efeb7a0a Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev 2020-04-22 10:12:24 +00:00
TreeHugger Robot
f90d2b2bca Merge "Ignore a lot of failed test cases on Settings" into rvc-dev 2020-04-22 07:50:35 +00:00
Bonian Chen
7db5840dfe Merge "[Settings] Mobile data usage code refactor" into rvc-dev 2020-04-22 07:17:22 +00:00
TreeHugger Robot
766e060c75 Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev 2020-04-22 07:16:42 +00:00
Bonian Chen
af05f6303d Merge "[Settings] To avoid from crash when callback" into rvc-dev 2020-04-22 07:00:12 +00:00
Jason Chiu
1f91111c3a Merge "Fix the incorrect title of Panel" into rvc-dev 2020-04-22 06:30:12 +00:00
Jason Chiu
4bbc85eb54 Fix the incorrect title of Panel
Since panel activity is singleInstance, a newer panel will reuse the
same fragment as the previous panel when they are displayed one after
another.

Panel fragment has two kinds of exclusive header layout which shouldn't
be showed at the same time, so we have to reset their visible states
when creating panel content.

Fixes: 154668079
Test: robotest
Change-Id: I701a7cde4b43322fbc63ae1cb74c41dd23b37c0c
2020-04-22 06:29:57 +00:00
Stanley Wang
a5f3282ff7 Merge "Remove search result regression test from Settings." into rvc-dev 2020-04-22 05:54:15 +00:00
Tim Peng
55ce33fbe7 Incorrect checkbox icon in dynamic group panel
-Mutate icon to prevent modifying the original resource

Bug: 154673054
Test: build pass
Change-Id: I0e1a6506cb951f80f316649d27c7728132c05be6
2020-04-22 13:50:46 +08:00
TreeHugger Robot
d2291d447e Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev 2020-04-22 05:18:34 +00:00
Bonian Chen
6ea4727eb4 [Settings] Mobile data usage code refactor
Code refactor

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: If85207ebe2edb8c547bb6dac0c55bbd146b62361
2020-04-22 13:13:33 +08:00
Sunny Shao
d9d08ebd4f Ignore a lot of failed test cases on Settings
Bug: 154667181
Bug: 154667917
Bug: 154667745
Bug: 154668517
Bug: 154667730
Bug: 154668805
Bug: 154669079
Bug: 154668589
Bug: 154670012
Bug: 154669528
Bug: 154668369
Bug: 154670613
Bug: 154669869

Test: make RunSettingsRoboTests
Change-Id: I37bf61fcd965b821e0198c695720ff826c8417b9
2020-04-22 12:51:30 +08:00
Bonian Chen
1a8d501d7d [Settings] Adopt TelephonyBasePreferenceController to data usage
Adopt TelephonyBasePreferenceController in order to better support DSDS.

Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I502b93f01b289b72989ad3167131cc0c598b1583
2020-04-22 12:38:11 +08:00
Bonian Chen
8f26e88bd9 Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-22 04:27:43 +00:00
Menghan Li
9a527eb8ef Merge "Fix Auto click (dwell timing) does not speech out meaningful delay time in enlarge or scroll by volume key" into rvc-dev 2020-04-22 04:22:19 +00:00
TreeHugger Robot
9903bca4ec Merge "Refine inputRange layout in output switcher" into rvc-dev 2020-04-22 03:49:25 +00:00
Zhen Zhang
92340eb89e Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev 2020-04-22 02:52:58 +00:00
Bonian Chen
61b9714a34 [Settings] Fix DataUsageSummaryPreferenceControllerTest
Fix test case of DataUsageSummaryPreferenceControllerTest

Bug: 154562264
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I0b3366c86b0a621b9dda88bbcde6e118d37995b7
2020-04-22 10:39:42 +08:00
tim peng
24205d4632 Merge "The volume slider should not show for the unselected device" into rvc-dev 2020-04-22 01:00:33 +00:00
tim peng
143668668b Merge "Fix Robotest failed" into rvc-dev 2020-04-22 00:59:38 +00:00
Arc Wang
ea3bfabee6 [Wi-Fi] Fix a fail WifiEnhancedMacRandomizationPreferenceControllerTest
Mock objects do not know the relation between setChecked
and isChecked. Should not call mock objects's setter and
assume the getter will return the corresponding value.

Bug: 154564960
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiEnhancedMacRandomizationPreferenceControllerTest
Change-Id: Ib2e06f0fe60f7d6f90f76bd179a7aadccfcff4c4
2020-04-22 08:25:45 +08:00
TreeHugger Robot
f11da4c787 Merge "Notification history a11y fixes" into rvc-dev 2020-04-21 21:22:44 +00:00
Beverly
4922aa006a Notification history a11y fixes
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.

- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction

Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00
TreeHugger Robot
0ff0929e0f Merge "Update ZenModeSettingsTest" into rvc-dev 2020-04-21 14:12:15 +00:00
Beverly
d796da16f0 Update ZenModeSettingsTest
String was updated

Test: make ROBOTEST_FILTER=ZenModeSettingsTest RunSettingsRoboTests
Fixes: 154568594
Change-Id: Ia67f7ff2e3692cc4f40b87e94e3d3952002a9e87
2020-04-21 09:31:16 -04:00
Stanley Wang
153c5d514e Remove search result regression test from Settings.
- Move the test to internal app.

Bug: 116673764
Test: atest SettingsSearchResultRegressionTest
Change-Id: I1d50b896c0f6d7de871f409249b55bc7bfa88f4a
2020-04-21 19:39:00 +08:00
Yanting Yang
bfe16291a3 Fix breadcrumb of search results provided by Settings
Settings Search need Settings to provide custom site map pairs to
build up full breadcrumb for the search results from Gesture Settings
page.

Bug: 147851992
Bug: 151206664
Test: visual and robotests
Change-Id: I4a61e6da48755184954c2c90834578030ffc2e10
2020-04-21 19:11:45 +08:00
Pavel Grafov
9341983324 Merge "Stop disabling wifi toggle when tethering is restricted" into rvc-dev 2020-04-21 10:40:12 +00:00
Jason Hsu
0055a74794 Merge "Show default description only if description and html description are empty" into rvc-dev 2020-04-21 09:41:15 +00:00
TreeHugger Robot
8a80769a7e Merge "[Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks" into rvc-dev 2020-04-21 09:20:52 +00:00
Tim Peng
5308d5f88b Fix Robotest failed
Bug: 154578656
Test: make -j50 RunSettingsRoboTests ROBOTEST_FILTER=MediaOutputGroupSliceTest
make -j50 RunSettingsRoboTests ROBOTEST_FILTER=MediaOutputSliceTest

Change-Id: If675c27ac412c2a49f9ed1c9b71a84c172f54fd6
2020-04-21 17:14:13 +08:00
Tim Peng
e94de7fbb2 The volume slider should not show for the unselected device
-Design changes

Bug: 154555379
Test: Manual test
Change-Id: Icb127867911bc4bba0b77ce374332451b23f1215
2020-04-21 09:10:02 +00:00
Bonian Chen
6fb4a18ded Merge "[Settings] Refactor test case DataUsageSummaryPreferenceControllerTest" into rvc-dev 2020-04-21 08:48:36 +00:00
Alex Johnston
56f06c59a1 Merge "Update Wi-Fi configs restrictions" into rvc-dev 2020-04-21 08:41:10 +00:00
TreeHugger Robot
a10969bfc5 Merge "Ignore a lot of failed roboletric test cases" into rvc-dev 2020-04-21 08:35:09 +00:00
Bonian Chen
5bc8aa7961 Merge "[Settings] Code refactor" into rvc-dev 2020-04-21 08:21:28 +00:00
Arc Wang
205b585cf3 [Wi-Fi] Show not show Wi-Fi edit UI for never connected open Wi-Fi networks
When users click a Wi-Fi network and it's
WifiConfiguration.getNetworkSelectionStatus().hasEverConnected()
is false, WifiSettings2 will launch the Wi-Fi edit UI for users
to edit password again.
It's not necessary to show the Wi-Fi edit UI if the Wi-Fi network
is a open network.

Bug: 154548505
Test: manual
      Click a never connected secure Wi-Fi and edit UI shows.
      Click a never connected open Wi-Fi and edit UI does not show.
Change-Id: Ie8489aff001942f92fbfaafd772f84b1b4a09cf4
2020-04-21 16:04:03 +08:00
Bonian Chen
57c2df4c7c Merge "[Settings] Support of DSDS API" into rvc-dev 2020-04-21 07:55:07 +00:00
Bonian Chen
dcef423720 [Settings] Refactor test case DataUsageSummaryPreferenceControllerTest
Refactor test case of DataUsageSummaryPreferenceControllerTest

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: Ieb551a32d87c53cbd0765e19e710f1f0469da9d5
2020-04-21 15:08:27 +08:00
Bonian Chen
0f47147543 [Settings] To avoid from crash when callback
Callback from SubscriptionManager and PhoneStateListner may comes in
under the case of Preference not available.

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I50b83b4488d272f6482bde5f09b57d59e6fc27a3
2020-04-21 15:02:14 +08:00
Sunny Shao
5094248487 Ignore a lot of failed roboletric test cases
Bug: 154568213
Bug: 154568594
Bug: 154567856
Bug: 154566065
Bug: 154566012
Bug: 154566007
Bug: 154564960
Bug: 154564366
Bug: 154564361
Bug: 154564994
Bug: 154563784
Bug: 154564243
Bug: 154563562
Bug: 154564136
Bug: 154564211
Bug: 154563778
Bug: 154563910
Bug: 154562715
Bug: 154563116
Bug: 154562264
Bug: 154562785
Bug: 154563290
Bug: 154561690
Bug: 154562361
Bug: 154560878
Bug: 154560145
Test: make RunSettingsRoboTests
Change-Id: I220540d519b222ad7d3b69070a9262bb25f22d23
2020-04-21 15:00:30 +08:00
Xiangyu/Malcolm Chen
eb27c7d94a Merge "Define a helper link for 5G limitation in DSDS footer." into rvc-dev 2020-04-21 06:47:18 +00:00
Bonian Chen
9bc2f7f8bc [Settings] Code refactor
Minor code refactor

Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: I060e7c880d91a0e5059610c5ceae319d47c19c7a
2020-04-21 14:43:48 +08:00