Commit Graph

121498 Commits

Author SHA1 Message Date
Angela Wang
874b32608c Merge "Changes screen flash color selected ring color in Flash Notifications" into udc-dev am: 39dd52d468
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22248253

Change-Id: I93bf3626c6ce09351dad08d93415eca95e065941
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 06:21:00 +00:00
Angela Wang
aa33027c92 Handles Flash Notifications intro if there's no valid camera
If there is no valid camera found on the device, the camera flash option will be hidden by default. It seems weired if the intro still mentions the camera light will flash while there's no camera flash option at all. Updates the intro string without mentioning camera light if there's no valid camera found.

Bug: 274565006
Test: check the string on device without valid camera manually
Change-Id: I93b1fe372fe9f9e2634e56b19b30898847d68c9c
2023-03-28 06:11:52 +00:00
Angela Wang
39dd52d468 Merge "Changes screen flash color selected ring color in Flash Notifications" into udc-dev 2023-03-28 05:56:44 +00:00
Jason Chiu
74e8f42570 Merge "Refine permission check process of 2-pane deep link" into udc-dev am: b1a932fd51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22235905

Change-Id: I4d8599301800389533781b4df449cfee0e6fe12a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 03:19:53 +00:00
Jason Chiu
b1a932fd51 Merge "Refine permission check process of 2-pane deep link" into udc-dev 2023-03-28 02:41:34 +00:00
TreeHugger Robot
9174a32040 Merge "Fix ordering on work profile" into udc-dev am: 509f94a8c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22233751

Change-Id: I14015be831e22bf3e020a609830fdf0021fe0575
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 17:35:59 +00:00
TreeHugger Robot
509f94a8c3 Merge "Fix ordering on work profile" into udc-dev 2023-03-27 17:02:17 +00:00
Julia Reynolds
11ac41d9b6 Don't show NLSes with excessively long component names
Test: install test app with long CN
Test: ServiceListingTest
Bug: 260570119
Change-Id: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
Merged-In: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
2023-03-27 16:14:27 +00:00
Julia Reynolds
79cb59e618 Don't show NLSes with excessively long component names
Test: install test app with long CN
Test: ServiceListingTest
Bug: 260570119
Change-Id: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
Merged-In: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
2023-03-27 16:13:15 +00:00
Matías Hernández
40e4a4b3c2 Merge "Prevent guest users from toggling "hide silent notifications"" into udc-dev am: 5755bbdd60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252122

Change-Id: I64b5ce9f98653c5bf93a2877ea540bddece6376f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 15:48:44 +00:00
Matías Hernández
5755bbdd60 Merge "Prevent guest users from toggling "hide silent notifications"" into udc-dev 2023-03-27 15:12:03 +00:00
Julia Reynolds
1f3969f615 Don't show NLSes with excessively long component names
Test: install test app with long CN
Test: ServiceListingTest
Bug: 260570119
Change-Id: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
2023-03-27 13:55:41 +00:00
Julia Reynolds
90ced5d2ec Don't show NLSes with excessively long component names
Test: install test app with long CN
Test: ServiceListingTest
Bug: 260570119
Change-Id: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
2023-03-27 13:54:48 +00:00
Julia Reynolds
793257967f Don't show NLSes with excessively long component names
Test: install test app with long CN
Test: ServiceListingTest
Bug: 260570119
Change-Id: I3ffd02f6cf6bf282e7fc264fd070ed3add4d8571
2023-03-27 13:53:52 +00:00
TreeHugger Robot
345616175f Merge "Unify logging timestamp string." into udc-dev am: 60ce0824d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22236481

Change-Id: I185c4cad7963dbf0d727e8f49b9312a1e9e68190
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 13:25:19 +00:00
TreeHugger Robot
60ce0824d9 Merge "Unify logging timestamp string." into udc-dev 2023-03-27 12:41:09 +00:00
Zaiyue Xue
9723490f63 Unify logging timestamp string.
Bug: 275278933
Fix: 275278933
Test: presubmit
Change-Id: Ifc67b9bf841f018465ee4a7b38b3a8605f60212b
2023-03-27 19:11:13 +08:00
TreeHugger Robot
3d8075069e Merge "Enlarges the size of the screen flash color buttons in Flash Notifications" into udc-dev am: 82bb3b8381
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22248254

Change-Id: Id0d754dc1796ded08ea7643f4700ff88d14c03cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 10:11:47 +00:00
TreeHugger Robot
82bb3b8381 Merge "Enlarges the size of the screen flash color buttons in Flash Notifications" into udc-dev 2023-03-27 10:06:21 +00:00
Bhavuk Jain
5a029593a4 Merge "Fixed tests based on return value of PIN length" into udc-dev am: 3635ddb279
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22287122

Change-Id: I4bef9cb4b1ce7ca4959bca24cfe2de20243c2fdd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 09:57:49 +00:00
Bhavuk Jain
3635ddb279 Merge "Fixed tests based on return value of PIN length" into udc-dev 2023-03-27 09:32:15 +00:00
Zoey Chen
74df414965 Merge "[Settings] Hide package name if needed" into udc-dev am: 26810aa0c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22221905

Change-Id: I28e6c65719cdb4b7a615c30f53d8efd772a13c8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 09:02:46 +00:00
Zoey Chen
26810aa0c5 Merge "[Settings] Hide package name if needed" into udc-dev 2023-03-27 08:44:37 +00:00
Angela Wang
a41640b76a Enlarges the size of the screen flash color buttons in Flash Notifications
The size of the screen flash color buttons are now 38dp x 38dp and it's recommended to make the height of these touch targets 48dp or larger.

Bug: 275265260
Test: runs Accessibility Scanner and checks the suggestions are gone
Change-Id: Ie2bef1a0ff976750f6258f7af3f28953c48b994f
2023-03-27 08:13:19 +00:00
Angela Wang
79588ff434 Changes screen flash color selected ring color in Flash Notifications
There's an outer ring to show that the screen flash color is selected and it's black in both light and dark themes.

When selecting screen flash color in the dark theme, it's not obvious which color is selected because the indicated ring is black which is similar to the dark background. Changing it to white in the dark theme for better user experience.

Bug: 275283917
Test: checks UI manually
Change-Id: I714597d99dfb74c5ce0ddef3995fd19688feacdf
2023-03-27 08:11:36 +00:00
Bhavuk Jain
e08f8a466d Fixed tests based on return value of PIN length
This CL aims at fixing the tests in Settings due to the fact that
earlier PIN length was being returned as a long whereas now it's being
returned as an integer now.

Bug: b/267222046
Test: atest AutoPinConfirmPreferenceControllerTest
Change-Id: Iee28557e25a411c2ce6a6245afaafb890b753261
2023-03-27 07:03:46 +00:00
Jason Chiu
5310c40640 Refine permission check process of 2-pane deep link
- Check the deep link activity instance before rediercting to the
  internal activity for the managed profile invocation so the caller
  can't bypass the permission check.
- Get the referrer as the caller so that onNewIntent can recognize the
  new caller and check if it has a permission to open the target page.

Test: robotest & manual
Bug: 268193384
Bug: 272437506
Change-Id: Ie69742983fb74ee2316b7aad16461db95ed927c2
2023-03-27 11:59:07 +08:00
ykhung
a9f8d606a6 Add includeProcessStateData() to include process data am: 89c6471454
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252151

Change-Id: I197e26b4a0e02c78a430f937447824ef46015d9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-27 03:51:28 +00:00
Ken Lin
d8c6dd4fe8 Correct the resolution illustration at the setting page
Replace xml with wrong description with correct one

Bug: 272650243
Test: check Setting -> Display -> Screen resolution
Change-Id: I878356800e965b19bb9064615d220212b35cca08
2023-03-27 02:49:25 +00:00
ykhung
89c6471454 Add includeProcessStateData() to include process data
Add includeProcessStateData() into the `BatteryUsageStatsQuery` build as  described in the b/274562089

Fix: 274562089
Test: presubmit & manual
Change-Id: I7be7424a6d2037c851134488033ec98667343a05
2023-03-27 01:47:36 +00:00
Chaohui Wang
88e20ec62e Fix SpaActivity launched twice for App Info
This happens when shouldShowTwoPaneDeepLink() return true, the
InstalledAppDetailsTop onCreate() is called twice.

Only try start spa when the activity is not finishing to fix.

Bug: 236346018
Test: Manually with Settings
Change-Id: I4b09fba0733a6451a2ba6fd90960f9151692a2ad
2023-03-26 22:39:20 +09:00
ykhung
a455a41a38 Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND for battery usage am: 3bc2805914
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252150

Change-Id: Ic684279afe45e945399a30ab3565e2570296aac6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 04:58:46 +00:00
ykhung
3bc2805914 Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND for battery usage
Remove MY_PACKAGE_REPLACED and MY_PACKAGE_SUSPEND action since Settings
is not store updatable, and it will reboot every time while updating. Originally, it is used on the store updatable extension engine.

Test: presubmit
Bug: 258576047
Change-Id: I9f2d58e3a822c4e4ebe182b03ace1b30f97d2340
2023-03-26 03:10:28 +00:00
TreeHugger Robot
c96b89c1d4 Merge "Record important battery usage event into SharedPreference for dump()" into udc-dev am: 0d3818fb0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252148

Change-Id: Ic9c2efaa9b3c243112b81b99be9a573e854a950f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 03:09:22 +00:00
TreeHugger Robot
0d3818fb0a Merge "Record important battery usage event into SharedPreference for dump()" into udc-dev 2023-03-26 02:38:55 +00:00
ykhung
1f3cf084c8 Record important battery usage event into SharedPreference for dump()
Fix: 268300677
Test: presubmit
Change-Id: If03106c265b984bc2608528bdf45386973e3a14f
2023-03-26 01:24:50 +08:00
TreeHugger Robot
d3dc54af3b Merge "Added "Speed and Compatibility" Settings page" into udc-dev am: df292224e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22164165

Change-Id: Ide1c3afa59772cb906f12a3db4803e29369c0935
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-25 08:19:59 +00:00
Jason Hsu
a954101966 Merge "Check whether support telephony for hearing device call routing" into udc-dev am: 5c01d725a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22164163

Change-Id: I6c50e1d3ccfbd70989f38c32e5b2e95b20ae6af8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-25 08:19:36 +00:00
TreeHugger Robot
df292224e2 Merge "Added "Speed and Compatibility" Settings page" into udc-dev 2023-03-25 08:01:30 +00:00
Jason Hsu
5c01d725a2 Merge "Check whether support telephony for hearing device call routing" into udc-dev 2023-03-25 07:41:44 +00:00
Betty Chang
49f0dd30c7 [automerger skipped] Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975 am: df94418ec6 -s ours am: 5face72c87 -s ours
am skip reason: Merged-In If9e666df7b987e0dbe3d550ac0af03b9d79230de with SHA-1 3512374f62 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: Ic551c05fa0ff20138a72dd5ad0b4b0db9bac1cd2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 17:15:34 +00:00
Becca Hughes
994e9395eb Fix ordering on work profile
Test: on device
Bug: 274126565
Change-Id: I137369fc9a2b5fbb2e200b6c906e11a9dea3a847
2023-03-24 16:42:26 +00:00
Betty Chang
5face72c87 [automerger skipped] Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975 am: df94418ec6 -s ours
am skip reason: Merged-In If9e666df7b987e0dbe3d550ac0af03b9d79230de with SHA-1 3512374f62 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: Ia878da405a0c4c5ad8487d467ebd9b3e6556f43d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 16:25:10 +00:00
Betty Chang
df94418ec6 Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d am: 6ac664c975
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: Ia05fb646720a4b0aeee71047f1aa9cecd519a6eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 15:56:20 +00:00
Betty Chang
6ac664c975 Merge "To fix the footer link is not clickable in the Bluetooth Settings" am: cc7da9e61d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2507379

Change-Id: I141e9cbef78ea7e192047d07e054f8810b376219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 15:26:58 +00:00
Betty Chang
cc7da9e61d Merge "To fix the footer link is not clickable in the Bluetooth Settings" 2023-03-24 15:01:48 +00:00
Zoey Chen
9108eded86 [Settings] NPE when finish MobileNetworkSettings am: 6929616581
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/22252145

Change-Id: Ifc94d1cc39c825906a36e6e3df9a1f953fe092d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 14:59:18 +00:00
Zoey Chen
7beb190e9c [Settings] Hide package name if needed
Bug: 273167633
Test: local test
Change-Id: I237d8f5821080283465a6cf72ad7505a55a6bb81
2023-03-24 14:00:31 +00:00
Zoey Chen
6929616581 [Settings] NPE when finish MobileNetworkSettings
Add NPE protection when finish

Bug: 271524675
Test: local test
Change-Id: I74bb54f2e591534b411589c150ce0bd993c2e6dd
2023-03-24 13:08:29 +00:00
Matías Hernández
005a382091 Prevent guest users from toggling "hide silent notifications"
This is a global setting, not per user, and shouldn't be modifiable by a guest. It can still be toggled by other, "normal" users, for the same global effect.

Fixes: 260570341
Test: atest
Change-Id: Id6e1803b5364f3b50bdbc14af0468979c96b5638
2023-03-24 12:15:58 +01:00