Commit Graph

49922 Commits

Author SHA1 Message Date
Yanting Yang
11a157a8e7 Fix preferences ordering issue in AccountSyncSettings
In Pie, it's alphabetical ordering in Accounts > Account sync detail page.
But Q doesn't follow it, intend to keep the same behavior.

Fixes:124382857
Test: visual, robotests
Change-Id: I593a4cc919daa0018d3874d84978e876198aae23
2019-02-20 21:18:28 +08:00
Xiangyu/Malcolm Chen
e67344a5c5 Merge "Correct behavior of "Mobile data" button on opportunistic subscriptions." 2019-02-19 21:04:01 +00:00
Malcolm Chen
5506e0c732 Correct behavior of "Mobile data" button on opportunistic subscriptions.
A check was added earlier to make sure in DSDS mode only one sub
shows data on, which is not true for opportunistic subscriptions. For
them, it should always be on (enforced by Telephony) and be disabled
as it shouldn't be turned off.

Bug: 124331860
Bug: 124683219
Test: manual, robolectric
Change-Id: I53c8d881ff71ad25c418085d3eee63e55c786b8f
2019-02-19 21:03:42 +00:00
TreeHugger Robot
7646786cd3 Merge "Add a util method of creating Icon with Drawable" 2019-02-19 12:25:17 +00:00
Jason Chiu
c78c54a9c6 Add a util method of creating Icon with Drawable
- Add a util method to help create Icon with Drawable so that
users don't need to handle bitmaps
- Add support for creating with ColorDrawable

Test: robotest
Fixes: 124407373
Change-Id: I1897256821cc804a5e599d967feb84a3bcd689a9
2019-02-19 15:51:38 +08:00
TreeHugger Robot
72c33375ff Merge "Visual update: update the icons for suggestions" 2019-02-19 05:53:44 +00:00
TreeHugger Robot
de08e6e901 Merge "Fix janky in App info screen" 2019-02-19 03:48:53 +00:00
Mill Chen
7195800371 Visual update: update the icons for suggestions
- remove blue tint
- add the icons of suggestions for contextual homepage

Bug: 122310542
Test: visual, rebuild
Change-Id: I2bac139669a4218455195aebeba83d1649184895
2019-02-18 18:03:09 +08:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
Yanting Yang
4bd94b9053 Remove deprecated EXCLUSIVE field from proto
Fixes: 123560880
Test: robotests
Change-Id: I6ff184dc5998d1e8eadfbfa16c8c7a85ebd75d98
2019-02-18 16:25:23 +08:00
TreeHugger Robot
c53f53c9ed Merge "[Network Connection] Implement "show all" button for NetworkRequestDialog" 2019-02-18 06:19:41 +00:00
TreeHugger Robot
70e97d29ef Merge "[Mac Randomization] Fix MAC randomization option does not work when ephemeral newtork" 2019-02-18 04:29:26 +00:00
TreeHugger Robot
56d2dd2515 Merge "Fix [RTL] Wifi QR Scanner option overlaps wifi Password text" 2019-02-18 04:13:39 +00:00
cosmohsieh
1e687606dd [Network Connection] Implement "show all" button for
NetworkRequestDialog

Add "show all" button to NetworkRequest dialog to let user be able to
show all AccessPoints of onMatch() callback.

Bug: 117985692
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I604083fd0f3ea98208d860a327733699cd4664d7
2019-02-18 11:42:59 +08:00
TreeHugger Robot
9e9dc49cb8 Merge "Add progress bar for Privacy screen" 2019-02-18 03:04:05 +00:00
cosmohsieh
5cbd97f4ea [Mac Randomization] Fix MAC randomization option does not work when
ephemeral newtork

WifiConfiguration is only available when saved network. So ephemeral
newtork could not have wifi config to config wifi setting. In this
situation, making option be not selectable.

Bug: 122919564
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I8a2a1c36ec6d41a6f912da29a8b17bc2e43d9a27
2019-02-18 10:55:42 +08:00
Yanting Yang
29934110dd Merge "Hide "Pair new device" from connected device slice" 2019-02-18 02:46:04 +00:00
TreeHugger Robot
4e706fc7c3 Merge "Remove feature flags of WiFi Sharing feature" 2019-02-18 02:42:33 +00:00
TreeHugger Robot
334f0a1e2e Merge "Fix failing robotest" 2019-02-16 02:30:16 +00:00
TreeHugger Robot
0b5ae6791c Merge "Move some slice related api out of BasePreferenceController" 2019-02-16 00:38:28 +00:00
Fan Zhang
9859b8b0b0 Fix failing robotest
Fixes: 124531152
Test: robotests
Change-Id: I4442ae543b062ef17b4bfd828134ede879d2b22d
2019-02-15 16:15:39 -08:00
TreeHugger Robot
bad926c890 Merge "Remove side padding for settings items in bigger screen." 2019-02-15 23:28:32 +00:00
TreeHugger Robot
6dca5ef8e9 Merge "Fix doubling of channel listing" 2019-02-15 22:46:15 +00:00
TreeHugger Robot
2195fd721a Merge "Fix legacy app notification pages" 2019-02-15 22:36:12 +00:00
Fan Zhang
45f961b624 Move some slice related api out of BasePreferenceController
And share with CustomSliceable.

Bug: 121150258
Test: rebuild
Change-Id: Ia5aed9c156fb168c1f001da6e37f7f12f191b385
2019-02-15 14:21:10 -08:00
Fan Zhang
1aa75aa71a Merge "Move registered slice set from settings to settingslib." 2019-02-15 22:14:22 +00:00
TreeHugger Robot
ee0c55bd23 Merge "Update some string char limits" 2019-02-15 21:49:23 +00:00
Doris Ling
e5df0b1934 Remove side padding for settings items in bigger screen.
Fixes: 110804029
Test: visual in emulator with tablet skin
Change-Id: Ib569731d8cff088c6d110c4ae9d43a7609416238
2019-02-15 13:33:00 -08:00
Julia Reynolds
0b6d652d20 Fix doubling of channel listing
Test: toggle a notification group on/off
Change-Id: Ia93cf8084aee0c886a591301cba764975e5e0147
Fixes: 124384280
2019-02-15 20:42:24 +00:00
Antony Sargent
a72540089e Update some string char limits
We got a bug requesting slightly longer character limits for of the some
new strings used when displaying information in multi-SIM mode.

Bug: 124474015
Test: n/a
Change-Id: I706586b2fc97ae8e6f0e809d2b3b168c7a9353c1
2019-02-15 11:37:05 -08:00
TreeHugger Robot
3f95dfefd5 Merge "Check flag to see whether to show accessibility usage dialog." 2019-02-15 19:09:08 +00:00
Maurice Lam
082e7967dc Merge "Revert "Revert "Remove TemplateLayout that is not for external use""" 2019-02-15 18:55:34 +00:00
Lei Yu
755a7d5b65 Merge "Update battery summary" 2019-02-15 18:26:56 +00:00
Julia Reynolds
7d914f509a Fix legacy app notification pages
Test: view legacy app notification page
Change-Id: Id0d7ac53bc0d9e4d7084bea7ff44d4d8a082cb74
Fixes: 124453411
2019-02-15 13:15:50 -05:00
Joel Galenson
858fa64d4a Check flag to see whether to show accessibility usage dialog.
Test: Manually set/unset flag, see/don't see dialog.
Test: atest AccessibilityUsagePreferenceControllerTest
Change-Id: I214cf0bf4c67889f48e43fdf774a943dd11e6c34
2019-02-15 08:16:33 -08:00
TreeHugger Robot
9232a4a147 Merge "Update the summary for DND conditional" 2019-02-15 15:42:35 +00:00
Yanting Yang
53656a1749 Hide "Pair new device" from connected device slice
Fixes:124460897
Test: visual, robotests
Change-Id: Id702bf77eacf29d831e00f56d0b1ab9c1f945fbb
2019-02-15 21:03:54 +08:00
Mill Chen
09fedbf7ec Update the summary for DND conditional
Since original string is too long for DND conditional subtext, separate
DND conditional to two different states, one is for "Phone muted" state,
the othe is for "With exceptions" state.

Also, clean up the strings of other product variants for the conditional.

Bug: 122929205
Test: visual
Change-Id: Icb156ff9a4858a26355d92e6d4fb82ad1927b278
2019-02-15 18:37:25 +08:00
Arc Wang
07ced72e67 Fix [RTL] Wifi QR Scanner option overlaps wifi Password text
Use android:layout_alignParentStart & android:layout_alignParentEnd
to fix the RTL issue. And refine code of the scanner button.

Bug: 123923904
Test: manual test
Change-Id: I85491b99d22ec303e370422a81a43fc203b695fa
2019-02-15 16:30:17 +08:00
Johnson Lu
3a5d9020e8 Remove feature flags of WiFi Sharing feature
Bug: 120744414
Test: Manual
Change-Id: I655ebb8d149d0976063845478bc667cc4d72d96d
2019-02-15 16:14:54 +08:00
Xin Li
b87dfdc189 [automerger skipped] Merge "DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into stage-aosp-master" into stage-aosp-master am: f6aad2aee8 -s ours
am: 82b262afbd -s ours
am skip reason: subject contains skip directive

Change-Id: Ic32a4ab23aa2bdf991881e12bcf99d73be042baa
2019-02-14 21:49:04 -08:00
Android Build Merger (Role)
fedb8d4dd1 Merge "[automerger skipped] DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into stage-aosp-master am: d61c2adf09 -s ours am: 44ace71846 -s ours am skip reason: subject contains skip directive" 2019-02-15 05:28:05 +00:00
TreeHugger Robot
63e0409cbb Merge "Use BiometricPrompt description field for CC description instead" 2019-02-15 05:14:46 +00:00
Xin Li
e52c18a41c [automerger skipped] DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into stage-aosp-master am: d61c2adf09 -s ours
am: 44ace71846 -s ours
am skip reason: subject contains skip directive

Change-Id: I2b9d869dd64767b498d75f3fe1c9a6746f943b56
2019-02-14 21:08:49 -08:00
TreeHugger Robot
2f6de9967b Merge "Add null check for CarrierConfig" 2019-02-15 03:41:25 +00:00
jackqdyulei
ef3b364728 Update battery summary
When it is charging, show "5% - charging"(not only "5%")

Bug: 112013485
Test: RunSettingsRoboTests
Change-Id: If2299cc4929d8fc40d63669b74590fafe39122dc
2019-02-14 19:11:10 -08:00
tmfang
64f5b796c2 Add progress bar for Privacy screen
We show up top linear progress bar
when Settings is querying permission usage data.

Test: visual, robotest
Fixes: 123539793
Change-Id: I350068856d1708eb054d2a205d9ca857214891ce
2019-02-15 11:01:10 +08:00
Kevin Chyn
200162b06a Use BiometricPrompt description field for CC description instead
The description field handles longer strings more gracefully

Fixes: 124001277

Test: 1) Open Wi-Fi picker
      2) Select gear on the connected network
      3) Select share button
      4) On BiometricPrompt, text is not cropped

Change-Id: I945830a137a0dc203bba04728b507ceff020dfdc
2019-02-14 17:43:45 -08:00
Xin Li
82b262afbd [automerger skipped] Merge "DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into stage-aosp-master" into stage-aosp-master
am: f6aad2aee8 -s ours
am skip reason: subject contains skip directive

Change-Id: I4bf7e0d090e49c1273ca1ad81bffe26825e34e47
2019-02-14 17:18:04 -08:00
Fan Zhang
0e060dad97 Merge "Do not allow draw on top for default sms picker." 2019-02-15 00:51:12 +00:00