Fan Zhang
1105a1a465
Convert more pages to use ActionButtonPreference
...
- text to speech page
- blue tooth detail page
- installed app page
Change-Id: Ib743a144cc6025055cd496ec077f13fce4db0c69
Bug: 63991885
Test: robotests
2017-08-01 14:27:42 -07:00
Alex Kulesza
3eb22656eb
Merge "Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e am: e9216ccbd3" into oc-mr1-dev-plus-aosp
...
am: 8bc726d770
2017-07-31 20:23:10 +00:00
Alex Kulesza
b509f87040
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e am: b76fe783e0
...
am: 5252372c15
2017-07-31 20:22:49 +00:00
Fan Zhang
6deb41abaa
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 56538f1775" into oc-mr1-dev-plus-aosp
...
am: 17cee2d180
2017-07-31 20:22:29 +00:00
Fan Zhang
543d7f1414
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 1b62cfb973" into oc-mr1-dev-plus-aosp
...
am: 6d591a3682
2017-07-31 20:22:05 +00:00
jackqdyulei
8c50e81e0c
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: b3a488c40c" into oc-mr1-dev-plus-aosp
...
am: c3829cab9d
2017-07-31 20:21:27 +00:00
jackqdyulei
7620f6555a
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: 68af5f3a5d" into oc-mr1-dev-plus-aosp
...
am: d8664d6cba
2017-07-31 20:20:47 +00:00
jackqdyulei
2955995268
Merge "Use package from sipper if default is null" into oc-mr1-dev am: 8be9d6519f
...
am: 6399937d47
2017-07-31 20:20:20 +00:00
Fan Zhang
aece99fd11
Merge "Layout tweak for app action buttons" into oc-mr1-dev am: 48d54ff2f6
...
am: 1f0b09c924
2017-07-31 20:20:00 +00:00
Android Build Merger (Role)
8bc726d770
Merge "Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e am: e9216ccbd3" into oc-mr1-dev-plus-aosp
2017-07-31 19:34:15 +00:00
Alex Kulesza
5b0dd165ed
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e
...
am: e9216ccbd3
2017-07-31 19:33:57 +00:00
Alex Kulesza
5252372c15
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev am: 8fd9c28b7e
...
am: b76fe783e0
2017-07-31 19:33:55 +00:00
Alex Kulesza
e9216ccbd3
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
...
am: 8fd9c28b7e
2017-07-31 19:30:16 +00:00
Alex Kulesza
b76fe783e0
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
...
am: 8fd9c28b7e
2017-07-31 19:30:16 +00:00
Android Build Merger (Role)
17cee2d180
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 56538f1775" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:51 +00:00
Android Build Merger (Role)
6d591a3682
Merge "Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7 am: 1b62cfb973" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:45 +00:00
Fan Zhang
9b3dfd9d2c
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7
...
am: 56538f1775
2017-07-31 19:28:33 +00:00
Fan Zhang
b43867dc5e
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev am: 9064072ed7
...
am: 1b62cfb973
2017-07-31 19:28:28 +00:00
Android Build Merger (Role)
c3829cab9d
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: b3a488c40c" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:26 +00:00
Android Build Merger (Role)
d8664d6cba
Merge "Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2 am: 68af5f3a5d" into oc-mr1-dev-plus-aosp
2017-07-31 19:28:21 +00:00
jackqdyulei
3d391cac88
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2
...
am: b3a488c40c
2017-07-31 19:27:56 +00:00
jackqdyulei
7bea7b2cdd
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev am: d6c9a8b5b2
...
am: 68af5f3a5d
2017-07-31 19:27:46 +00:00
jackqdyulei
6399937d47
Merge "Use package from sipper if default is null" into oc-mr1-dev
...
am: 8be9d6519f
2017-07-31 19:27:34 +00:00
Fan Zhang
1f0b09c924
Merge "Layout tweak for app action buttons" into oc-mr1-dev
...
am: 48d54ff2f6
2017-07-31 19:27:13 +00:00
TreeHugger Robot
8fd9c28b7e
Merge "Fixing bug in UsageGraph rendering." into oc-dr1-dev
2017-07-31 19:19:03 +00:00
Fan Zhang
1b62cfb973
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
...
am: 9064072ed7
2017-07-31 19:12:11 +00:00
jackqdyulei
68af5f3a5d
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
...
am: d6c9a8b5b2
2017-07-31 19:11:31 +00:00
Fan Zhang
56538f1775
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
...
am: 9064072ed7
2017-07-31 19:09:10 +00:00
jackqdyulei
b3a488c40c
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
...
am: d6c9a8b5b2
2017-07-31 19:08:31 +00:00
TreeHugger Robot
8be9d6519f
Merge "Use package from sipper if default is null" into oc-mr1-dev
2017-07-31 18:58:22 +00:00
TreeHugger Robot
48d54ff2f6
Merge "Layout tweak for app action buttons" into oc-mr1-dev
2017-07-31 18:57:09 +00:00
TreeHugger Robot
9064072ed7
Merge "Remove DND and all gesture suggestions from Settings" into oc-dr1-dev
2017-07-31 18:56:02 +00:00
TreeHugger Robot
d6c9a8b5b2
Merge "Create wrapper and shadow for AccessibilityManager" into oc-dr1-dev
2017-07-31 18:55:40 +00:00
Ajay Nadathur
0724a106fe
Merge "Change vision settings suggestion title" into oc-mr1-dev am: 9b89fb0080
...
am: 40c652b221
2017-07-31 18:34:29 +00:00
Ajay Nadathur
40c652b221
Merge "Change vision settings suggestion title" into oc-mr1-dev
...
am: 9b89fb0080
2017-07-31 18:30:57 +00:00
Ajay Nadathur
9b89fb0080
Merge "Change vision settings suggestion title" into oc-mr1-dev
2017-07-31 18:19:12 +00:00
Maurice Lam
d0f51e6177
Merge "Merge "Align screen lock options to view start" into oc-dr1-dev am: 5e2e0df356 am: 5faa5ab6ea" into oc-mr1-dev-plus-aosp
...
am: 1b032d9d39
2017-07-31 17:48:54 +00:00
Maurice Lam
10b3d87d34
Merge "Align screen lock options to view start" into oc-dr1-dev am: 5e2e0df356 am: 7c5fc6737c
...
am: d3c2026aae
2017-07-31 17:48:31 +00:00
Android Build Merger (Role)
1b032d9d39
Merge "Merge "Align screen lock options to view start" into oc-dr1-dev am: 5e2e0df356 am: 5faa5ab6ea" into oc-mr1-dev-plus-aosp
2017-07-31 17:45:32 +00:00
Maurice Lam
58b0e9f743
Merge "Align screen lock options to view start" into oc-dr1-dev am: 5e2e0df356
...
am: 5faa5ab6ea
2017-07-31 17:45:18 +00:00
Maurice Lam
d3c2026aae
Merge "Align screen lock options to view start" into oc-dr1-dev am: 5e2e0df356
...
am: 7c5fc6737c
2017-07-31 17:44:35 +00:00
Maurice Lam
7c5fc6737c
Merge "Align screen lock options to view start" into oc-dr1-dev
...
am: 5e2e0df356
2017-07-31 17:41:13 +00:00
Maurice Lam
5faa5ab6ea
Merge "Align screen lock options to view start" into oc-dr1-dev
...
am: 5e2e0df356
2017-07-31 17:41:12 +00:00
Maurice Lam
5e2e0df356
Merge "Align screen lock options to view start" into oc-dr1-dev
2017-07-31 17:35:07 +00:00
Pankaj Kanwar
2ce583e934
Merge "Add string needed to support carrier wifi in UI." into oc-mr1-dev am: 492c9f4d16
...
am: 99dc2bf58e
2017-07-31 17:16:21 +00:00
Pankaj Kanwar
99dc2bf58e
Merge "Add string needed to support carrier wifi in UI." into oc-mr1-dev
...
am: 492c9f4d16
2017-07-31 17:13:22 +00:00
Pankaj Kanwar
492c9f4d16
Merge "Add string needed to support carrier wifi in UI." into oc-mr1-dev
2017-07-31 17:09:00 +00:00
TreeHugger Robot
a7bd3e4a32
Merge "Update work briefcase asset."
2017-07-31 15:13:24 +00:00
Alex Kulesza
4a121ecfae
Fixing bug in UsageGraph rendering.
...
The calculateLocalPaths() method of UsageGraph converts a set of paths
in (milliseconds, percent) coordinates into the actual pixel values that
will be used for drawing. For the most part this is a one to one
process, but not always: input points that are too closely spaced to
draw accurately are skipped. The last point in the path, however, is
never skipped, in order to ensure that the graph ends at the correct
location.
The previous implementation of this method had a bug: the y-coordinates
of points that were skipped would be stored indefinitely (in the local
variable pendingYLoc) and then added back at the very end of the path
(under the condition i == mPaths.size() - 1 && pendingYLoc !=
PATH_DELIM). Under the right conditions, this led to the strange uptick
at the end of the graph seen in the associated bug.
This CL fixes the problem and attempts to make the logic slightly
clearer. It also adds tests, one of which (_similarPointMiddle) fails
for the previous code.
In more detail, previously pendingXLoc was used to hold the last x
coordinate seen, while pendingYLoc was used to hold the last *skipped* y
coordinate, or PATH_DELIM otherwise. The difference between these was
somewhat subtle and hard to understand from a quick read of the code,
and there was a bug: pendingYLoc never got reset to PATH_DELIM even if
later points were added. In this CL I have removed the pendingLoc
variables in favor of a single lx/ly pair, which always holds the local
coordinates of the most recent point, and I added an explicit boolean
skippedLastPoint to track whether the point (lx, ly) has already been
added or was skipped.
Bug: 64065296
Test: make RunSettingsRoboTests
Change-Id: I45ccffea1280d851bfae5143c2e84d188e133731
2017-07-31 11:12:17 -04:00
Fan Zhang
c16f7d55a2
Merge "Update search bar's navup content description" into oc-dr1-dev am: b79d38f2f3 am: d58a499c02
...
am: 320680e817
2017-07-29 00:24:36 +00:00
