Commit Graph

24303 Commits

Author SHA1 Message Date
Matthew DeVore
f6ad8e392e Merge "Detect when user wanted to drag vs. click" into main 2025-02-12 07:13:45 -08:00
Zoey Chen
09841d6bb4 [Settings] Apply new style to dialog
Bug: 394542699
Test: manual
Test: atest SettingsRoboTests:com.android.settings.localepicker.LocaleListEditorTest
Flag: EXEMPT refactor
Change-Id: Idfed52722d1113e432742342fd8a56958e84406e
2025-02-12 12:59:54 +00:00
Kanyinsola Fapohunda
8c427e654e Hide "Send feedback" button if no target exists.
This change hides the "Send feedback" button  when a target for
the intent is not found. This will ensure the button is not
visible in cases when clicking it would have done nothing.

Bug: 283239837
Flag: com.android.settings.flags.datetime_feedback
Test: Test: atest TimeFeedbackPreferenceControllerTest.java
Change-Id: I8bb18c313925a7dc7ac07a1fb4c2f9e2d98352db
2025-02-12 03:42:29 -08:00
Ashley Newson
6fc2502a7b Merge "Add developer settings link to WebView DevTools" into main 2025-02-12 02:28:26 -08:00
Jason Hsu
29557d6017 Merge "Show intro and footer string according to the device's supported status" into main 2025-02-11 23:44:01 -08:00
Pawan Wagh
4a55472cf3 Check if device is online before starting 16kb test
Test: atest -c Enable16KbTest
Bug: 390535191
Change-Id: I32cc404f8e84fba0e90ecb5b801d98908242292d
2025-02-11 22:39:38 +00:00
Yuri Lin
1500f3ecc0 Update ZenModeAddBypassingApps to not binder call for every app
This update already happened for ZenModeAllBypassingApps to use the new single binder call to get all packages bypassing DND. This change uses that method for bypassing apps as well as collecting the set of all apps with a nonzero number of channels.

Bug: 368623163
Bug: 394614704
Test: ZenModeAddBypassingAppsPreferenceControllerTest, manual to confirm correct behavior
Flag: android.app.nm_binder_perf_get_apps_with_channels
Change-Id: I72a1edcb07d18f5707591a5341d7a7338c23f42b
2025-02-11 17:20:46 -05:00
Aleksander Morgado
731df0fa98 Phone number only available if telephony capable
The Phone Number field in either the about or network details pages
should not be shown if the device does not have telephony
capabilities.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I04f682cc829d5dc7879e6cdacdaebc55a3b6fd2c
2025-02-11 18:43:40 +00:00
Aleksander Morgado
571103b891 Phone number only available for admin users
The phone number is hidden to non-admin users, following the same
reasoning that exists for other telephony-specific fields like the
baseband IMEI.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I4e612219d0c7439930e91b3e1d6e368a0dfd073e
2025-02-11 18:30:42 +00:00
Matías Hernández
7235474792 Inline MODES_API flag
Bug: 310620812
Test: Preexisting
Flag: EXEMPT Inlining flag
Change-Id: I54ad81d87ea4ce85940400b0e8680a1bac0ca342
2025-02-11 15:14:24 +01:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
jasonwshsu
9cfc96d948 Show intro and footer string according to the device's supported status
Bug: 390078046
Bug: 386121967
Test: atest HearingAidHelperTest HearingDeviceFooterPreferenceControllerTest HearingDeviceIntroPreferenceControllerTest BluetoothDetailsHearingDeviceSettingsControllerTest
Flag: EXEMPT bugfix
Change-Id: I564cdb80cd14f4d2d8e882b64db939449c6936b7
Signed-off-by: Jie Wang <jie.x.wang@sony.com>
Signed-off-by: Jason Hsu <jasonwshsu@google.com>
2025-02-11 17:26:37 +08:00
Yiyi Shen
009747cef9 Merge "[Audiosharing] Block pairing during audio sharing" into main 2025-02-10 21:10:43 -08:00
Wa Gao
baf503050f Disable the ContentProtection setting switch bar when current user is a guest user.
Bug: 337774836
Test: m -j256 Settings && atest
SettingsRoboTests:ContentProtectionTogglePreferenceControllerTest
Flag: EXEMPT bugfix

Change-Id: I36173b2e7027765b526dfa2ebca216a7de71e669
2025-02-10 19:32:11 -08:00
Treehugger Robot
1b1fa4810f Merge "[Satellite] Add satellite string for KDDI if no entitlement" into main 2025-02-10 19:30:27 -08:00
tom hsu
292f1bdd01 [Satellite] Add satellite string for KDDI if no entitlement
- Currently Android only handles Satellite w/ entitlement for any notifications. Some carriers such as KDDI have no entitlement for satellite service, so this change is to add some strings to avoid any confuse to Android user on satellite service.

Flag: EXEMPT resource update
Fix: b/382387532
Test: Manual test
Test: atest pass
Change-Id: I835787c9e0fe29eeecec0470e9bd6b38939abd8c
2025-02-10 18:26:35 -08:00
Matthew DeVore
da0bd7b412 Detect when user wanted to drag vs. click
In order to avoid sending a new topology to DisplayManager
unnecessarily, which could cause some disruptive visual effect, don't do
anything if the drag was both (a) brief and (b) did nto deviate from
start position.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: DisplayTopologyPanePreferenceTest
Test: manual - quickly drag as few pixels as possible and verify the block moved back after drag, with no scale change
Bug: b/352648432
Change-Id: I29ffb51c54c9dbac970149cffd86a8027f0a42f5
2025-02-11 01:52:28 +00:00
Will Leshner
6f21b063f8 Only show "hub mode" settings when the glanceable_hub_v2 flag is true.
Bug: 395320922
Test: atest CommunalPreferenceControllerTest
Flag: com.android.systemui.glanceable_hub_v2
Change-Id: I46e5931205a219806917fafcc1a7aac3b7046796
2025-02-10 09:57:23 -08:00
Matthew DeVore
a7caa23deb Merge "Show topology pane in per-display fragment" into main 2025-02-10 09:47:44 -08:00
Tomasz Wasilczyk
f38579f786 Merge "Fix settings crashes on missing Telephony features" into main 2025-02-10 09:20:25 -08:00
Yiyi Shen
93f9061794 [Audiosharing] Block pairing during audio sharing
When a) there are two sinks in sharing b) there is at least one temp
bond device connected

Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: Id093b4c0b67bdc1db621e0241e79900abbd26c0f
2025-02-10 18:38:53 +08:00
Yiyi Shen
ef77d14185 Merge "[Audiosharing] Set temp bond metadata for just bonded lea buds in sharing" into main 2025-02-10 01:52:41 -08:00
Jack Yu
94ecf1f216 Merge "Removed the flag enable_modem_cipher_transparency_unsol_events" into main 2025-02-10 00:47:42 -08:00
Tomasz Wasilczyk
6a311b9f5b Fix settings crashes on missing Telephony features
Bug: 310710841
Test: open settings app
Flag: EXEMPT bugfix
Change-Id: Ic96585fb34902de54ec838c5692673b33edd2c27
2025-02-08 21:34:21 -08:00
Ben Lin
1493a261d7 Merge "Update DesktopMode API name." into main 2025-02-08 10:48:00 -08:00
Victor Li
cc2b6ab418 Merge "Set a value in Settings.Global to indicate if user is on audio sharing dashboard fragment" into main 2025-02-07 23:03:51 -08:00
Victor Li
3ac6ab440c Set a value in Settings.Global to indicate if user is on audio sharing dashboard fragment
Change-Id: I081db5db644cdc42294063783c29a93914e12328
BUG: 394810407
2025-02-07 21:14:23 -08:00
Jacky Wang
02c378757f [Catalyst] Provide GetValueResult.metadata whenever possible
Fix: 394975570
Flag: com.android.settingslib.flags.settings_catalyst
Test: atest
Change-Id: Ifbe92902e0337f00d6b2154c7bad9fda460a4a78
2025-02-08 12:51:01 +08:00
Treehugger Robot
60c6d8ead5 Merge "Support customization for biometrics SafeSourceIssue" into main 2025-02-07 16:05:30 -08:00
Jack Yu
a8db4d190e Removed the flag enable_modem_cipher_transparency_unsol_events
Removed the 24Q3 flag enable_modem_cipher_transparency_unsol_events

Bug: 283336425
Test: atest FrameworksTelephonyTests
Test: Basic telephony functionality tests
Flag: EXEMPT flag cleanup
Change-Id: I08e206d721f99f9422a117dbe009561b434a43bf
2025-02-07 15:41:18 -08:00
Treehugger Robot
b0a4c54cc3 Merge "Removed the tests with flags disabled" into main 2025-02-07 14:21:26 -08:00
Yuhan Yang
92754decdb Merge "Add summary for autoclick cursor size row" into main 2025-02-07 14:13:50 -08:00
Yuhan Yang
b968400c13 Merge "Add Autoclick cursor area size settings dialog" into main 2025-02-07 14:12:58 -08:00
Jack Yu
068fbc9860 Removed the tests with flags disabled
Flags are enabled already. The flag disabled tests should be
removed.

Fix: 395131189
Test: atest CellularSecurityNotificationsPreferenceControllerTest
Flag: EXEMPT test fix
Change-Id: I40d5c56956b714ba563cb545807deb1dee9e8d8a
2025-02-07 13:37:25 -08:00
Yuhan Yang
c3f467dd71 Add summary for autoclick cursor size row
Screencast: go/screencast-njm3ndi4njm4ntixnzuznnw3nmy5m2fkms00ng

Bug: 390460480
Test: ToggleAutoclickCustomSeekbarControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I951be8da3e10f2a3ba0c6ff6e88a8a059db0f1ed
2025-02-07 21:06:12 +00:00
Matthew DeVore
faa7bc846e Merge "Run body of applyTopology for all non-noop drags" into main 2025-02-07 12:20:19 -08:00
Yuhan Yang
7630d396a6 Add Autoclick cursor area size settings dialog
Replace Autoclick sliderbar with an alert dialog
and radio group to match the new UI requirement.

Screenshot:
 - Click area column:
   go/screenshot-5AfdF7FGghsdiXk
 - Alert dialog:
   go/screenshot-4dgtojcc6lvjtyy

Bug: 390460480
Test: ToggleAutoclickCustomSeekbarControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic79f8833e69dde8d8eb3e945e5acd551d2ee9ff5
2025-02-07 19:58:53 +00:00
Matthew DeVore
83a1d4360f Show topology pane in per-display fragment
Some changes made to the UI, i.e. presence or absence of items, based on
feedback. There is some ambiguity because we are not fully v2 yet, hence
this change.

When all external displays are attached after opening the fragment, we
now show no preference items, whereas before we showed the pane with
built-in display options.

If only one external display is attached, we skip the "display list"
version of the fragment, and instead show the pane and other v2 items in
the per-display fragment.

If 2 or more external displays are attached, we do not show the pane
after selecting a display, which makes the rotation/resolution items
easier to find. I tried to get scrollToPreference to work but could not,
and it could be a little disorienting anyway.

To help manage the growing number of setOrder calls, keep the order
values as well as other pref data in a single spot. This also reduces
the amount of boilerplate around constants needed and makes uniform how
multiple preferences are built.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/366056922
Bug: b/394361999
Test: TODO
Change-Id: Iaa33f6d9220a1658a372c0432fe159a69dbb88a5
2025-02-07 19:18:16 +00:00
Matthew DeVore
eeec7d0d66 Run body of applyTopology for all non-noop drags
In onBlockTouchUp, if DisplayTopology.rearrange happened to revert the
change made by the drag so that it matched the before-drag layout, the
blocks would not be moved, so the block would be in the dragged position
but not the normalized position.

This will happen when rearrange has a bug or is otherwise optimizing the
layout, which is dependent on the implementation of rearrange.

The test field mTimesReceivedSameTopology has been replaced with one
that represents an observable positive operation:
mTimesRefreshedBlocks, the validation of which has been added to some
existing tests.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: move display so that rearrange reverts the change, then exit and re-enter the external display fragment, and verify it matches the state when left
Test: DisplayTopologyPreferenceTest
Bug: b/394361999
Bug: b/394355269
Change-Id: Ic3028747d283db77f144831352b7687fe2706391
2025-02-07 12:58:06 -06:00
Aleksander Morgado
035a15ac37 Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
The new test checks whether the item is available when the
SubscriptionUtil.isSimHardwareVisible() method returns true, i.e. if
the config_show_sim_info boolean flag is true on non-test runtime.

The default visibility status for all tests is defined in the test
setup() method, as this will also simplify the addition of new checks
later on.

Bug: 392808943
Flag: EXEMPT test only
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: Icedef190a8140fd8164dd8035ae93735a666b9f0
2025-02-07 14:53:25 +00:00
Aleksander Morgado
616fbc4f93 Added unit tests for PhoneNumberPreferenceController visibility
The tests check whether the item is available based on the result of
the SubscriptionUtil.isSimHardwareVisible() method, which is the one
allowing to check the value of the config_show_sim_info boolean flag
on non-test runtime.

Bug: 392808943
Flag: EXEMPT test only
Test: atest PhoneNumberPreferenceControllerTest

Change-Id: I2d1361ecef8a9c1083b4fd6fd4462c7815574827
2025-02-07 14:53:16 +00:00
Yiyi Shen
5732773031 [Audiosharing] Set temp bond metadata for just bonded lea buds in sharing
Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: I99e9955d00362125b7cbf54e2013c99dd2f9b457
2025-02-07 19:20:29 +08:00
YK Hung
fc86da0f6d Merge "Use BatteryOptimizeUtils to add packageName into PowerSaveWhitelistUserApps allowlist, which will force set app into Unrestricted Mode" into main 2025-02-06 22:44:33 -08:00
Kevin Liu
8384d162d0 Merge "Temp disable test that contains custom shadow within it" into main am: d1b8b3a7e1 am: 0db2f6c60f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3479734

Change-Id: Ibb99bff0e14112bab302f89de9da40d4910c78a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 11:55:15 -08:00
Liefu Liu
9852033728 Merge "Update the sub title of SIM preference in Contacts Storage Setting, to be consistent with "Device-only" preference." into main 2025-02-06 10:52:40 -08:00
Angela Wang
6f0f6e7cf6 Merge "Hide ambient control when there's no valid control point" into main 2025-02-06 09:17:37 -08:00
Shawn Lin
6f4f66e5ed Support customization for biometrics SafeSourceIssue
Notify issue action launch when enrollment process is canceled

Bug: 370940762
Test: atest FaceEnrollTest FingerprintEnrollTest
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: I91e2dcf44ee8cfd3e7c74d05f51a1ef30ea6f8b2
2025-02-06 16:30:55 +00:00
Kevin Liu
a9e22be8a5 Temp disable test that contains custom shadow within it
We need proper support or Exception throw for this scenario

Test: atest SettingsRoboTests
Bug: 394813533
Change-Id: I8b552f7b2bff166643bdaa492dceff23679116ff
2025-02-06 14:48:43 +00:00
Shaowei Shen
086c8b7955 Merge "[Physical Keyboard] Move Dialog to DialogFragment" into main 2025-02-06 02:20:41 -08:00
Yuri Ufimtsev
ec78150e69 Merge "Allow the LockPatterUtils to be null" into main 2025-02-06 01:37:56 -08:00