Commit Graph

24303 Commits

Author SHA1 Message Date
Ze Li
6a29b1c779 [Battery refactor] Move stylus related functions to BluetoothUtils as util functions.
Test: com.android.settings.bluetooth.BluetoothDeviceDetailsFragment, com.android.settings.connecteddevice.stylus.StylusDevicesControllerTest
Bug: 397847825
Flag: EXEMPT utils function
Change-Id: I6819844cd686fe29b8b1c760c3e4035787a2b903
2025-02-20 15:35:01 +08:00
Steven Moreland
911a99932c 16KB -> 16 KB
To be consistent with our docs and communication elsewhere.

Bugs: me
Change-Id: I0233412e452a27a14eb14336b0229114d022183c
Test: N/A
2025-02-19 15:11:18 -08:00
Pawan Wagh
24a65ba02b Connect and enable root before running each testcase
- Enable16KbTest is flaky for aosp targets. Make sure that device
is connected and with root each time before and after running the
test.
- Add OWNERS file Enable16KbTest

Test: atest -c Enable16KbTest
Bug: 396984821
Change-Id: Ifffb73496b0947dda13a4022733677bd645b7e16
2025-02-19 20:59:06 +00:00
Nikhil Nayunigari
81bb2588f5 Merge "Add ethernet interface details settings subpage" into main 2025-02-19 08:34:03 -08:00
Yiyi Shen
92721a8650 Merge "[Audiosharing] Handle add source from notif in receiver" into main 2025-02-19 07:38:47 -08:00
Yiyi Shen
2114b0252f Merge "[Audiosharing] Handle cancel notification in receiver" into main 2025-02-19 07:38:32 -08:00
Kanyinsola Fapohunda
c9569b1cbd Change namespace for time_help_and_feedback_feature_supported server flag
This change moves the time_help_and_feedback_feature_supported flag from the settings_ui namespace to the system_time namespace.

Flag: EXEMPT refactor
Bug: 283239837
Change-Id: Ic1fcafd3cdbd263d7b800ac7676701628361de63
2025-02-19 07:09:49 -08:00
Matías Hernández
a8b18f953d Merge "Hide ZenMode.getRule() - Settings" into main 2025-02-19 05:43:17 -08:00
Yiyi Shen
b7518c56e1 Merge "[Audiosharing] Revert ag/31626042 (exclude utils)" into main 2025-02-19 02:32:06 -08:00
Yiyi Shen
fca184598d [Audiosharing] Handle add source from notif in receiver
Test: atest
Bug: 395786392
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ia9a74a48224974c10524f1ae379cd9de2ff42430
2025-02-19 18:04:13 +08:00
Garvita Jain
c543fa8101 Merge "L10n fix for IW locale in storage_summary string" into main 2025-02-19 01:38:19 -08:00
Yiyi Shen
2c5f451b3a [Audiosharing] Revert ag/31626042 (exclude utils)
FP will handle set temp for manual pair in Settings

Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: I3afae523ef0d5a6c236a482127a714f422a6e000
2025-02-19 01:23:52 -08:00
Aleksander Morgado
4a2abf7705 Early check for SIM EID availability based on telephony or user admin
The SIM EID field was already not being shown if the
PackageManger.FEATURE_TELEPHONY_DATA feature flag was not set, per the
check in getIsAvailableAndUpdateEid().

The async availability update was introduced in the context of bug
304560734, because the UI could block until the EID value was ready.
The config_show_sim_info check was left in getAvailabilityStatus() as
that cannot block.

This change moves to getAvailabilityStatus() the availability check
based on the PackageManager feature flags (which are set on system
boot and not changed during runtime) and also based on whether the
user is admin or not, as with any other telephony related setting.
None of these two checks would lead to ANR state.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimEidPreferenceControllerTest

Change-Id: I3447091670345285132a2acaf45cd129c2b84c00
2025-02-19 00:50:05 -08:00
Yiyi Shen
0ccc9eefc4 [Audiosharing] Handle cancel notification in receiver
Test: atest
Bug: 395786392
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ib4b8ed3eff1df01819b37be2c1334abeae00ea2c
2025-02-19 15:01:03 +08:00
Treehugger Robot
9fb0e28bf7 Merge "Fix BiometricEnrollActivityTest Fail" into main 2025-02-18 23:00:01 -08:00
Treehugger Robot
22e2cd594e Merge "Fixed accessibility issues in Wi-Fi SSID view" into main 2025-02-18 22:38:53 -08:00
YK Hung
7ab462f1d7 Merge "[Expressive Battery] Migrate tips card in battery usage to banner message" into main 2025-02-18 21:25:50 -08:00
Weng Su
d44941bd00 Fixed accessibility issues in Wi-Fi SSID view
- Keep the Save button enabled at all times

- Show "Enter the SSID" to remind the user

Bug: 386897596
Flag: EXEMPT bugfix
Test: Manual testing
  atest SettingsUnitTests:AddNetworkFragmentTest
  atest WifiConfigController2Test
Change-Id: I6cc6b197864511ee2c1c92affc67698b1761f11d
2025-02-19 13:22:26 +08:00
Yiyi Shen
f5098877fc Merge "[Audiosharing] Show add source notif when app not in foreground" into main 2025-02-18 21:16:48 -08:00
Nikhil Nayunigari
487a4774d1 Add ethernet interface details settings subpage
Adds a click listener to the ethernet interface row and displays a
settings subpage with interface connection status.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Change-Id: Id64ce3657b47dd4ca70d425dd3d13227c8468d2c
2025-02-19 04:55:22 +00:00
Garvita Jain
4e5595050f L10n fix for IW locale in storage_summary string
storage_summary is passed as a single string of format "32 GB".
Spliting the phrase to allow TC to remove whitespace in case of iw
translations.

Old Translation : <free_space>
New Translation: <free_space_value> <free_space_unit>

Bug: 387197875
Test: manual
Flag: EXEMPT bugfix
Change-Id: I91abf58df472650a6278b08e4daa5d32e7f90da9
2025-02-19 04:19:16 +00:00
mxyyiyi
9ba79d8b02 [Expressive Battery] Migrate tips card in battery usage to banner message
- Update card preference: Update icon hint color by banner attention level
- Remove redundant color token: Use the existing Material yellow as a warning color

Bug: 349652542
Test: atest BatteryTipsControllerTest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I35730eb4716e9dbd712c22db63490e8bc06fc482
2025-02-19 10:33:13 +08:00
Yongshun Liu
67c5db13ff Merge "a11y: Clean up magnification mode controller and fix lint errors" into main 2025-02-18 17:28:49 -08:00
Nikhil Nayunigari
0afd3f64a5 Merge "Display one row item per Ethernet interface" into main 2025-02-18 15:39:43 -08:00
Yongshun Liu
b8ee801dfd a11y: Clean up magnification mode controller and fix lint errors
This cleans up the magnification mode controller and related code. It
also fixes most of the lint errors in the files.

NO_IFTTT=linter not working

Bug: b/388335935
Flag: EXEMPT refactor
Test: com.android.settings.accessibility.ToggleScreenMagnificationPreferenceFragmentTest & com.android.settings.accessibility.MagnificationModePreferenceControllerTest
Change-Id: I368128c3c71285a9511a7831e1d01232e7536d2f
2025-02-18 23:02:08 +00:00
Liana Kazanova (xWF)
a17dfe4ecc Merge changes from topic "revert-31790253-UHOKZZQOPA" into main
* changes:
  Revert "Make Satellite UI updatable during receiving callback (P..."
  Revert "Modify the default satellite category title."
2025-02-18 10:46:03 -08:00
Nikhil Nayunigari
25c5971e89 Display one row item per Ethernet interface
This change adds a preference category to host rows for ethernet
interfaces.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Bug: 369889610

Change-Id: Idb37cbf17f06db2c9a217659affb35d9dcebadf3
2025-02-18 09:41:49 -08:00
Liana Kazanova (xWF)
790fa6e00e Revert "Make Satellite UI updatable during receiving callback (P..."
Revert submission 31790253

Reason for revert: DroidMonitor: Potential culprit for http://b/397368653 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31790253

Change-Id: I851046019821fff0d132efb0b00cbff1e3ecbe72
2025-02-18 09:35:50 -08:00
Matías Hernández
13bb8e714d Hide ZenMode.getRule() - Settings
Bug: 393321037
Test: atest com.android.settings.notification.modes
Flag: EXEMPT Unflaggable refactoring
Change-Id: Ia9b43146f687ebee29eee0328a92e59c0c6d574a
2025-02-18 14:27:58 +01:00
Hakjun Choi
0be57cf311 Merge "Clean up aconfig flag carrier_enabled_satellite_flag" into main 2025-02-18 03:29:48 -08:00
Chelsea Hao
792389df2d Merge changes from topic "talkback_dialog" into main
* changes:
  Show turn off talkback dialog if needed in find an audio stream page.
  Show turn off talkback dialog if needed in `AudioStreamConfirmDialog`.
2025-02-18 03:01:49 -08:00
MiltonWu
38b0017e26 Fix BiometricEnrollActivityTest Fail
Bug: 397358182
Test: atest BiometricEnrollActivityTest
Flag: EXEMPT activity rename can not use flag
Change-Id: Icccf06cc3e27052077d81808d07f362998e8fcf7
2025-02-18 18:16:33 +08:00
Chelsea Hao
11dea241fa Merge "Skip "Stream paused" state change after a stream is set to "Wrong password" state." into main 2025-02-18 01:36:33 -08:00
utzcoz
799e0e877a test: Make mMockitoRule public for AppWithAdminGrantedPermissionsCounterTest
Rule should be public for junit.

Test: atest SettingsRoboTests:com.android.settings.applications.AppWithAdminGrantedPermissionsCounterTest

Merged-In: Id2ecf785655dfcca9f65fc3ee64ffae11fc78e88

Change-Id: I2f577f71011e1197703e115b704af0aa1ee1e5dd
Signed-off-by: utzcoz <utzcoz@gmail.com>
2025-02-18 00:51:24 -08:00
Hakjun Choi
1a53ea7a05 Clean up aconfig flag carrier_enabled_satellite_flag
Bug: 393951373
FLAG: EXEMPT flag clean up
Test: atest NetworkSelectSettingsTest WifiCallingSettingsForSubTest SatelliteSettingsPreferenceControllerTest
Test: manual test in live network
Change-Id: I154e9be8a8c771fafb37af078be7b495f18b6100
2025-02-18 08:41:14 +00:00
Aleksander Morgado
c9aaa03d7b Merge changes from topic "settings-visibility-return-fixes" into main
* changes:
  Return DISABLED_FOR_USER in deviceinfo/simstatus availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
  Added unit tests for SimStatusPreferenceController visibility
  Return DISABLED_FOR_USER in IMEI availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
  Added unit test for MobileNetworkImeiPreferenceController visibility
  Added unit tests for ImeiInfoPreferenceController visibility
  Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
2025-02-18 00:10:26 -08:00
Tom Hsu
faabe07453 Merge changes Ic1e09334,I55423317 into main
* changes:
  Modify the default satellite category title.
  Make Satellite UI updatable during receiving callback (Part II)
2025-02-17 23:49:38 -08:00
Treehugger Robot
caa4fa6715 Merge "Make Satellite UI updatable during receiving callback (part I)" into main 2025-02-17 23:39:07 -08:00
tom hsu
9df2e6fdc9 Make Satellite UI updatable during receiving callback (Part II)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: b/396233604
Fix: b/382664790
Test: atest pass
Change-Id: I55423317d82589312ce4a2f851b32b242529e922
2025-02-18 06:32:33 +00:00
tom hsu
048be18c5e Make Satellite UI updatable during receiving callback (part I)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: 396233604
Test: atest pass
Change-Id: If2e3d9b82950f05c4911ee7ce3bb41fb26e0d3e4
2025-02-18 06:19:47 +00:00
Jacky Wang
ed5b8b3327 [Catalyst] Use deeplink for high sensitivity
Fix: 396461663
Flag: com.android.settingslib.flags.settings_catalyst
Test: atest
Change-Id: I27629b8ac2a3d0b9f2fe834c78c2bcd11a38b4e0
2025-02-17 23:29:38 +08:00
Treehugger Robot
be9c39f0aa Merge "Fix test error of SatelliteSettingsPreferenceControllerTest" into main 2025-02-17 05:51:07 -08:00
tom hsu
543e446150 Fix test error of SatelliteSettingsPreferenceControllerTest
- Root cause is wrong Resouce string got.

Flag: EXEMPT bug fix
Fix: b/396571641
Test: atest passed
Change-Id: I25a4c7fff0ea20ab3c6e7fde99e1fba2b0288dfd
2025-02-17 11:28:47 +00:00
Aleksander Morgado
22c8840526 Return DISABLED_FOR_USER in deviceinfo/simstatus availability if not admin user
The correct return when checking for the SIM status field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest

Change-Id: I9bd290f1bdd73909be383a24f2c762d295089ff6
2025-02-17 00:44:30 -08:00
Aleksander Morgado
d58d0be2e1 Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest
Change-Id: I0735c949a590190cdc177cbca835444691c50faa
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4cc14d6553 Added unit tests for SimStatusPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest SimStatusPreferenceControllerTest
Change-Id: I8791d9fd4d7ab8648946f044d7aa6a0e77283a00
2025-02-17 00:44:30 -08:00
Aleksander Morgado
64fb695d9b Return DISABLED_FOR_USER in IMEI availability if not admin user
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
2a0ad1efdf Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/imei
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkImeiPreferenceControllerTest
Change-Id: Ia01cf3812f8343eabd8ea6970b691ac71432e8bd
2025-02-17 00:44:30 -08:00
Aleksander Morgado
dc86669298 Added unit test for MobileNetworkImeiPreferenceController visibility
The new test checks whether the item is available when the
SubscriptionUtil.isSimHardwareVisible() method returns true, i.e. if
the config_show_sim_info boolean flag is true on non-test runtime.

The default visibility status for all tests is defined in the test
setup() method.

Bug: 395714454
Flag: EXEMPT test only
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: Iaa8be041f0299ac36d532ed68fdc9c30e5690b11
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4f4580e5f5 Added unit tests for ImeiInfoPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest ImeiInfoPreferenceControllerTest
Change-Id: Ic4df12da216e5c343cf696d931ff02dc942d105f
2025-02-17 00:44:30 -08:00