PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix broken tests

Browse Source 
Remove group conditions - we don't have a group page
and so don't need to test what its header would be

Test: this
Fixes: 201021319
Change-Id: I22049bc7ea2153a574ed5aa5428a5dfb295447a5
This commit is contained in:
Julia Reynolds
2021-11-05 14:17:43 -04:00
parent 687dea100f
commit dc18e85e41
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/robotests/src/com/android/settings/notification/app/HeaderPreferenceControllerTest.java
View File

@@ -40,7 +40,6 @@ import com.android.settings.notification.NotificationBackend;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
@@ -132,7 +131,6 @@ public class HeaderPreferenceControllerTest {
} }
@Test @Test
@Ignore
public void testGetSummary() { public void testGetSummary() {
NotificationBackend.AppRow appRow = new NotificationBackend.AppRow(); NotificationBackend.AppRow appRow = new NotificationBackend.AppRow();
appRow.label = "bananas"; appRow.label = "bananas";
@@ -140,8 +138,6 @@ public class HeaderPreferenceControllerTest {
assertEquals("", mController.getSummary()); assertEquals("", mController.getSummary());
NotificationChannelGroup group = new NotificationChannelGroup("id", "name"); NotificationChannelGroup group = new NotificationChannelGroup("id", "name");
mController.onResume(appRow, null, group, null, null, null, null);
assertEquals(appRow.label, mController.getSummary());
NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE); NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE);
mController.onResume(appRow, channel, group, null, null, null, null); mController.onResume(appRow, channel, group, null, null, null, null);
@@ -159,7 +155,6 @@ public class HeaderPreferenceControllerTest {
} }
@Test @Test
@Ignore
public void testGetSecondSummary() { public void testGetSecondSummary() {
NotificationBackend.AppRow appRow = new NotificationBackend.AppRow(); NotificationBackend.AppRow appRow = new NotificationBackend.AppRow();
appRow.label = "bananas"; appRow.label = "bananas";
@@ -167,8 +162,6 @@ public class HeaderPreferenceControllerTest {
assertEquals("", mController.getSecondSummary()); assertEquals("", mController.getSecondSummary());
NotificationChannelGroup group = new NotificationChannelGroup("id", "name"); NotificationChannelGroup group = new NotificationChannelGroup("id", "name");
mController.onResume(appRow, null, group, null, null, null, null);
assertEquals("", mController.getSecondSummary());
NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE); NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE);
mController.onResume(appRow, channel, group, null, null, null, null); mController.onResume(appRow, channel, group, null, null, null, null);