From dc18e85e411063d0188da93d2a7e63da3ffa4b02 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Fri, 5 Nov 2021 14:17:43 -0400 Subject: [PATCH] Fix broken tests Remove group conditions - we don't have a group page and so don't need to test what its header would be Test: this Fixes: 201021319 Change-Id: I22049bc7ea2153a574ed5aa5428a5dfb295447a5 --- .../notification/app/HeaderPreferenceControllerTest.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/robotests/src/com/android/settings/notification/app/HeaderPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/notification/app/HeaderPreferenceControllerTest.java index a8628c42c47..c7c21a7f3d2 100644 --- a/tests/robotests/src/com/android/settings/notification/app/HeaderPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/notification/app/HeaderPreferenceControllerTest.java @@ -40,7 +40,6 @@ import com.android.settings.notification.NotificationBackend; import com.android.settingslib.widget.LayoutPreference; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -132,7 +131,6 @@ public class HeaderPreferenceControllerTest { } @Test - @Ignore public void testGetSummary() { NotificationBackend.AppRow appRow = new NotificationBackend.AppRow(); appRow.label = "bananas"; @@ -140,8 +138,6 @@ public class HeaderPreferenceControllerTest { assertEquals("", mController.getSummary()); NotificationChannelGroup group = new NotificationChannelGroup("id", "name"); - mController.onResume(appRow, null, group, null, null, null, null); - assertEquals(appRow.label, mController.getSummary()); NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE); mController.onResume(appRow, channel, group, null, null, null, null); @@ -159,7 +155,6 @@ public class HeaderPreferenceControllerTest { } @Test - @Ignore public void testGetSecondSummary() { NotificationBackend.AppRow appRow = new NotificationBackend.AppRow(); appRow.label = "bananas"; @@ -167,8 +162,6 @@ public class HeaderPreferenceControllerTest { assertEquals("", mController.getSecondSummary()); NotificationChannelGroup group = new NotificationChannelGroup("id", "name"); - mController.onResume(appRow, null, group, null, null, null, null); - assertEquals("", mController.getSecondSummary()); NotificationChannel channel = new NotificationChannel("cid", "cname", IMPORTANCE_NONE); mController.onResume(appRow, channel, group, null, null, null, null);