Merge "Provide the flexibility to add more tip detector" into main
This commit is contained in:
committed by
Android (Google) Code Review
commit
c57d1ef69a
@@ -18,6 +18,10 @@ package com.android.settings.fuelgauge;
|
||||
|
||||
import android.content.Context;
|
||||
|
||||
import com.android.settings.fuelgauge.batterytip.tips.BatteryTip;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
/** Feature provider for battery settings usage. */
|
||||
public interface BatterySettingsFeatureProvider {
|
||||
|
||||
@@ -29,4 +33,7 @@ public interface BatterySettingsFeatureProvider {
|
||||
|
||||
/** Check whether the battery information page is enabled in the About phone page */
|
||||
boolean isBatteryInfoEnabled(Context context);
|
||||
|
||||
/** A way to add more battery tip detectors. */
|
||||
void addBatteryTipDetector(Context context, List<BatteryTip> tips);
|
||||
}
|
||||
|
@@ -18,6 +18,10 @@ package com.android.settings.fuelgauge;
|
||||
|
||||
import android.content.Context;
|
||||
|
||||
import com.android.settings.fuelgauge.batterytip.tips.BatteryTip;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
/** Feature provider implementation for battery settings usage. */
|
||||
public class BatterySettingsFeatureProviderImpl implements BatterySettingsFeatureProvider {
|
||||
|
||||
@@ -35,4 +39,7 @@ public class BatterySettingsFeatureProviderImpl implements BatterySettingsFeatur
|
||||
public boolean isBatteryInfoEnabled(Context context) {
|
||||
return false;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void addBatteryTipDetector(Context context, List<BatteryTip> tips) {}
|
||||
}
|
||||
|
@@ -30,6 +30,7 @@ import com.android.settings.fuelgauge.batterytip.detectors.HighUsageDetector;
|
||||
import com.android.settings.fuelgauge.batterytip.detectors.IncompatibleChargerDetector;
|
||||
import com.android.settings.fuelgauge.batterytip.detectors.LowBatteryDetector;
|
||||
import com.android.settings.fuelgauge.batterytip.tips.BatteryTip;
|
||||
import com.android.settings.overlay.FeatureFactory;
|
||||
import com.android.settingslib.utils.AsyncLoaderCompat;
|
||||
|
||||
import java.util.ArrayList;
|
||||
@@ -44,6 +45,7 @@ public class BatteryTipLoader extends AsyncLoaderCompat<List<BatteryTip>> {
|
||||
private static final String TAG = "BatteryTipLoader";
|
||||
|
||||
private BatteryUsageStats mBatteryUsageStats;
|
||||
|
||||
@VisibleForTesting BatteryUtils mBatteryUtils;
|
||||
|
||||
public BatteryTipLoader(Context context, BatteryUsageStats batteryUsageStats) {
|
||||
@@ -66,6 +68,9 @@ public class BatteryTipLoader extends AsyncLoaderCompat<List<BatteryTip>> {
|
||||
tips.add(new BatteryDefenderDetector(batteryInfo, context).detect());
|
||||
tips.add(new DockDefenderDetector(batteryInfo, context).detect());
|
||||
tips.add(new IncompatibleChargerDetector(context).detect());
|
||||
FeatureFactory.getFeatureFactory()
|
||||
.getBatterySettingsFeatureProvider()
|
||||
.addBatteryTipDetector(context, tips);
|
||||
Collections.sort(tips);
|
||||
return tips;
|
||||
}
|
||||
|
Reference in New Issue
Block a user