Merge "[Network Connection] Don't dismiss dialog when touching outside of dialog"

This commit is contained in:
Cosmo Hsieh
2019-03-22 01:45:53 +00:00
committed by Android (Google) Code Review

View File

@@ -138,6 +138,10 @@ public class NetworkRequestDialogFragment extends InstrumentedDialogFragment imp
.setOnItemClickListener( .setOnItemClickListener(
(parent, view, position, id) -> this.onClick(dialog, position)); (parent, view, position, id) -> this.onClick(dialog, position));
// Don't dismiss dialog when touching outside. User report it is easy to touch outside.
// This causes dialog to close. Which is concerned as a bad UX (b/128877712).
dialog.setCanceledOnTouchOutside(false);
dialog.setOnShowListener((dialogInterface) -> { dialog.setOnShowListener((dialogInterface) -> {
// Replace NeutralButton onClickListener to avoid closing dialog // Replace NeutralButton onClickListener to avoid closing dialog
final Button neutralBtn = dialog.getButton(AlertDialog.BUTTON_NEUTRAL); final Button neutralBtn = dialog.getButton(AlertDialog.BUTTON_NEUTRAL);