From 3babe9e908acd30181c28ebc1a323895100a9287 Mon Sep 17 00:00:00 2001 From: cosmohsieh Date: Wed, 20 Mar 2019 14:48:32 +0800 Subject: [PATCH] [Network Connection] Don't dismiss dialog when touching outside of dialog To Improve user experience, prevent dialog dismissing from touching outside of the dialog Bug: 128877712 Test: atest NetworkRequestDialogFragment Change-Id: Idfa90c3647f5cf766aaa63fdb8a829fec5db5934 --- .../android/settings/wifi/NetworkRequestDialogFragment.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java index 09360e427d8..bfd8d1cc6ba 100644 --- a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java +++ b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java @@ -138,6 +138,10 @@ public class NetworkRequestDialogFragment extends InstrumentedDialogFragment imp .setOnItemClickListener( (parent, view, position, id) -> this.onClick(dialog, position)); + // Don't dismiss dialog when touching outside. User report it is easy to touch outside. + // This causes dialog to close. Which is concerned as a bad UX (b/128877712). + dialog.setCanceledOnTouchOutside(false); + dialog.setOnShowListener((dialogInterface) -> { // Replace NeutralButton onClickListener to avoid closing dialog final Button neutralBtn = dialog.getButton(AlertDialog.BUTTON_NEUTRAL);