Fast enroll

Test: manual
Bug: 375320734
Flag: com.google.android.settings.flags.pixel_fingerprint_enroll
Change-Id: Iaf3acfca8471165514660a2403e69be161392501
This commit is contained in:
Joshua McCloskey
2024-11-26 17:01:51 +00:00
parent 93e24594c5
commit a2085f18b7
7 changed files with 33 additions and 7 deletions

View File

@@ -2792,6 +2792,10 @@
android:exported="false"
android:theme="@style/GlifTheme.Light"
android:taskAffinity="com.android.settings.root" />
<activity android:name=".biometrics.fingerprint.FingerprintEnroll$AddAdditionalFingerprint"
android:exported="false"
android:theme="@style/GlifTheme.Light"
android:taskAffinity="com.android.settings.root" />
<activity android:name=".biometrics.fingerprint.SetupFingerprintEnrollFindSensor"
android:exported="false"

View File

@@ -257,9 +257,10 @@ public class ActivityEmbeddingRulesController {
final FingerprintEnrollActivityClassProvider fpClassProvider = FeatureFactory
.getFeatureFactory()
.getFingerprintFeatureProvider()
.getEnrollActivityClassProvider();
.getEnrollActivityClassProvider(mContext);
addActivityFilter(activityFilters, fpClassProvider.getDefault());
addActivityFilter(activityFilters, fpClassProvider.getInternal());
addActivityFilter(activityFilters, fpClassProvider.getAddAnother());
addActivityFilter(activityFilters, FingerprintEnrollEnrolling.class);
addActivityFilter(activityFilters, FaceEnrollIntroductionInternal.class);
addActivityFilter(activityFilters, FaceEnrollIntroduction.class);

View File

@@ -40,6 +40,14 @@ open class FingerprintEnroll: AppCompatActivity() {
get() = enrollActivityProvider.internal
}
/**
* Inner class to request adding of an additional fingerprint
*/
class AddAdditionalFingerprint : FingerprintEnroll() {
override val nextActivityClass: Class<*>
get() = enrollActivityProvider.addAnother
}
/**
* The class of the next activity to launch. This is open to allow subclasses to provide their
* own behavior. Defaults to the default activity class provided by the
@@ -49,7 +57,7 @@ open class FingerprintEnroll: AppCompatActivity() {
get() = enrollActivityProvider.default
protected val enrollActivityProvider: FingerprintEnrollActivityClassProvider
get() = featureFactory.fingerprintFeatureProvider.enrollActivityClassProvider
get() = featureFactory.fingerprintFeatureProvider.getEnrollActivityClassProvider(this)
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)

View File

@@ -26,6 +26,8 @@ open class FingerprintEnrollActivityClassProvider {
get() = SetupFingerprintEnrollIntroduction::class.java
open val internal: Class<out Activity>
get() = FingerprintEnrollIntroductionInternal::class.java
open val addAnother: Class<out Activity>
get() = FingerprintEnrollEnrolling::class.java
companion object {
@JvmStatic

View File

@@ -57,7 +57,7 @@ public interface FingerprintFeatureProvider {
* @return the provider
*/
@NonNull
default FingerprintEnrollActivityClassProvider getEnrollActivityClassProvider() {
default FingerprintEnrollActivityClassProvider getEnrollActivityClassProvider(@NonNull Context context) {
return FingerprintEnrollActivityClassProvider.getInstance();
}
}

View File

@@ -537,8 +537,9 @@ public class FingerprintSettings extends SubSettings {
activity, DevicePolicyManager.KEYGUARD_DISABLE_FINGERPRINT, mUserId);
final Intent helpIntent = HelpUtils.getHelpIntent(
activity, getString(getHelpResource()), activity.getClass().getName());
final View.OnClickListener learnMoreClickListener = (v) ->
activity.startActivityForResult(helpIntent, 0);
final View.OnClickListener learnMoreClickListener = (v) -> {
activity.startActivityForResult(helpIntent, 0);
};
mFooterColumns.clear();
if (admin != null) {
@@ -910,7 +911,7 @@ public class FingerprintSettings extends SubSettings {
mIsEnrolling = true;
Intent intent = new Intent();
intent.setClassName(SETTINGS_PACKAGE_NAME,
FingerprintEnrollEnrolling.class.getName());
FingerprintEnroll.AddAdditionalFingerprint.class.getName());
intent.putExtra(Intent.EXTRA_USER_ID, mUserId);
intent.putExtra(ChooseLockSettingsHelper.EXTRA_KEY_CHALLENGE_TOKEN, mToken);
if (mCalibrator != null) {

View File

@@ -24,6 +24,7 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mockito.`when`
import org.mockito.kotlin.any
import org.robolectric.Robolectric
import org.robolectric.RobolectricTestRunner
import org.robolectric.Shadows
@@ -46,7 +47,7 @@ class FingerprintEnrollTest {
@Before
fun setUp() {
featureFactory = FakeFeatureFactory.setupForTest()
`when`(featureFactory.fingerprintFeatureProvider.enrollActivityClassProvider)
`when`(featureFactory.fingerprintFeatureProvider.getEnrollActivityClassProvider(any()))
.thenReturn(activityProvider)
}
@@ -81,6 +82,15 @@ class FingerprintEnrollTest {
verifyLaunchNextActivity(activity, activityProvider.internal)
}
@Test
fun testAndFinishLaunchAddAdditional() {
// Run
val activity = setupActivity(FingerprintEnroll.AddAdditionalFingerprint::class.java)
// Verify
verifyLaunchNextActivity(activity, activityProvider.addAnother)
}
private fun verifyLaunchNextActivity(
currentActivityInstance : FingerprintEnroll,
nextActivityClass: Class<out Activity>