Merge "Add emergency broadcast to app & notification settings." into oc-dev

This commit is contained in:
TreeHugger Robot
2017-04-29 06:53:11 +00:00
committed by Android (Google) Code Review
3 changed files with 25 additions and 5 deletions

View File

@@ -25,17 +25,28 @@
android:title="@string/app_permissions" android:title="@string/app_permissions"
android:order="-130" android:order="-130"
settings:keywords="@string/keywords_app_permissions"> settings:keywords="@string/keywords_app_permissions">
<intent android:action="android.intent.action.MANAGE_PERMISSIONS"/> <intent android:action="android.intent.action.MANAGE_PERMISSIONS" />
</Preference> </Preference>
<PreferenceCategory <PreferenceCategory
android:key="dashboard_tile_placeholder" android:key="dashboard_tile_placeholder"
android:order="10"/> android:order="10" />
<com.android.settingslib.RestrictedPreference
android:key="app_and_notif_cell_broadcast_settings"
android:title="@string/cell_broadcast_settings"
android:order="15"
settings:useAdminDisabledSummary="true">
<intent
android:action="android.intent.action.MAIN"
android:targetPackage="com.android.cellbroadcastreceiver"
android:targetClass="com.android.cellbroadcastreceiver.CellBroadcastSettings" />
</com.android.settingslib.RestrictedPreference>
<Preference <Preference
android:key="special_access" android:key="special_access"
android:fragment="com.android.settings.applications.SpecialAccessSettings" android:fragment="com.android.settings.applications.SpecialAccessSettings"
android:title="@string/special_access" android:title="@string/special_access"
android:order="20"/> android:order="20" />
</PreferenceScreen> </PreferenceScreen>

View File

@@ -120,7 +120,7 @@ public class ProgressiveDisclosureMixin implements Preference.OnPreferenceClickL
* Whether the screen should be collapsed. * Whether the screen should be collapsed.
*/ */
public boolean shouldCollapse(PreferenceScreen screen) { public boolean shouldCollapse(PreferenceScreen screen) {
return !mUserExpanded && screen.getPreferenceCount() >= mTileLimit; return !mUserExpanded && screen.getPreferenceCount() > mTileLimit;
} }
/** /**
@@ -218,7 +218,7 @@ public class ProgressiveDisclosureMixin implements Preference.OnPreferenceClickL
return pref; return pref;
} }
if (pref instanceof PreferenceGroup) { if (pref instanceof PreferenceGroup) {
final Preference returnedPreference = ((PreferenceGroup)pref).findPreference(key); final Preference returnedPreference = ((PreferenceGroup) pref).findPreference(key);
if (returnedPreference != null) { if (returnedPreference != null) {
return returnedPreference; return returnedPreference;
} }

View File

@@ -92,6 +92,15 @@ public class ProgressiveDisclosureTest {
assertThat(mMixin.shouldCollapse(mScreen)).isFalse(); assertThat(mMixin.shouldCollapse(mScreen)).isFalse();
} }
@Test
public void shouldNotCollapse_preferenceCountSameAsThreshold() {
when(mScreen.getPreferenceCount()).thenReturn(5);
mMixin.setTileLimit(5);
assertThat(mMixin.shouldCollapse(mScreen)).isFalse();
}
@Test @Test
public void shouldNotCollapse_whenStartAsExpanded() { public void shouldNotCollapse_whenStartAsExpanded() {
when(mScreen.getPreferenceCount()).thenReturn(5); when(mScreen.getPreferenceCount()).thenReturn(5);