diff --git a/res/xml/app_and_notification.xml b/res/xml/app_and_notification.xml index 627d3f80ee1..639735dcb59 100644 --- a/res/xml/app_and_notification.xml +++ b/res/xml/app_and_notification.xml @@ -25,17 +25,28 @@ android:title="@string/app_permissions" android:order="-130" settings:keywords="@string/keywords_app_permissions"> - + + android:order="10" /> + + + + + android:order="20" /> \ No newline at end of file diff --git a/src/com/android/settings/dashboard/ProgressiveDisclosureMixin.java b/src/com/android/settings/dashboard/ProgressiveDisclosureMixin.java index 07a729377ac..b86fabfabba 100644 --- a/src/com/android/settings/dashboard/ProgressiveDisclosureMixin.java +++ b/src/com/android/settings/dashboard/ProgressiveDisclosureMixin.java @@ -120,7 +120,7 @@ public class ProgressiveDisclosureMixin implements Preference.OnPreferenceClickL * Whether the screen should be collapsed. */ public boolean shouldCollapse(PreferenceScreen screen) { - return !mUserExpanded && screen.getPreferenceCount() >= mTileLimit; + return !mUserExpanded && screen.getPreferenceCount() > mTileLimit; } /** @@ -218,7 +218,7 @@ public class ProgressiveDisclosureMixin implements Preference.OnPreferenceClickL return pref; } if (pref instanceof PreferenceGroup) { - final Preference returnedPreference = ((PreferenceGroup)pref).findPreference(key); + final Preference returnedPreference = ((PreferenceGroup) pref).findPreference(key); if (returnedPreference != null) { return returnedPreference; } diff --git a/tests/robotests/src/com/android/settings/dashboard/ProgressiveDisclosureTest.java b/tests/robotests/src/com/android/settings/dashboard/ProgressiveDisclosureTest.java index bae6f8f4a8a..d53e11be67c 100644 --- a/tests/robotests/src/com/android/settings/dashboard/ProgressiveDisclosureTest.java +++ b/tests/robotests/src/com/android/settings/dashboard/ProgressiveDisclosureTest.java @@ -92,6 +92,15 @@ public class ProgressiveDisclosureTest { assertThat(mMixin.shouldCollapse(mScreen)).isFalse(); } + @Test + public void shouldNotCollapse_preferenceCountSameAsThreshold() { + when(mScreen.getPreferenceCount()).thenReturn(5); + + mMixin.setTileLimit(5); + + assertThat(mMixin.shouldCollapse(mScreen)).isFalse(); + } + @Test public void shouldNotCollapse_whenStartAsExpanded() { when(mScreen.getPreferenceCount()).thenReturn(5);