Merge "Merge "ConditionManager: don't crash when trying to add unexpected condition" am: 46f7199cb1 am: 6270dce2cd am: 7151be926d am: ecc7355bde"

This commit is contained in:
Android Build Merger (Role)
2017-06-04 00:10:35 +00:00
committed by Android (Google) Code Review

View File

@@ -96,8 +96,12 @@ public class ConditionManager implements LifecycleObserver, OnResume, OnPause {
Condition condition = createCondition(Class.forName(clz));
PersistableBundle bundle = PersistableBundle.restoreFromXml(parser);
if (DEBUG) Log.d(TAG, "Reading " + clz + " -- " + bundle);
condition.restoreState(bundle);
conditions.add(condition);
if (condition != null) {
condition.restoreState(bundle);
conditions.add(condition);
} else {
Log.e(TAG, "failed to add condition: " + clz);
}
while (parser.getDepth() > depth) {
parser.next();
}
@@ -155,7 +159,10 @@ public class ConditionManager implements LifecycleObserver, OnResume, OnPause {
private void addIfMissing(Class<? extends Condition> clz, ArrayList<Condition> conditions) {
if (getCondition(clz, conditions) == null) {
if (DEBUG) Log.d(TAG, "Adding missing " + clz.getName());
conditions.add(createCondition(clz));
Condition condition = createCondition(clz);
if (condition != null) {
conditions.add(condition);
}
}
}
@@ -177,7 +184,8 @@ public class ConditionManager implements LifecycleObserver, OnResume, OnPause {
} else if (NightDisplayCondition.class == clz) {
return new NightDisplayCondition(this);
}
throw new RuntimeException("Unexpected Condition " + clz);
Log.e(TAG, "unknown condition class: " + clz.getSimpleName());
return null;
}
Context getContext() {