Merge "Re-enable all SetupFingerprintEnrollFinishTest test cases" into main

This commit is contained in:
Treehugger Robot
2024-10-29 18:12:55 +00:00
committed by Android (Google) Code Review
2 changed files with 5 additions and 16 deletions

View File

@@ -35,7 +35,6 @@ import com.google.android.setupcompat.PartnerCustomizationLayout;
import com.google.android.setupcompat.template.FooterBarMixin; import com.google.android.setupcompat.template.FooterBarMixin;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.robolectric.Robolectric; import org.robolectric.Robolectric;
@@ -116,7 +115,6 @@ public class SetupFingerprintEnrollFinishTest {
} }
@Test @Test
@Ignore("b/295325503")
public void onActivityResult_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() { public void onActivityResult_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() {
Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1);
@@ -137,8 +135,7 @@ public class SetupFingerprintEnrollFinishTest {
} }
@Test @Test
@Ignore("b/295325503") public void clickNext_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() {
public void clickNext_fingerprintCountIsOne_fngerprintSuggestionActivityEnabled() {
Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1);
mLayout.getMixin(FooterBarMixin.class).getPrimaryButtonView().performClick(); mLayout.getMixin(FooterBarMixin.class).getPrimaryButtonView().performClick();
@@ -158,8 +155,7 @@ public class SetupFingerprintEnrollFinishTest {
} }
@Test @Test
@Ignore("b/295325503") public void onBackPressed_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() {
public void onBackPressed_fingerprintCountIsOne_fngerprintSuggestionActivityEnabled() {
Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1);
mActivity.onBackPressed(); mActivity.onBackPressed();

View File

@@ -154,7 +154,7 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore @Ignore("b/295325503 expected: RESULT_SKIP, but was 2")
public void testKeyguardNotSecure_shouldFinishWithSetupSkipDialogResultSkip() { public void testKeyguardNotSecure_shouldFinishWithSetupSkipDialogResultSkip() {
getShadowKeyguardManager().setIsKeyguardSecure(false); getShadowKeyguardManager().setIsKeyguardSecure(false);
@@ -174,7 +174,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testKeyguardSecure_shouldFinishWithFingerprintResultSkip() { public void testKeyguardSecure_shouldFinishWithFingerprintResultSkip() {
getShadowKeyguardManager().setIsKeyguardSecure(true); getShadowKeyguardManager().setIsKeyguardSecure(true);
@@ -194,7 +193,7 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore @Ignore("b/295325503 expected not to be: null")
public void testBackKeyPress_shouldSetIntentDataIfLockScreenAdded() { public void testBackKeyPress_shouldSetIntentDataIfLockScreenAdded() {
getShadowKeyguardManager().setIsKeyguardSecure(false); getShadowKeyguardManager().setIsKeyguardSecure(false);
@@ -208,7 +207,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testBackKeyPress_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { public void testBackKeyPress_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() {
getShadowKeyguardManager().setIsKeyguardSecure(true); getShadowKeyguardManager().setIsKeyguardSecure(true);
@@ -221,7 +219,7 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore @Ignore("b/295325503 expected not to be: null")
public void testCancelClicked_shouldSetIntentDataIfLockScreenAdded() { public void testCancelClicked_shouldSetIntentDataIfLockScreenAdded() {
getShadowKeyguardManager().setIsKeyguardSecure(false); getShadowKeyguardManager().setIsKeyguardSecure(false);
@@ -237,7 +235,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testCancelClicked_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { public void testCancelClicked_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() {
getShadowKeyguardManager().setIsKeyguardSecure(true); getShadowKeyguardManager().setIsKeyguardSecure(true);
@@ -251,7 +248,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() {
getShadowKeyguardManager().setIsKeyguardSecure(true); getShadowKeyguardManager().setIsKeyguardSecure(true);
SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get();
@@ -262,7 +258,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testOnResultFromFindSensor_shouldSetIntentDataIfLockScreenAdded() { public void testOnResultFromFindSensor_shouldSetIntentDataIfLockScreenAdded() {
getShadowKeyguardManager().setIsKeyguardSecure(false); getShadowKeyguardManager().setIsKeyguardSecure(false);
SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get();
@@ -273,7 +268,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenNotAdded() { public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenNotAdded() {
getShadowKeyguardManager().setIsKeyguardSecure(false); getShadowKeyguardManager().setIsKeyguardSecure(false);
SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get();
@@ -284,7 +278,6 @@ public class SetupFingerprintEnrollIntroductionTest {
} }
@Test @Test
@Ignore
public void testLockPattern() { public void testLockPattern() {
ShadowStorageManager.setIsFileEncrypted(false); ShadowStorageManager.setIsFileEncrypted(false);