From e25afc6a00773a295a6664eb12c0883bfd420871 Mon Sep 17 00:00:00 2001 From: lbill Date: Tue, 29 Oct 2024 13:29:21 +0000 Subject: [PATCH] Re-enable all SetupFingerprintEnrollFinishTest test cases Remove @Ignore annotation Flag: EXEMPT for re-enabling robotest Bug: 295325503 Test: atest SetupFingerprintEnrollFinishTest atest SetupFingerprintEnrollIntroductionTest Change-Id: Iab662c0466cd9d3d0f9d44ec92e0ea660d2ff909 --- .../SetupFingerprintEnrollFinishTest.java | 8 ++------ .../SetupFingerprintEnrollIntroductionTest.java | 13 +++---------- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollFinishTest.java b/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollFinishTest.java index fa33f9c90ec..fd6c0822ade 100644 --- a/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollFinishTest.java +++ b/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollFinishTest.java @@ -35,7 +35,6 @@ import com.google.android.setupcompat.PartnerCustomizationLayout; import com.google.android.setupcompat.template.FooterBarMixin; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.Robolectric; @@ -116,7 +115,6 @@ public class SetupFingerprintEnrollFinishTest { } @Test - @Ignore("b/295325503") public void onActivityResult_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() { Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); @@ -137,8 +135,7 @@ public class SetupFingerprintEnrollFinishTest { } @Test - @Ignore("b/295325503") - public void clickNext_fingerprintCountIsOne_fngerprintSuggestionActivityEnabled() { + public void clickNext_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() { Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); mLayout.getMixin(FooterBarMixin.class).getPrimaryButtonView().performClick(); @@ -158,8 +155,7 @@ public class SetupFingerprintEnrollFinishTest { } @Test - @Ignore("b/295325503") - public void onBackPressed_fingerprintCountIsOne_fngerprintSuggestionActivityEnabled() { + public void onBackPressed_fingerprintCountIsOne_fingerprintSuggestionActivityEnabled() { Shadows.shadowOf((FingerprintManager) mFingerprintManager).setDefaultFingerprints(1); mActivity.onBackPressed(); diff --git a/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollIntroductionTest.java b/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollIntroductionTest.java index 6b6773463fb..1760fad1b5b 100644 --- a/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollIntroductionTest.java +++ b/tests/robotests/src/com/android/settings/biometrics/fingerprint/SetupFingerprintEnrollIntroductionTest.java @@ -154,7 +154,7 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore + @Ignore("b/295325503 expected: RESULT_SKIP, but was 2") public void testKeyguardNotSecure_shouldFinishWithSetupSkipDialogResultSkip() { getShadowKeyguardManager().setIsKeyguardSecure(false); @@ -174,7 +174,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testKeyguardSecure_shouldFinishWithFingerprintResultSkip() { getShadowKeyguardManager().setIsKeyguardSecure(true); @@ -194,7 +193,7 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore + @Ignore("b/295325503 expected not to be: null") public void testBackKeyPress_shouldSetIntentDataIfLockScreenAdded() { getShadowKeyguardManager().setIsKeyguardSecure(false); @@ -208,7 +207,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testBackKeyPress_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { getShadowKeyguardManager().setIsKeyguardSecure(true); @@ -221,7 +219,7 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore + @Ignore("b/295325503 expected not to be: null") public void testCancelClicked_shouldSetIntentDataIfLockScreenAdded() { getShadowKeyguardManager().setIsKeyguardSecure(false); @@ -237,7 +235,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testCancelClicked_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { getShadowKeyguardManager().setIsKeyguardSecure(true); @@ -251,7 +248,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenPresentBeforeLaunch() { getShadowKeyguardManager().setIsKeyguardSecure(true); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); @@ -262,7 +258,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testOnResultFromFindSensor_shouldSetIntentDataIfLockScreenAdded() { getShadowKeyguardManager().setIsKeyguardSecure(false); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); @@ -273,7 +268,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testOnResultFromFindSensor_shouldNotSetIntentDataIfLockScreenNotAdded() { getShadowKeyguardManager().setIsKeyguardSecure(false); SetupFingerprintEnrollIntroduction activity = mController.create().resume().get(); @@ -284,7 +278,6 @@ public class SetupFingerprintEnrollIntroductionTest { } @Test - @Ignore public void testLockPattern() { ShadowStorageManager.setIsFileEncrypted(false);