PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AF/FR Fix onActivityResult condition.

Browse Source 
Chase list bug. Accidentally bailed on true effectively.

Manual tested by going to Settings > System > Erase All Data
And then hitting then successfully wiping and reseting.

Test: make RunSettingsRoboTests -j40
Bug: 72324059
Change-Id: Ib2a155820811f0ec62a45c1312475c24646ede76
This commit is contained in:
Carlos Valdivia
2018-01-23 09:12:59 -08:00
parent 475fa50461
commit 5dd6ed470e
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/com/android/settings/MasterClear.java
View File

@@ -75,7 +75,7 @@ import java.util.List;
public class MasterClear extends InstrumentedPreferenceFragment { public class MasterClear extends InstrumentedPreferenceFragment {
private static final String TAG = "MasterClear"; private static final String TAG = "MasterClear";
private static final int KEYGUARD_REQUEST = 55; @VisibleForTesting static final int KEYGUARD_REQUEST = 55;
@VisibleForTesting static final int CREDENTIAL_CONFIRM_REQUEST = 56; @VisibleForTesting static final int CREDENTIAL_CONFIRM_REQUEST = 56;
private static final String KEY_SHOW_ESIM_RESET_CHECKBOX private static final String KEY_SHOW_ESIM_RESET_CHECKBOX
@@ -118,11 +118,16 @@ public class MasterClear extends InstrumentedPreferenceFragment {
request, res.getText(R.string.master_clear_title)); request, res.getText(R.string.master_clear_title));
} }
@VisibleForTesting
boolean isValidRequestCode(int requestCode) {
return !((requestCode != KEYGUARD_REQUEST) && (requestCode != CREDENTIAL_CONFIRM_REQUEST));
}
@Override @Override
public void onActivityResult(int requestCode, int resultCode, Intent data) { public void onActivityResult(int requestCode, int resultCode, Intent data) {
super.onActivityResult(requestCode, resultCode, data); super.onActivityResult(requestCode, resultCode, data);
if (requestCode != KEYGUARD_REQUEST || requestCode != CREDENTIAL_CONFIRM_REQUEST) { if (!isValidRequestCode(requestCode)) {
return; return;
} }

7
tests/robotests/src/com/android/settings/MasterClearTest.java
View File

@@ -270,6 +270,13 @@ public class MasterClearTest {
assertThat(mMasterClear.tryShowAccountConfirmation()).isTrue(); assertThat(mMasterClear.tryShowAccountConfirmation()).isTrue();
} }
@Test
public void testIsValidRequestCode() {
assertThat(mMasterClear.isValidRequestCode(MasterClear.KEYGUARD_REQUEST)).isTrue();
assertThat(mMasterClear.isValidRequestCode(MasterClear.CREDENTIAL_CONFIRM_REQUEST)).isTrue();
assertThat(mMasterClear.isValidRequestCode(0)).isFalse();
}
private void initScrollView(int height, int scrollY, int childBottom) { private void initScrollView(int height, int scrollY, int childBottom) {
when(mScrollView.getHeight()).thenReturn(height); when(mScrollView.getHeight()).thenReturn(height);
when(mScrollView.getScrollY()).thenReturn(scrollY); when(mScrollView.getScrollY()).thenReturn(scrollY);