diff --git a/src/com/android/settings/MasterClear.java b/src/com/android/settings/MasterClear.java index 0e337f68bf0..b7fb69404cd 100644 --- a/src/com/android/settings/MasterClear.java +++ b/src/com/android/settings/MasterClear.java @@ -75,7 +75,7 @@ import java.util.List; public class MasterClear extends InstrumentedPreferenceFragment { private static final String TAG = "MasterClear"; - private static final int KEYGUARD_REQUEST = 55; + @VisibleForTesting static final int KEYGUARD_REQUEST = 55; @VisibleForTesting static final int CREDENTIAL_CONFIRM_REQUEST = 56; private static final String KEY_SHOW_ESIM_RESET_CHECKBOX @@ -118,11 +118,16 @@ public class MasterClear extends InstrumentedPreferenceFragment { request, res.getText(R.string.master_clear_title)); } + @VisibleForTesting + boolean isValidRequestCode(int requestCode) { + return !((requestCode != KEYGUARD_REQUEST) && (requestCode != CREDENTIAL_CONFIRM_REQUEST)); + } + @Override public void onActivityResult(int requestCode, int resultCode, Intent data) { super.onActivityResult(requestCode, resultCode, data); - if (requestCode != KEYGUARD_REQUEST || requestCode != CREDENTIAL_CONFIRM_REQUEST) { + if (!isValidRequestCode(requestCode)) { return; } diff --git a/tests/robotests/src/com/android/settings/MasterClearTest.java b/tests/robotests/src/com/android/settings/MasterClearTest.java index ac753c109f2..9bf3310c6b8 100644 --- a/tests/robotests/src/com/android/settings/MasterClearTest.java +++ b/tests/robotests/src/com/android/settings/MasterClearTest.java @@ -270,6 +270,13 @@ public class MasterClearTest { assertThat(mMasterClear.tryShowAccountConfirmation()).isTrue(); } + @Test + public void testIsValidRequestCode() { + assertThat(mMasterClear.isValidRequestCode(MasterClear.KEYGUARD_REQUEST)).isTrue(); + assertThat(mMasterClear.isValidRequestCode(MasterClear.CREDENTIAL_CONFIRM_REQUEST)).isTrue(); + assertThat(mMasterClear.isValidRequestCode(0)).isFalse(); + } + private void initScrollView(int height, int scrollY, int childBottom) { when(mScrollView.getHeight()).thenReturn(height); when(mScrollView.getScrollY()).thenReturn(scrollY);