Disable ANGLE as system GLES dev option

This change prevents the feature from being inadvertently exposed to the
wider user base while it undergoes further refinement and stabilization
for a smoother user experience.

Test: atest SettingsUnitTests:com.android.settings.development.graphicsdriver.GraphicsDriverEnableAngleAsSystemDriverControllerJUnitTest
Test: locally build Husky and confirm the dev option is disabled, even
with the "debug.graphics.angle.developeroption.enable" prop set.
Flag: EXEMPT bugfix
Bug: b/384047927

Change-Id: I160840a25d38bf305871d7e146745df0d56f0227
This commit is contained in:
Solti
2024-12-19 17:30:11 +00:00
parent b8c4231fed
commit 5a3cfb9f0c
2 changed files with 12 additions and 2 deletions

View File

@@ -92,7 +92,17 @@ public class GraphicsDriverEnableAngleAsSystemDriverController
// This can be enabled by calling:
// `adb shell setprop debug.graphics.angle.developeroption.enable true`
private boolean isAngleDeveloperOptionEnabled() {
return mSystemProperties.getBoolean(PROPERTY_DEBUG_ANGLE_DEVELOPER_OPTION, false);
boolean intendedUsingAngleDeveloperOption =
mSystemProperties.getBoolean(PROPERTY_DEBUG_ANGLE_DEVELOPER_OPTION, false);
if (intendedUsingAngleDeveloperOption) {
Log.v(TAG,
"ANGLE developer option is enabled in system properties, "
+ "but temporarily overridden.");
}
// Temporarily disabling for broader rollout.
// The feature requires further maturation before general availability.
return false;
}
@VisibleForTesting

View File

@@ -182,7 +182,7 @@ public class GraphicsDriverEnableAngleAsSystemDriverControllerJUnitTest {
@Test
public void updateState_PreferenceShouldEnabled() {
mController.updateState(mPreference);
assertThat(mPreference.isEnabled()).isTrue();
assertThat(mPreference.isEnabled()).isFalse();
}
@Test