PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Updates A11y Shortcut animations to not loop in code.

Browse Source 
Continuously repeated animations go against accessibility guidelines
to avoid unstoppable motion.

The animation files themselves have been updated to loop twice
so that the user can still see the animation temporarily.
The loop restarts if the user exits and enters the page again.

Bug: 370661517
Flag: EXEMPT minor bugfix with resource changes
Test: Manually observe animations
Change-Id: I52348a094680ef345bf8c2b12ab91c9406bf5cb4
This commit is contained in:
Daniel Norman
2024-12-04 00:14:09 +00:00
parent 38ec311d40
commit 5862b31f21
5 changed files with 1665 additions and 5612 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2815
res/raw/accessibility_shortcut_type_2finger_doubletap.json
View File

File diff suppressed because it is too large Load Diff

1510
res/raw/accessibility_shortcut_type_fab.json
View File

File diff suppressed because it is too large Load Diff

2944
res/raw/accessibility_shortcut_type_tripletap.json
View File

File diff suppressed because it is too large Load Diff

4
src/com/android/settings/accessibility/AccessibilityShortcutsTutorial.java
View File

@@ -72,7 +72,6 @@ import com.android.settingslib.utils.StringUtil;
import com.android.settingslib.widget.LottieColorUtils;
import com.airbnb.lottie.LottieAnimationView;
import com.airbnb.lottie.LottieDrawable;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -335,7 +334,8 @@ public final class AccessibilityShortcutsTutorial {
result -> Log.w(TAG, "Invalid image raw resource id: " + imageRawRes,
result));
lottieView.setAnimation(imageRawRes);
lottieView.setRepeatCount(LottieDrawable.INFINITE);
// Follow the Motion Stoppable requirement by using a finite animation.
lottieView.setRepeatCount(0);
LottieColorUtils.applyDynamicColors(context, lottieView);
lottieView.playAnimation();

4
src/com/android/settings/accessibility/shortcuts/ShortcutOptionPreference.java
View File

@@ -35,7 +35,6 @@ import com.android.settings.R;
import com.android.settingslib.widget.LottieColorUtils;
import com.airbnb.lottie.LottieAnimationView;
import com.airbnb.lottie.LottieDrawable;
/**
* A preference represents an accessibility shortcut option with a checkbox and a tutorial image
@@ -96,7 +95,8 @@ public class ShortcutOptionPreference extends CheckBoxPreference {
.getResourceEntryName(mIntroImageRawResId),
result));
imageView.setAnimation(mIntroImageRawResId);
imageView.setRepeatCount(LottieDrawable.INFINITE);
// Follow the Motion Stoppable requirement by using a finite animation.
imageView.setRepeatCount(0);
LottieColorUtils.applyDynamicColors(imageView.getContext(), imageView);
imageView.playAnimation();
} else {