Merge "Support Wi-Fi DPP metrics categories in Wi-Fi DPP activities & fragments."

This commit is contained in:
Arc Wang
2018-12-18 02:30:36 +00:00
committed by Android (Google) Code Review
7 changed files with 30 additions and 14 deletions

View File

@@ -18,6 +18,7 @@ package com.android.settings.wifi.dpp;
import android.os.Bundle; import android.os.Bundle;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.R; import com.android.settings.R;
/** /**
@@ -30,6 +31,11 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
return R.layout.wifi_dpp_add_device_fragment; return R.layout.wifi_dpp_add_device_fragment;
} }
@Override
public int getMetricsCategory() {
return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR;
}
@Override @Override
public void onActivityCreated (Bundle savedInstanceState) { public void onActivityCreated (Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState); super.onActivityCreated(savedInstanceState);

View File

@@ -18,6 +18,7 @@ package com.android.settings.wifi.dpp;
import android.os.Bundle; import android.os.Bundle;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.R; import com.android.settings.R;
/** /**
@@ -30,6 +31,11 @@ public class WifiDppChooseSavedWifiNetworkFragment extends WifiDppQrCodeBaseFrag
return R.layout.wifi_dpp_choose_saved_wifi_network_fragment; return R.layout.wifi_dpp_choose_saved_wifi_network_fragment;
} }
@Override
public int getMetricsCategory() {
return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR;
}
@Override @Override
public void onActivityCreated (Bundle savedInstanceState) { public void onActivityCreated (Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState); super.onActivityCreated(savedInstanceState);

View File

@@ -27,7 +27,6 @@ import androidx.fragment.app.FragmentManager;
import androidx.fragment.app.FragmentTransaction; import androidx.fragment.app.FragmentTransaction;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.InstrumentedActivity; import com.android.settings.core.InstrumentedActivity;
import com.android.settings.R; import com.android.settings.R;
@@ -67,8 +66,7 @@ public class WifiDppConfiguratorActivity extends InstrumentedActivity implements
@Override @Override
public int getMetricsCategory() { public int getMetricsCategory() {
//TODO:Should we use a new metrics category for Wi-Fi DPP? return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR;
return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS;
} }
@Override @Override

View File

@@ -27,7 +27,6 @@ import androidx.fragment.app.FragmentManager;
import androidx.fragment.app.FragmentTransaction; import androidx.fragment.app.FragmentTransaction;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.InstrumentedActivity; import com.android.settings.core.InstrumentedActivity;
import com.android.settings.R; import com.android.settings.R;
@@ -47,8 +46,7 @@ public class WifiDppEnrolleeActivity extends InstrumentedActivity {
@Override @Override
public int getMetricsCategory() { public int getMetricsCategory() {
//TODO:Should we use a new metrics category for Wi-Fi DPP? return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_ENROLLEE;
return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS;
} }
@Override @Override

View File

@@ -26,8 +26,6 @@ import android.widget.ListView;
import android.widget.ProgressBar; import android.widget.ProgressBar;
import android.widget.TextView; import android.widget.TextView;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.InstrumentedFragment; import com.android.settings.core.InstrumentedFragment;
import com.android.settings.R; import com.android.settings.R;
@@ -61,12 +59,6 @@ public abstract class WifiDppQrCodeBaseFragment extends InstrumentedFragment {
abstract protected int getLayout(); abstract protected int getLayout();
@Override
public int getMetricsCategory() {
//TODO:Should we use a new metrics category for Wi-Fi DPP?
return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS;
}
@Override @Override
public final void onCreate(Bundle savedInstanceState) { public final void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);

View File

@@ -23,6 +23,7 @@ import android.view.Menu;
import android.view.MenuInflater; import android.view.MenuInflater;
import android.view.MenuItem; import android.view.MenuItem;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.R; import com.android.settings.R;
/** /**
@@ -35,6 +36,11 @@ public class WifiDppQrCodeGeneratorFragment extends WifiDppQrCodeBaseFragment {
return R.layout.wifi_dpp_qrcode_generator_fragment; return R.layout.wifi_dpp_qrcode_generator_fragment;
} }
@Override
public int getMetricsCategory() {
return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR;
}
// Container Activity must implement this interface // Container Activity must implement this interface
public interface OnQrCodeGeneratorFragmentAddButtonClickedListener { public interface OnQrCodeGeneratorFragmentAddButtonClickedListener {
public void onQrCodeGeneratorFragmentAddButtonClicked(); public void onQrCodeGeneratorFragmentAddButtonClicked();

View File

@@ -33,6 +33,7 @@ import android.view.TextureView;
import android.view.TextureView.SurfaceTextureListener; import android.view.TextureView.SurfaceTextureListener;
import android.view.View; import android.view.View;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.wifi.qrcode.QrCamera; import com.android.settings.wifi.qrcode.QrCamera;
import com.android.settings.wifi.qrcode.QrDecorateView; import com.android.settings.wifi.qrcode.QrDecorateView;
@@ -55,6 +56,15 @@ public class WifiDppQrCodeScannerFragment extends WifiDppQrCodeBaseFragment impl
return R.layout.wifi_dpp_qrcode_scanner_fragment; return R.layout.wifi_dpp_qrcode_scanner_fragment;
} }
@Override
public int getMetricsCategory() {
if (mConfiguratorMode) {
return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR;
} else {
return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_ENROLLEE;
}
}
/** /**
* Configurator container activity of the fragment should create instance with this constructor. * Configurator container activity of the fragment should create instance with this constructor.
*/ */