diff --git a/src/com/android/settings/wifi/dpp/WifiDppAddDeviceFragment.java b/src/com/android/settings/wifi/dpp/WifiDppAddDeviceFragment.java index 177e79d3b53..8d6aa6813c5 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppAddDeviceFragment.java +++ b/src/com/android/settings/wifi/dpp/WifiDppAddDeviceFragment.java @@ -18,6 +18,7 @@ package com.android.settings.wifi.dpp; import android.os.Bundle; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; /** @@ -30,6 +31,11 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment { return R.layout.wifi_dpp_add_device_fragment; } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR; + } + @Override public void onActivityCreated (Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); diff --git a/src/com/android/settings/wifi/dpp/WifiDppChooseSavedWifiNetworkFragment.java b/src/com/android/settings/wifi/dpp/WifiDppChooseSavedWifiNetworkFragment.java index 7d031c18ea1..66bc349ebdf 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppChooseSavedWifiNetworkFragment.java +++ b/src/com/android/settings/wifi/dpp/WifiDppChooseSavedWifiNetworkFragment.java @@ -18,6 +18,7 @@ package com.android.settings.wifi.dpp; import android.os.Bundle; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; /** @@ -30,6 +31,11 @@ public class WifiDppChooseSavedWifiNetworkFragment extends WifiDppQrCodeBaseFrag return R.layout.wifi_dpp_choose_saved_wifi_network_fragment; } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR; + } + @Override public void onActivityCreated (Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); diff --git a/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java b/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java index e4ae292d998..6c95f09cecc 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java +++ b/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java @@ -27,7 +27,6 @@ import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentTransaction; import com.android.internal.logging.nano.MetricsProto; - import com.android.settings.core.InstrumentedActivity; import com.android.settings.R; @@ -67,8 +66,7 @@ public class WifiDppConfiguratorActivity extends InstrumentedActivity implements @Override public int getMetricsCategory() { - //TODO:Should we use a new metrics category for Wi-Fi DPP? - return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS; + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR; } @Override diff --git a/src/com/android/settings/wifi/dpp/WifiDppEnrolleeActivity.java b/src/com/android/settings/wifi/dpp/WifiDppEnrolleeActivity.java index 39d993f03f9..920e73668df 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppEnrolleeActivity.java +++ b/src/com/android/settings/wifi/dpp/WifiDppEnrolleeActivity.java @@ -27,7 +27,6 @@ import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentTransaction; import com.android.internal.logging.nano.MetricsProto; - import com.android.settings.core.InstrumentedActivity; import com.android.settings.R; @@ -47,8 +46,7 @@ public class WifiDppEnrolleeActivity extends InstrumentedActivity { @Override public int getMetricsCategory() { - //TODO:Should we use a new metrics category for Wi-Fi DPP? - return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS; + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_ENROLLEE; } @Override diff --git a/src/com/android/settings/wifi/dpp/WifiDppQrCodeBaseFragment.java b/src/com/android/settings/wifi/dpp/WifiDppQrCodeBaseFragment.java index cfdb40a342d..5b76f11cdfa 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppQrCodeBaseFragment.java +++ b/src/com/android/settings/wifi/dpp/WifiDppQrCodeBaseFragment.java @@ -26,8 +26,6 @@ import android.widget.ListView; import android.widget.ProgressBar; import android.widget.TextView; -import com.android.internal.logging.nano.MetricsProto; - import com.android.settings.core.InstrumentedFragment; import com.android.settings.R; @@ -61,12 +59,6 @@ public abstract class WifiDppQrCodeBaseFragment extends InstrumentedFragment { abstract protected int getLayout(); - @Override - public int getMetricsCategory() { - //TODO:Should we use a new metrics category for Wi-Fi DPP? - return MetricsProto.MetricsEvent.WIFI_NETWORK_DETAILS; - } - @Override public final void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); diff --git a/src/com/android/settings/wifi/dpp/WifiDppQrCodeGeneratorFragment.java b/src/com/android/settings/wifi/dpp/WifiDppQrCodeGeneratorFragment.java index b064253f315..ec22415d90b 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppQrCodeGeneratorFragment.java +++ b/src/com/android/settings/wifi/dpp/WifiDppQrCodeGeneratorFragment.java @@ -23,6 +23,7 @@ import android.view.Menu; import android.view.MenuInflater; import android.view.MenuItem; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; /** @@ -35,6 +36,11 @@ public class WifiDppQrCodeGeneratorFragment extends WifiDppQrCodeBaseFragment { return R.layout.wifi_dpp_qrcode_generator_fragment; } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR; + } + // Container Activity must implement this interface public interface OnQrCodeGeneratorFragmentAddButtonClickedListener { public void onQrCodeGeneratorFragmentAddButtonClicked(); diff --git a/src/com/android/settings/wifi/dpp/WifiDppQrCodeScannerFragment.java b/src/com/android/settings/wifi/dpp/WifiDppQrCodeScannerFragment.java index e7124a5d9d5..64ede72ce43 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppQrCodeScannerFragment.java +++ b/src/com/android/settings/wifi/dpp/WifiDppQrCodeScannerFragment.java @@ -33,6 +33,7 @@ import android.view.TextureView; import android.view.TextureView.SurfaceTextureListener; import android.view.View; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.wifi.qrcode.QrCamera; import com.android.settings.wifi.qrcode.QrDecorateView; @@ -55,6 +56,15 @@ public class WifiDppQrCodeScannerFragment extends WifiDppQrCodeBaseFragment impl return R.layout.wifi_dpp_qrcode_scanner_fragment; } + @Override + public int getMetricsCategory() { + if (mConfiguratorMode) { + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_CONFIGURATOR; + } else { + return MetricsProto.MetricsEvent.SETTINGS_WIFI_DPP_ENROLLEE; + } + } + /** * Configurator container activity of the fragment should create instance with this constructor. */