PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flake issue on SettingsRoboTests

Browse Source 
Root cause: SpannableStringBuilder cannot handle the preference title is
empty caes.
Solution: Assign default value in test case setup.

Bug: 188448957
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=AccessibilityButtonFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=AccessibilityControlTimeoutFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=CaptionFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleAutoclickFooterPreferenceControllerTest
Change-Id: Ia95a6ecba824d81e0ccf649975517231ecf475b3
This commit is contained in:
menghanli
2021-05-18 10:44:04 +08:00
parent cbb2bd6d13
commit 4a12cd51a6
4 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonFooterPreferenceControllerTest.java
View File

@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner;
public class AccessibilityButtonFooterPreferenceControllerTest { public class AccessibilityButtonFooterPreferenceControllerTest {
private static final String TEST_KEY = "test_key"; private static final String TEST_KEY = "test_key";
private static final String TEST_TITLE = "test_title";
private final Context mContext = ApplicationProvider.getApplicationContext(); private final Context mContext = ApplicationProvider.getApplicationContext();
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
private AccessibilityButtonFooterPreferenceController mController; private AccessibilityButtonFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class AccessibilityButtonFooterPreferenceControllerTest {
final AccessibilityFooterPreference footerPreference = final AccessibilityFooterPreference footerPreference =
new AccessibilityFooterPreference(mContext); new AccessibilityFooterPreference(mContext);
footerPreference.setKey(TEST_KEY); footerPreference.setKey(TEST_KEY);
footerPreference.setTitle(TEST_TITLE);
mScreen.addPreference(footerPreference); mScreen.addPreference(footerPreference);
mController = new AccessibilityButtonFooterPreferenceController(mContext, TEST_KEY); mController = new AccessibilityButtonFooterPreferenceController(mContext, TEST_KEY);
} }

2
tests/robotests/src/com/android/settings/accessibility/AccessibilityControlTimeoutFooterPreferenceControllerTest.java
View File

@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner;
public class AccessibilityControlTimeoutFooterPreferenceControllerTest { public class AccessibilityControlTimeoutFooterPreferenceControllerTest {
private static final String TEST_KEY = "test_key"; private static final String TEST_KEY = "test_key";
private static final String TEST_TITLE = "test_title";
private final Context mContext = ApplicationProvider.getApplicationContext(); private final Context mContext = ApplicationProvider.getApplicationContext();
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
private AccessibilityControlTimeoutFooterPreferenceController mController; private AccessibilityControlTimeoutFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class AccessibilityControlTimeoutFooterPreferenceControllerTest {
final AccessibilityFooterPreference footerPreference = final AccessibilityFooterPreference footerPreference =
new AccessibilityFooterPreference(mContext); new AccessibilityFooterPreference(mContext);
footerPreference.setKey(TEST_KEY); footerPreference.setKey(TEST_KEY);
footerPreference.setTitle(TEST_TITLE);
mScreen.addPreference(footerPreference); mScreen.addPreference(footerPreference);
mController = new AccessibilityControlTimeoutFooterPreferenceController(mContext, TEST_KEY); mController = new AccessibilityControlTimeoutFooterPreferenceController(mContext, TEST_KEY);
} }

2
tests/robotests/src/com/android/settings/accessibility/CaptionFooterPreferenceControllerTest.java
View File

@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner;
public class CaptionFooterPreferenceControllerTest { public class CaptionFooterPreferenceControllerTest {
private static final String TEST_KEY = "test_key"; private static final String TEST_KEY = "test_key";
private static final String TEST_TITLE = "test_title";
private final Context mContext = ApplicationProvider.getApplicationContext(); private final Context mContext = ApplicationProvider.getApplicationContext();
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
private CaptionFooterPreferenceController mController; private CaptionFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class CaptionFooterPreferenceControllerTest {
final AccessibilityFooterPreference footerPreference = final AccessibilityFooterPreference footerPreference =
new AccessibilityFooterPreference(mContext); new AccessibilityFooterPreference(mContext);
footerPreference.setKey(TEST_KEY); footerPreference.setKey(TEST_KEY);
footerPreference.setTitle(TEST_TITLE);
mScreen.addPreference(footerPreference); mScreen.addPreference(footerPreference);
mController = new CaptionFooterPreferenceController(mContext, TEST_KEY); mController = new CaptionFooterPreferenceController(mContext, TEST_KEY);
} }

2
tests/robotests/src/com/android/settings/accessibility/ToggleAutoclickFooterPreferenceControllerTest.java
View File

@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner;
public class ToggleAutoclickFooterPreferenceControllerTest { public class ToggleAutoclickFooterPreferenceControllerTest {
private static final String TEST_KEY = "test_key"; private static final String TEST_KEY = "test_key";
private static final String TEST_TITLE = "test_title";
private final Context mContext = ApplicationProvider.getApplicationContext(); private final Context mContext = ApplicationProvider.getApplicationContext();
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
private ToggleAutoclickFooterPreferenceController mController; private ToggleAutoclickFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class ToggleAutoclickFooterPreferenceControllerTest {
final AccessibilityFooterPreference footerPreference = final AccessibilityFooterPreference footerPreference =
new AccessibilityFooterPreference(mContext); new AccessibilityFooterPreference(mContext);
footerPreference.setKey(TEST_KEY); footerPreference.setKey(TEST_KEY);
footerPreference.setTitle(TEST_TITLE);
mScreen.addPreference(footerPreference); mScreen.addPreference(footerPreference);
mController = new ToggleAutoclickFooterPreferenceController(mContext, TEST_KEY); mController = new ToggleAutoclickFooterPreferenceController(mContext, TEST_KEY);
} }