PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make some notification related slices public.

Browse Source 
Only PreferenceControllers with isPublicSlice() set to true are exposed
to other apps. Others will be Settings only.

Bug: 141088937
Test: robotests
Change-Id: I6e7b9d45084ea9944143e606bfac56b2cae3e8a3
This commit is contained in:
Yi-Ling Chuang
2019-11-27 13:50:50 +08:00
parent 72af90940d
commit 3f9f068ca9
14 changed files with 70 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/notification/AlarmVolumePreferenceController.java
View File

@@ -41,6 +41,11 @@ public class AlarmVolumePreferenceController extends VolumeSeekBarPreferenceCont
return TextUtils.equals(getPreferenceKey(), "alarm_volume");
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public boolean useDynamicSliceSummary() {
return true;

5
src/com/android/settings/notification/CallVolumePreferenceController.java
View File

@@ -43,6 +43,11 @@ public class CallVolumePreferenceController extends VolumeSeekBarPreferenceContr
return TextUtils.equals(getPreferenceKey(), "call_volume");
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public boolean useDynamicSliceSummary() {
return true;

5
src/com/android/settings/notification/MediaVolumePreferenceController.java
View File

@@ -42,6 +42,11 @@ public class MediaVolumePreferenceController extends VolumeSeekBarPreferenceCont
return TextUtils.equals(getPreferenceKey(), KEY_MEDIA_VOLUME);
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public boolean useDynamicSliceSummary() {
return true;

5
src/com/android/settings/notification/NotificationVolumePreferenceController.java
View File

@@ -44,6 +44,11 @@ public class NotificationVolumePreferenceController extends
return TextUtils.equals(getPreferenceKey(), KEY_NOTIFICATION_VOLUME);
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public String getPreferenceKey() {
return KEY_NOTIFICATION_VOLUME;

5
src/com/android/settings/notification/RemoteVolumePreferenceController.java
View File

@@ -196,6 +196,11 @@ public class RemoteVolumePreferenceController extends VolumeSeekBarPreferenceCon
return TextUtils.equals(getPreferenceKey(), KEY_REMOTE_VOLUME);
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public boolean useDynamicSliceSummary() {
return true;

5
src/com/android/settings/notification/RingVolumePreferenceController.java
View File

@@ -95,6 +95,11 @@ public class RingVolumePreferenceController extends VolumeSeekBarPreferenceContr
return TextUtils.equals(getPreferenceKey(), KEY_RING_VOLUME);
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public boolean useDynamicSliceSummary() {
return true;

5
src/com/android/settings/notification/VibrateWhenRingPreferenceController.java
View File

@@ -77,6 +77,11 @@ public class VibrateWhenRingPreferenceController extends TogglePreferenceControl
return TextUtils.equals(getPreferenceKey(), "vibrate_when_ringing");
}
@Override
public boolean isPublicSlice() {
return true;
}
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);

5
tests/robotests/src/com/android/settings/notification/AlarmVolumePreferenceControllerTest.java
View File

@@ -78,4 +78,9 @@ public class AlarmVolumePreferenceControllerTest {
public void isSliceableCorrectKey_returnsTrue() {
assertThat(mController.isSliceable()).isTrue();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

5
tests/robotests/src/com/android/settings/notification/CallVolumePreferenceControllerTest.java
View File

@@ -102,4 +102,9 @@ public class CallVolumePreferenceControllerTest {
new CallVolumePreferenceController(mContext, "bad_key");
assertThat(controller.isSliceable()).isFalse();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

5
tests/robotests/src/com/android/settings/notification/MediaVolumePreferenceControllerTest.java
View File

@@ -63,4 +63,9 @@ public class MediaVolumePreferenceControllerTest {
mContext);
assertThat(controller.isSliceable()).isTrue();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

5
tests/robotests/src/com/android/settings/notification/NotificationVolumePreferenceControllerTest.java
View File

@@ -102,4 +102,9 @@ public class NotificationVolumePreferenceControllerTest {
new NotificationVolumePreferenceController(mContext);
assertThat(controller.isSliceable()).isTrue();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

5
tests/robotests/src/com/android/settings/notification/RemoteVolumePreferenceControllerTest.java
View File

@@ -218,4 +218,9 @@ public class RemoteVolumePreferenceControllerTest {
assertThat(mController.mPreference.getProgress()).isEqualTo(CURRENT_POS);
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

5
tests/robotests/src/com/android/settings/notification/RingVolumePreferenceControllerTest.java
View File

@@ -104,4 +104,9 @@ public class RingVolumePreferenceControllerTest {
new RingVolumePreferenceController(mContext);
assertThat(controller.isSliceable()).isTrue();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}

6
tests/robotests/src/com/android/settings/notification/VibrateWhenRingPreferenceControllerTest.java
View File

@@ -44,9 +44,9 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.annotation.Config;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
import org.robolectric.shadow.api.Shadow;
import org.robolectric.shadows.ShadowContentResolver;
@@ -225,4 +225,8 @@ public class VibrateWhenRingPreferenceControllerTest {
assertThat(controller.isSliceable()).isFalse();
}
@Test
public void isPublicSlice_returnTrue() {
assertThat(mController.isPublicSlice()).isTrue();
}
}