PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundent @VisibleForTesting annotation

Browse Source 
There are many methods marked with @VisibleForTesting annotation but
they are overridden or used by child classes. So remove
@VisibleForTesting for readability.

Fixes: 73292660
Test: Rebuild and Robotests
Change-Id: Ie7fe8ac98deb3d050578552982ab523bd1694deb
This commit is contained in:
Yanting Yang
2019-11-15 17:15:26 +08:00
parent b4a6245d8d
commit 3996084a9e
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/widget/RadioButtonPickerFragment.java
View File

@@ -150,12 +150,10 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
/** /**
* A chance for subclasses to bind additional things to the preference. * A chance for subclasses to bind additional things to the preference.
*/ */
@VisibleForTesting(otherwise = VisibleForTesting.PROTECTED)
public void bindPreferenceExtra(RadioButtonPreference pref, public void bindPreferenceExtra(RadioButtonPreference pref,
String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { String key, CandidateInfo info, String defaultKey, String systemDefaultKey) {
} }
@VisibleForTesting
public void updateCandidates() { public void updateCandidates() {
mCandidates.clear(); mCandidates.clear();
final List<? extends CandidateInfo> candidateList = getCandidates(); final List<? extends CandidateInfo> candidateList = getCandidates();
@@ -204,7 +202,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
} }
} }
@VisibleForTesting
public RadioButtonPreference bindPreference(RadioButtonPreference pref, public RadioButtonPreference bindPreference(RadioButtonPreference pref,
String key, CandidateInfo info, String defaultKey) { String key, CandidateInfo info, String defaultKey) {
pref.setTitle(info.loadLabel()); pref.setTitle(info.loadLabel());
@@ -218,7 +215,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
return pref; return pref;
} }
@VisibleForTesting
public void updateCheckedState(String selectedKey) { public void updateCheckedState(String selectedKey) {
final PreferenceScreen screen = getPreferenceScreen(); final PreferenceScreen screen = getPreferenceScreen();
if (screen != null) { if (screen != null) {
@@ -236,7 +232,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
} }
} }
@VisibleForTesting
public void mayCheckOnlyRadioButton() { public void mayCheckOnlyRadioButton() {
final PreferenceScreen screen = getPreferenceScreen(); final PreferenceScreen screen = getPreferenceScreen();
// If there is only 1 thing on screen, select it. // If there is only 1 thing on screen, select it.