From 3996084a9e1db283fa9bdad1aa4927936724514f Mon Sep 17 00:00:00 2001 From: Yanting Yang Date: Fri, 15 Nov 2019 17:15:26 +0800 Subject: [PATCH] Remove redundent @VisibleForTesting annotation There are many methods marked with @VisibleForTesting annotation but they are overridden or used by child classes. So remove @VisibleForTesting for readability. Fixes: 73292660 Test: Rebuild and Robotests Change-Id: Ie7fe8ac98deb3d050578552982ab523bd1694deb --- .../android/settings/widget/RadioButtonPickerFragment.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/com/android/settings/widget/RadioButtonPickerFragment.java b/src/com/android/settings/widget/RadioButtonPickerFragment.java index 3193afbf22f..0f4fbc3433b 100644 --- a/src/com/android/settings/widget/RadioButtonPickerFragment.java +++ b/src/com/android/settings/widget/RadioButtonPickerFragment.java @@ -150,12 +150,10 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr /** * A chance for subclasses to bind additional things to the preference. */ - @VisibleForTesting(otherwise = VisibleForTesting.PROTECTED) public void bindPreferenceExtra(RadioButtonPreference pref, String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { } - @VisibleForTesting public void updateCandidates() { mCandidates.clear(); final List candidateList = getCandidates(); @@ -204,7 +202,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr } } - @VisibleForTesting public RadioButtonPreference bindPreference(RadioButtonPreference pref, String key, CandidateInfo info, String defaultKey) { pref.setTitle(info.loadLabel()); @@ -218,7 +215,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr return pref; } - @VisibleForTesting public void updateCheckedState(String selectedKey) { final PreferenceScreen screen = getPreferenceScreen(); if (screen != null) { @@ -236,7 +232,6 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr } } - @VisibleForTesting public void mayCheckOnlyRadioButton() { final PreferenceScreen screen = getPreferenceScreen(); // If there is only 1 thing on screen, select it.