PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of spurious gear icon in BT details page

Browse Source 
The problem is that we were calling done() on the EntityHeaderController
and passing false for whether to rebind the action buttons, which means
we were getting the default behavior including a visible gear
icon. Passing true to request rebinding causes that icon to be hidden.

Bug: 63405635
Test: make RunSettingsRoboTests
Change-Id: I031f4a2d176ff3be025cc2675d7026a679936b03
This commit is contained in:
Antony Sargent
2017-07-07 11:09:24 -07:00
parent 6d50576496
commit 2efec86bae
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/bluetooth/BluetoothDetailsHeaderController.java
View File

@@ -64,7 +64,7 @@ public class BluetoothDetailsHeaderController extends BluetoothDetailsController
@Override
protected void refresh() {
setHeaderProperties();
mHeaderController.done(mFragment.getActivity(), false);
mHeaderController.done(mFragment.getActivity(), true /* rebindActions */);
}
@Override

2
tests/robotests/src/com/android/settings/bluetooth/BluetoothDetailsHeaderControllerTest.java
View File

@@ -81,7 +81,7 @@ public class BluetoothDetailsHeaderControllerTest extends BluetoothDetailsContro
verify(mHeaderController).setIcon(any(Drawable.class));
verify(mHeaderController).setIconContentDescription(any(String.class));
verify(mHeaderController).setSummary(any(String.class));
verify(mHeaderController).done(mActivity, false);
verify(mHeaderController).done(mActivity, true);
}
@Test