PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix LocationSetttingsFooter robotests" into sc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2021-05-27 20:23:53 +00:00
committed by Android (Google) Code Review
parent 2718cea083 7a2122e35a
commit 2bc0aa5537
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/robotests/src/com/android/settings/location/LocationSettingsFooterPreferenceControllerTest.java
View File

@@ -109,24 +109,30 @@ public class LocationSettingsFooterPreferenceControllerTest {
assertThat(mController.isAvailable()).isTrue(); assertThat(mController.isAvailable()).isTrue();
} }
/**
* Display the footer even without the injected string.
*/
@Test @Test
public void isAvailable_noSystemApp_returnsFalse() { public void isAvailable_noSystemApp_returnsTrue() {
final List<ResolveInfo> testResolveInfos = new ArrayList<>(); final List<ResolveInfo> testResolveInfos = new ArrayList<>();
testResolveInfos.add( testResolveInfos.add(
getTestResolveInfo(/*isSystemApp*/ false, /*hasRequiredMetadata*/ true)); getTestResolveInfo(/*isSystemApp*/ false, /*hasRequiredMetadata*/ true));
when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt())) when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt()))
.thenReturn(testResolveInfos); .thenReturn(testResolveInfos);
assertThat(mController.isAvailable()).isFalse(); assertThat(mController.isAvailable()).isTrue();
} }
/**
* Display the footer even without the injected string.
*/
@Test @Test
public void isAvailable_noRequiredMetadata_returnsFalse() { public void isAvailable_noRequiredMetadata_returnsTrue() {
final List<ResolveInfo> testResolveInfos = new ArrayList<>(); final List<ResolveInfo> testResolveInfos = new ArrayList<>();
testResolveInfos.add( testResolveInfos.add(
getTestResolveInfo(/*isSystemApp*/ true, /*hasRequiredMetadata*/ false)); getTestResolveInfo(/*isSystemApp*/ true, /*hasRequiredMetadata*/ false));
when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt())) when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt()))
.thenReturn(testResolveInfos); .thenReturn(testResolveInfos);
assertThat(mController.isAvailable()).isFalse(); assertThat(mController.isAvailable()).isTrue();
} }
@Test @Test
@@ -154,7 +160,8 @@ public class LocationSettingsFooterPreferenceControllerTest {
mController.onLocationModeChanged(/* mode= */ 0, /* restricted= */ false); mController.onLocationModeChanged(/* mode= */ 0, /* restricted= */ false);
ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class); ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class);
verify(mFooterPreference, times(2)).setTitle(title.capture()); verify(mFooterPreference, times(2)).setTitle(title.capture());
assertThat(title.getValue().toString()).isEqualTo(
assertThat(title.getValue().toString()).contains(
Html.fromHtml(mContext.getString( Html.fromHtml(mContext.getString(
R.string.location_settings_footer_location_off)).toString()); R.string.location_settings_footer_location_off)).toString());
} }
@@ -171,7 +178,7 @@ public class LocationSettingsFooterPreferenceControllerTest {
mController.onLocationModeChanged(/* mode= */ 1, /* restricted= */ false); mController.onLocationModeChanged(/* mode= */ 1, /* restricted= */ false);
ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class); ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class);
verify(mFooterPreference, times(2)).setTitle(title.capture()); verify(mFooterPreference, times(2)).setTitle(title.capture());
assertThat(title.getValue().toString()).isNotEqualTo( assertThat(title.getValue().toString()).doesNotContain(
Html.fromHtml(mContext.getString( Html.fromHtml(mContext.getString(
R.string.location_settings_footer_location_off)).toString()); R.string.location_settings_footer_location_off)).toString());
} }