From 7a2122e35aad9a8c9306a5b0757c7259ec45336f Mon Sep 17 00:00:00 2001
From: Yu-Han Yang <yuhany@google.com>
Date: Thu, 27 May 2021 11:26:00 -0700
Subject: [PATCH] Fix LocationSetttingsFooter robotests

Bug: 189352953
Test: tests passing
Change-Id: I4ca1a53449a6b845e39bcb7423cfee2ee5c9d820
---
 ...ettingsFooterPreferenceControllerTest.java | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tests/robotests/src/com/android/settings/location/LocationSettingsFooterPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/location/LocationSettingsFooterPreferenceControllerTest.java
index 7929b718abe..333929dc10e 100644
--- a/tests/robotests/src/com/android/settings/location/LocationSettingsFooterPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/location/LocationSettingsFooterPreferenceControllerTest.java
@@ -109,24 +109,30 @@ public class LocationSettingsFooterPreferenceControllerTest {
         assertThat(mController.isAvailable()).isTrue();
     }
 
+    /**
+     * Display the footer even without the injected string.
+     */
     @Test
-    public void isAvailable_noSystemApp_returnsFalse() {
+    public void isAvailable_noSystemApp_returnsTrue() {
         final List<ResolveInfo> testResolveInfos = new ArrayList<>();
         testResolveInfos.add(
                 getTestResolveInfo(/*isSystemApp*/ false, /*hasRequiredMetadata*/ true));
         when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt()))
                 .thenReturn(testResolveInfos);
-        assertThat(mController.isAvailable()).isFalse();
+        assertThat(mController.isAvailable()).isTrue();
     }
 
+    /**
+     * Display the footer even without the injected string.
+     */
     @Test
-    public void isAvailable_noRequiredMetadata_returnsFalse() {
+    public void isAvailable_noRequiredMetadata_returnsTrue() {
         final List<ResolveInfo> testResolveInfos = new ArrayList<>();
         testResolveInfos.add(
                 getTestResolveInfo(/*isSystemApp*/ true, /*hasRequiredMetadata*/ false));
         when(mPackageManager.queryBroadcastReceivers(any(Intent.class), anyInt()))
                 .thenReturn(testResolveInfos);
-        assertThat(mController.isAvailable()).isFalse();
+        assertThat(mController.isAvailable()).isTrue();
     }
 
     @Test
@@ -154,7 +160,8 @@ public class LocationSettingsFooterPreferenceControllerTest {
         mController.onLocationModeChanged(/* mode= */ 0, /* restricted= */ false);
         ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class);
         verify(mFooterPreference, times(2)).setTitle(title.capture());
-        assertThat(title.getValue().toString()).isEqualTo(
+
+        assertThat(title.getValue().toString()).contains(
                 Html.fromHtml(mContext.getString(
                         R.string.location_settings_footer_location_off)).toString());
     }
@@ -171,7 +178,7 @@ public class LocationSettingsFooterPreferenceControllerTest {
         mController.onLocationModeChanged(/* mode= */ 1, /* restricted= */ false);
         ArgumentCaptor<CharSequence> title = ArgumentCaptor.forClass(CharSequence.class);
         verify(mFooterPreference, times(2)).setTitle(title.capture());
-        assertThat(title.getValue().toString()).isNotEqualTo(
+        assertThat(title.getValue().toString()).doesNotContain(
                 Html.fromHtml(mContext.getString(
                         R.string.location_settings_footer_location_off)).toString());
     }