Merge "Fix the issue of the repo upload hooking checker" into sc-dev am: f575da48e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/13849842 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ia272c7d7dd79e2381b04c1433d16e65696464276
This commit is contained in:
@@ -4013,4 +4013,36 @@
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" <item android:offset="0" android:color="#FF4285F4"/>"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/drawable/one_handed_guideline.xml"
|
||||
line="34"
|
||||
column="36"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" <item android:offset="1" android:color="#004385F5"/>"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/drawable/one_handed_guideline.xml"
|
||||
line="35"
|
||||
column="36"/>
|
||||
</issue>
|
||||
|
||||
</issues>
|
||||
|
Reference in New Issue
Block a user