Commit Graph

3108 Commits

Author SHA1 Message Date
Sen Jiang ef45a88680 Merge "Add a stub recovery UI." am: 8c1584feaf
am: 2f8f6ec0fc

Change-Id: I8acb01933efe7d8d69a608cc9801bf717fae4486
2016-12-14 22:07:46 +00:00
Sen Jiang 2f8f6ec0fc Merge "Add a stub recovery UI."
am: 8c1584feaf

Change-Id: I88c79576a1c700509bb844936dbd8ef3784b1b13
2016-12-14 22:00:44 +00:00
Sen Jiang 8c1584feaf Merge "Add a stub recovery UI." 2016-12-14 21:50:49 +00:00
Tao Bao e97575e7ae Merge "updater: Fix the operator order." am: 2bb3a2270e
am: f7f3f821a8

Change-Id: I346ad87013e6ebfb06b825ae541fabe7be87649e
2016-12-14 20:40:52 +00:00
Tao Bao f7f3f821a8 Merge "updater: Fix the operator order."
am: 2bb3a2270e

Change-Id: I3b558413b92062cfa6c8858f7083f68796a8da0a
2016-12-14 20:34:22 +00:00
Treehugger Robot 2bb3a2270e Merge "updater: Fix the operator order." 2016-12-14 20:28:31 +00:00
Tao Bao 5354f60f2b updater: Fix the operator order.
Shift operator ("<<") has a higher precedence level than ternary
operator ("?").

Test: BBOTA update log says "performing update" as opposed to
      "performing 0".

Change-Id: I0cf60cbfc11415e94f1f9f6effe75f14d13a1874
2016-12-14 11:34:49 -08:00
Tao Bao 1871a2feeb Merge "Remove the obsolete comments for firmware update." am: 833ecb03f2
am: 527f08ed0b

Change-Id: I93716c3c455f118b0bac88d18c7c0e157031834b
2016-12-14 18:48:07 +00:00
Tao Bao 527f08ed0b Merge "Remove the obsolete comments for firmware update."
am: 833ecb03f2

Change-Id: I3a52452d5e3fb6df7f85c39f7ad5fbcc2f5949ee
2016-12-14 18:42:00 +00:00
Tao Bao 833ecb03f2 Merge "Remove the obsolete comments for firmware update." 2016-12-14 18:34:26 +00:00
Tao Bao c0336399ae Remove the obsolete comments for firmware update.
The corresponding code was removed in commit
e08991e02a in 2010 (Froyo).

Test: N/A
Change-Id: I2b296e1b07d54232bade79fda7501387d65a4c37
2016-12-13 22:36:02 -08:00
Tao Bao b1e8150c44 Merge "Add tests for setup-bcb and clear-bcb via uncrypt." am: 4e48a6c1a1
am: af62097c08

Change-Id: Ic892f6317de9c08082beeb508c825c459cbb59d2
2016-12-14 05:32:00 +00:00
Tao Bao af62097c08 Merge "Add tests for setup-bcb and clear-bcb via uncrypt."
am: 4e48a6c1a1

Change-Id: Iaec2a0a3edf3354a030fe921e23acbc97babbb16
2016-12-14 05:25:00 +00:00
Tao Bao 4e48a6c1a1 Merge "Add tests for setup-bcb and clear-bcb via uncrypt." 2016-12-14 05:17:47 +00:00
Tao Bao 1033408801 Add tests for setup-bcb and clear-bcb via uncrypt.
Bug: http://b/33534933
Test: recovery_component_test passes (and fails on buggy build due to
      the CL in [1]).

[1]: commit 7e31f421a5

Change-Id: I120498048ec1db8f9fcbb3cf135c05d3a48cfcdf
2016-12-13 17:46:03 -08:00
Tao Bao 495478e853 Merge "recovery: Clean up the log saving while wiping." am: 28bbe029b6
am: 7294a8830b

Change-Id: I07bad38eb7c81a66c43be759bc13af85b00446c7
2016-12-13 22:48:38 +00:00
Tao Bao 7294a8830b Merge "recovery: Clean up the log saving while wiping."
am: 28bbe029b6

Change-Id: I0dfd2815874940624bbee2e02a506549fc68e070
2016-12-13 22:42:06 +00:00
Tao Bao 28bbe029b6 Merge "recovery: Clean up the log saving while wiping." 2016-12-13 22:36:38 +00:00
Sen Jiang d530449e54 Add a stub recovery UI.
This allows recovery to work on devices without screen.
The stub recovery UI does nothing except print to stdout.

Test: write 'recovery\n--wipe_data\n--reason=wipe_data_from_ota\n'
      to misc and boot to recovery on a device without screen.
Bug: 33175036

Change-Id: Icde698aa2e2e29f4b3d0532dfd3c6a939ac2bc63
2016-12-13 13:29:33 -08:00
Tao Bao 3f5a3821be recovery: Clean up the log saving while wiping.
Test: Wipe /cache and check the logs.
      Wipe /data and check the logs.
Change-Id: I1968e3a0a9ed80134811a91508c4473f1dcdf953
2016-12-13 11:47:46 -08:00
Tao Bao 01afbb8f29 Merge "clang-format: Adjust short functions / if settings." am: d6a5005fcb
am: 3541850a9a

Change-Id: Iae26e512af03094e6f38864241e79eeff32fbb6b
2016-12-13 18:27:51 +00:00
Tao Bao 3541850a9a Merge "clang-format: Adjust short functions / if settings."
am: d6a5005fcb

Change-Id: I2d8d58e4361207656e883cf21116eef9f35bf521
2016-12-13 18:21:50 +00:00
Tao Bao d6a5005fcb Merge "clang-format: Adjust short functions / if settings." 2016-12-13 18:13:56 +00:00
Tao Bao 1b321e43e1 Merge "Revert "write_bootloader_message(<options>) should not reset stage field."" am: c908f4f0e3
am: 09197c47e2

Change-Id: Ic9156da53b0f07ecd794e4a5c4f948387d76e701
2016-12-13 01:38:56 +00:00
Tao Bao 09197c47e2 Merge "Revert "write_bootloader_message(<options>) should not reset stage field.""
am: c908f4f0e3

Change-Id: Ia24a7db9ee7dd655e1aa0eabfbe3cdf47b011d40
2016-12-13 01:32:53 +00:00
Tao Bao c908f4f0e3 Merge "Revert "write_bootloader_message(<options>) should not reset stage field."" 2016-12-13 01:24:04 +00:00
Tao Bao 26d5ae741e Revert "write_bootloader_message(<options>) should not reset stage field."
This reverts commit 7e31f421a5.

Bug: 33534933
Change-Id: Ib173f6b1e36a79deafc3592785195693a6779471
2016-12-13 01:06:24 +00:00
Tao Bao e65fa0a892 clang-format: Adjust short functions / if settings.
http://clang.llvm.org/docs/ClangFormatStyleOptions.html

AllowShortFunctionsOnASingleLine: Empty
  Empty functions like "int f() {}" can be put on a single line.

AllowShortIfStatementsOnASingleLine: true
  If true, "if (a) return;" can be put on a single line.

Test: N/A
Change-Id: Ia4f411a958235ab18d16972f2c9d0f55b645b4ba
2016-12-12 15:00:52 -08:00
Tao Bao ff77b42d66 Merge "recovery: Remove obsolete code that supports "CACHE:foo" format." am: 594dc4f5be
am: cbb044239a

Change-Id: Ia6b73bac53888b399ca7c0696373b177e5726098
2016-12-10 21:00:31 +00:00
Tao Bao cbb044239a Merge "recovery: Remove obsolete code that supports "CACHE:foo" format."
am: 594dc4f5be

Change-Id: I290bcbe38e8aea9f296ddd0e0263e6e02cf92885
2016-12-10 20:54:31 +00:00
Tao Bao 594dc4f5be Merge "recovery: Remove obsolete code that supports "CACHE:foo" format." 2016-12-10 20:50:16 +00:00
Tao Bao f038ca00f4 recovery: Remove obsolete code that supports "CACHE:foo" format.
The passing of "--update_package=CACHE:foo" format has been removed
in Gingerbread, with commit 4baf641e7d96375eba3f9a3aff5400b9e3d28cd6
in frameworks/base (core/java/android/os/RecoverySystem.java).

Test: Recovery image with --update_package still works.
Change-Id: I37b56ccf98f62cadf2a3975bbc38b16fea6fe9a1
2016-12-10 09:29:16 -08:00
Tao Bao d8ce8fa609 Merge "write_bootloader_message(<options>) should not reset stage field." am: f28afc191d
am: f4fabe254c

Change-Id: I8cde0f335ff2c2a496f497d744ffc6a94ea832b7
2016-12-09 22:43:47 +00:00
Tao Bao f4fabe254c Merge "write_bootloader_message(<options>) should not reset stage field."
am: f28afc191d

Change-Id: I267a7130f70fef654e0cd5209d32ff4115250e45
2016-12-09 22:39:18 +00:00
Tao Bao f28afc191d Merge "write_bootloader_message(<options>) should not reset stage field." 2016-12-09 22:33:49 +00:00
Tao Bao d4ceb1fb64 Merge "recovery: Fix the argument parsing from COMMAND_FILE." am: 332af25b7c
am: 6be6680109

Change-Id: I3cd516e8bb86f685143847e11624df4791183437
2016-12-09 19:59:09 +00:00
Tao Bao 6be6680109 Merge "recovery: Fix the argument parsing from COMMAND_FILE."
am: 332af25b7c

Change-Id: Ib7cdd050d4f20c61ac35c1fb1ad469c5b1c72262
2016-12-09 19:54:08 +00:00
Tao Bao 332af25b7c Merge "recovery: Fix the argument parsing from COMMAND_FILE." 2016-12-09 19:48:58 +00:00
Tao Bao 7d34fa17ab recovery: Fix the argument parsing from COMMAND_FILE.
Commit f0ed159f48 didn't ensure mounting
COMMAND_FILE (i.e. /cache) prior to reading. Also the first argument in
COMMAND_FILE should not be dropped (unlike the first "recovery" argument
in BCB message).

Bug: 33431888
Test: Push /cache/recovery/command and recovery imag parses the
      arguments successfully.

Change-Id: Ica3157a0bb03a2355315123354617eaf3fff15a4
2016-12-08 18:15:29 -08:00
Tao Bao dd9c5674df Merge "recovery: Clean up get_args()." am: 3aadbbac39
am: c3ab25c237

Change-Id: I29a01238bba2cd35e48a03275e3ada4d4fee2888
2016-12-05 23:38:45 +00:00
Tao Bao c3ab25c237 Merge "recovery: Clean up get_args()."
am: 3aadbbac39

Change-Id: I8dd8003433ae2a33da51d69c25fe1b51628c8f97
2016-12-05 23:35:16 +00:00
Tao Bao 7e31f421a5 write_bootloader_message(<options>) should not reset stage field.
Commit bd56f1590c switches to calling
write_bootloader_message(<options>) in get_args(), which
unintentionally resets the stage field thus breaks two-step OTAs.

This CL changes write_bootloader_message(<options>) to only set the
command field (to "boot-recovery") and the recovery field (with the
specified options).

Test: Apply a two-step package.
Change-Id: I6905918812c7d3402cc1524688079066a4d22d29
2016-12-05 15:31:52 -08:00
Tao Bao 3aadbbac39 Merge "recovery: Clean up get_args()." 2016-12-05 23:28:36 +00:00
Tao Bao f0ed159f48 recovery: Clean up get_args().
Test: Boot into new recovery image, verify the parsed parameters.
Change-Id: Ieefafb26cc4147ce4cb9ced4297cdb3b5d1d3789
2016-12-05 11:39:46 -08:00
Tao Bao 997ccbc5a4 Merge "updater: Switch to libbase logging." am: d2c56629ab
am: 1d9779b57b

Change-Id: I92e782fc5b4df4a952f0759fb15f80754dce7802
2016-12-02 05:45:25 +00:00
Tao Bao 1d9779b57b Merge "updater: Switch to libbase logging."
am: d2c56629ab

Change-Id: Iadb27da225c4b0c7c6bc80d177d36bdf87296a5b
2016-12-02 05:37:54 +00:00
Tao Bao d2c56629ab Merge "updater: Switch to libbase logging." 2016-12-02 05:27:04 +00:00
Tao Bao bd8f34190c Merge "bootable/recovery: cleanup compiler warnings (unused value)" am: ef3bea15b8
am: 80cd188162

Change-Id: I14483f9a2272767d0f7fec426875b8dbb2fcd350
2016-12-01 17:30:38 +00:00
Tao Bao 80cd188162 Merge "bootable/recovery: cleanup compiler warnings (unused value)"
am: ef3bea15b8

Change-Id: I401597b9d7bad8a13c98093019cd6ad915d325f3
2016-12-01 17:25:37 +00:00
Tao Bao ef3bea15b8 Merge "bootable/recovery: cleanup compiler warnings (unused value)" 2016-12-01 17:03:13 +00:00