Commit Graph

3357 Commits

Author SHA1 Message Date
Tao Bao 19e7776451 Merge "recovery: Clean up browse_directory()." am: 635eb1c83e
am: c42d44bbeb

Change-Id: I462259ea96248f253e161065a17b0098add83716
2017-02-14 02:05:12 +00:00
Tao Bao c42d44bbeb Merge "recovery: Clean up browse_directory()."
am: 635eb1c83e

Change-Id: Idf8a4e33a1f7cfd5d5c648aa97e00219828fc58d
2017-02-14 02:03:11 +00:00
Tao Bao 635eb1c83e Merge "recovery: Clean up browse_directory()." 2017-02-14 01:56:24 +00:00
Tao Bao b8997adc20 Merge "minui: Move graphics_{adf,drm,fbdev} into classes." am: 0d14cc279c
am: 6585a3c368

Change-Id: I0484295d4c202f6854968f99bac0b4b0c6928378
2017-02-13 18:32:15 +00:00
Tao Bao 6585a3c368 Merge "minui: Move graphics_{adf,drm,fbdev} into classes."
am: 0d14cc279c

Change-Id: I75c426732188a868f0acb160284a45a19d0b9b1e
2017-02-13 18:29:46 +00:00
Tao Bao 0d14cc279c Merge "minui: Move graphics_{adf,drm,fbdev} into classes." 2017-02-13 18:25:06 +00:00
Tao Bao c4a18efa84 recovery: Clean up browse_directory().
Get rid of the malloc/realloc/free'd menus.

browse_directory() will only be called on devices with SD card. Tested
the CL by temporarily setting SDCARD_ROOT to a different location.

Test: See above.
Change-Id: I935e1bf4bad0273e3dff87fa2536924f1219adb5
2017-02-10 21:21:52 -08:00
Tao Bao 557fa1f45e minui: Move graphics_{adf,drm,fbdev} into classes.
This CL defines minui_backend as an interface, and expresses the three
backends (adf, drm and fbdev) as subclasses to the interface.

Test: 'Run graphics test' on N9, Pixel C and N5X.
Change-Id: I0e23951c7b2e2ff918957a8d9fc8b0085b6e5952
2017-02-10 17:05:15 -08:00
Tao Bao 30c164411f Merge "minui: Save errno before calling close()." am: df464dbe79
am: 8075089ca1

Change-Id: I7641b122a89431ecdf1208a11dd5c0e3f948ab0b
2017-02-09 23:38:09 +00:00
Tao Bao 8075089ca1 Merge "minui: Save errno before calling close()."
am: df464dbe79

Change-Id: I58e4df9b09b8c6e1470a815180df73d908b98d0a
2017-02-09 23:36:09 +00:00
Treehugger Robot df464dbe79 Merge "minui: Save errno before calling close()." 2017-02-09 23:17:59 +00:00
Tao Bao f04592ba23 minui: Save errno before calling close().
Otherwise errno would be overwritten when calling close(2).

Test: mmma bootable/recovery
Change-Id: I661e46b1b040f550639a728aa2683e91621b4307
2017-02-09 12:59:19 -08:00
Tao Bao c441edd1c3 Merge "minui: Clean up graphics_fbdev.cpp." am: 5121961421
am: e91a2d23ca

Change-Id: I9eb08e7e14df408dc3a6284d9a558858060f1052
2017-02-09 20:38:49 +00:00
Tao Bao e91a2d23ca Merge "minui: Clean up graphics_fbdev.cpp."
am: 5121961421

Change-Id: If16c6e23b6eb8854660c5c461fc5283e5e5bd4e5
2017-02-09 20:36:49 +00:00
Treehugger Robot 5121961421 Merge "minui: Clean up graphics_fbdev.cpp." 2017-02-09 20:31:02 +00:00
Tao Bao ffd5c03711 Merge "minui: Clean up graphics_adf.cpp." am: d592e1d5e1
am: 46829c326e

Change-Id: I1b12bb7c728cb1be70a865f489971f38e00fe175
2017-02-09 20:14:17 +00:00
Tao Bao 46829c326e Merge "minui: Clean up graphics_adf.cpp."
am: d592e1d5e1

Change-Id: Ia530771c7e5443b15ffacfcd439549617c3bd6fb
2017-02-09 20:12:17 +00:00
Tao Bao d592e1d5e1 Merge "minui: Clean up graphics_adf.cpp." 2017-02-09 20:07:09 +00:00
Tao Bao ed5ee5292c Merge "minui: Clean up graphics_drm.cpp." am: 648f252c71
am: f6b6b75916

Change-Id: I897a2b2a5046554a92ee8be59bc6e90ebbe2b8f5
2017-02-09 19:51:15 +00:00
Tao Bao f6b6b75916 Merge "minui: Clean up graphics_drm.cpp."
am: 648f252c71

Change-Id: I30f5536b2a0686424da0dc31ba9da787768a00d4
2017-02-09 19:49:15 +00:00
Treehugger Robot 648f252c71 Merge "minui: Clean up graphics_drm.cpp." 2017-02-09 19:43:20 +00:00
Tao Bao 76be34cb34 minui: Clean up graphics_drm.cpp.
Remove unneeded header includes. Switch a few memset() to '= {}'
style. Otherwise mostly cosmetic changes like reformatting.

Test: 'Run graphics test' on ryu (which is a DRM device).

Change-Id: I4b0ab2dc0da69a690f09e4f0674b8377de662962
2017-02-07 14:47:59 -08:00
Tao Bao acf4dd157a minui: Clean up graphics_fbdev.cpp.
Remove unneeded header includes. Otherwise mostly cosmetic changes like
reformatting.

Test: 'Run graphics test' on bullhead (which uses fbdev).

Change-Id: I9b92c96128fa332ac940f73764f9c5fc93ff6c8c
2017-02-07 14:46:31 -08:00
Tao Bao 8f0e21b271 minui: Clean up graphics_adf.cpp.
Remove unneeded header includes. Switch a few memset() to '= {}' style.
Otherwise mostly cosmetic changes like reformatting.

Test: 'Run graphics test' on N9 (which is an ADF device).

Change-Id: If008af18ddae9521f53216b581d882d5eed76d41
2017-02-07 13:20:55 -08:00
Tao Bao b8af1beed0 Merge "Replace _exit(-1) with _exit(EXIT_FAILURE)." am: 95bcbfdd4e
am: 80176c68b2

Change-Id: I6338fc4f929b0887563a0194719c887131538fec
2017-02-03 23:48:27 +00:00
Tao Bao 80176c68b2 Merge "Replace _exit(-1) with _exit(EXIT_FAILURE)."
am: 95bcbfdd4e

Change-Id: Icbf6b4d02cc8d60c66f7ed8ebf9d7798a2d518c3
2017-02-03 23:45:58 +00:00
Treehugger Robot 95bcbfdd4e Merge "Replace _exit(-1) with _exit(EXIT_FAILURE)." 2017-02-03 23:40:06 +00:00
Tianjie Xu 15ab95bb63 Merge "Avoid to call UI functions in child process" am: 0f275ae56e
am: 5fa2e576f9

Change-Id: I83d52f51ab6c788cc67a75ca6f7a46cd2f8289cd
2017-02-03 22:14:20 +00:00
Tianjie Xu 5fa2e576f9 Merge "Avoid to call UI functions in child process"
am: 0f275ae56e

Change-Id: Ia1a735d6ca5c966e6e84c5fe67456c3b5142632e
2017-02-03 22:12:19 +00:00
Tao Bao 3da880156b Replace _exit(-1) with _exit(EXIT_FAILURE).
-1 is not a valid exit status.

Also replace a few exit(1) with exit(EXIT_FAILURE).

Test: mmma bootable/recovery
Change-Id: I4596c8328b770bf95acccc06a4401bd5cabd4bfd
2017-02-03 14:11:11 -08:00
Treehugger Robot 0f275ae56e Merge "Avoid to call UI functions in child process" 2017-02-03 22:06:50 +00:00
Tianjie Xu a8764c46aa Merge "update_verifier should read dm wrapped partition" am: c44c479197
am: d40cd0e7cf

Change-Id: Ief705589ebe2293ecb2e688a7643c5f2e4a79ea9
2017-02-03 22:01:52 +00:00
Tianjie Xu d40cd0e7cf Merge "update_verifier should read dm wrapped partition"
am: c44c479197

Change-Id: I3ce467a3d634f2a566f87a936a86e7b55627c6cd
2017-02-03 21:57:21 +00:00
Tianjie Xu c44c479197 Merge "update_verifier should read dm wrapped partition" 2017-02-03 21:50:07 +00:00
Tao Bao 7d8e13a535 Merge "minui: Minor clean up to graphics.cpp." am: b04bc0540d
am: ec8d74580d

Change-Id: I9cb585a2cbca3d6a1dcf884aba179acf36380352
2017-02-03 20:55:45 +00:00
Tao Bao ec8d74580d Merge "minui: Minor clean up to graphics.cpp."
am: b04bc0540d

Change-Id: Ie1ebc638e9a013d69f0195b567a8a16aa3aaf79c
2017-02-03 20:51:14 +00:00
Tao Bao b04bc0540d Merge "minui: Minor clean up to graphics.cpp." 2017-02-03 20:48:47 +00:00
Tianjie Xu ab1abae59c Avoid to call UI functions in child process
ui_print uses a mutex to protect the critical section. And a forked
child process may intialize the mutex inappropriatly, which leads to a
hanging child process. So we shall avoid to call the UI functions in
child process.

Bug: 34769056
Test: fake ota on fugu failed as expected due to updater format mismatch.
Change-Id: I81bc942a796878fac19cf712512092c2b0d807c9
2017-02-03 20:35:40 +00:00
Tao Bao e8020f4fa3 minui: Minor clean up to graphics.cpp.
Remove unneeded header includes.

Remove the dead code in gr_test() (already commented out). Similar tests
have been covered by the "Run graphics test" from recovery menu.

Test: mmma -j32 bootable/recovery
Change-Id: If977c1b780602f5c5054469a3dae4fd85f34ab1a
2017-02-03 09:33:36 -08:00
Tao Bao 2be767eba4 Merge "Fix a log issue in ui.cpp." am: 7f38fbf976
am: c33d037d7d

Change-Id: I440288d7d518e9aa6cb13fe7d8647770bc7011f3
2017-02-01 16:44:58 +00:00
Tao Bao c33d037d7d Merge "Fix a log issue in ui.cpp."
am: 7f38fbf976

Change-Id: I84dcdabf341eb566ee7591259c405ac7d406ebf0
2017-02-01 16:42:58 +00:00
Tao Bao 7f38fbf976 Merge "Fix a log issue in ui.cpp." 2017-02-01 16:39:13 +00:00
Tao Bao 8eec37330b Fix a log issue in ui.cpp.
It's a copy/paste error when addressing reviewer's comment for commit
6278bdf349.

Test: recovery gives the right message (e.g. "Permission denied") when
      it fails to read max_brightness.

Change-Id: I10372c82595bdc00a6f6725f036c02721b19a1aa
2017-01-31 21:27:27 -08:00
Tao Bao 1c35b48253 Merge "bootable/recovery: cleanup compiler warnings (potential leak of memory)" am: 7ab9c3812d
am: 29ef12f777

Change-Id: I95295f72efb73b6b40a2cd420514204b4bc93d63
2017-02-01 05:18:26 +00:00
Tao Bao 29ef12f777 Merge "bootable/recovery: cleanup compiler warnings (potential leak of memory)"
am: 7ab9c3812d

Change-Id: I779a671ef4756fb149dc1bd5823eb85f0e846269
2017-02-01 05:15:50 +00:00
Tao Bao 7ab9c3812d Merge "bootable/recovery: cleanup compiler warnings (potential leak of memory)" 2017-02-01 05:10:15 +00:00
Tao Bao 79ce31073a Merge "recovery: Add screensaver mode." am: 389a29193c
am: 2684259c34

Change-Id: I94fa5b8e3d0faad7e16a8f696f9b96bb055f2fc6
2017-01-31 06:17:53 +00:00
Tao Bao 2684259c34 Merge "recovery: Add screensaver mode."
am: 389a29193c

Change-Id: Ia3a03dce52f6e6c0aa907643aa67ad725fea8005
2017-01-31 06:15:53 +00:00
Tao Bao 389a29193c Merge "recovery: Add screensaver mode." 2017-01-31 06:11:37 +00:00
Tao Bao 6278bdf349 recovery: Add screensaver mode.
While it's waiting for user input, dim or turn off the backlight to
avoid OLED burn-in. The backlight brightness will be reduced after the
first timeout (default 120s), and then turned off after the second.
Pressing any key will take it back to the normal brightness. While the
display is off, the first key input will only turn on the backlight.

The most common case that triggers the screensaver is under text mode,
such as waiting for menu selection or viewing recovery logs.

This CL doesn't change the brightness while it's installing updates or
performing wipes under UI mode.

When it encounters any install error under UI mode (user builds):
 - If it's NOT USB connected, it will reboot automatically after the
   first timeout (same as before);
 - If it's USB connected, it will dim and turn off the display per the
   change in this CL.

Bug: 34077703
Test: Boot a device with the new recovery image. Wait for timeout.

Change-Id: I0c14907e60340a7f037adb6e464942d099ada08b
2017-01-30 16:12:30 -08:00