PawletOS/android_bootable_recovery
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

updater: Use O_SYNC and fsync() for package_extract_file().

Browse Source 
We are already using O_SYNC and fsync() for the recursive case
(package_extract_dir()). Make it consistent for the single-file case.

Bug: 20625549
Change-Id: I487736fe5a0647dd4a2428845e76bf642e0f0dff
This commit is contained in:
Tao Bao
2015-12-14 15:53:25 -08:00
parent e062645efa
commit d3cac34430
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
updater/install.cpp
+13 -6
View File
@@ -555,14 +555,21 @@ Value* PackageExtractFileFn(const char* name, State* state,
}
{
FILE* f = fopen(dest_path, "wb");
if (f == NULL) {
printf("%s: can't open %s for write: %s\n",
name, dest_path, strerror(errno));
int fd = TEMP_FAILURE_RETRY(open(dest_path, O_WRONLY | O_CREAT | O_TRUNC | O_SYNC,
S_IRUSR | S_IWUSR));
if (fd == -1) {
printf("%s: can't open %s for write: %s\n", name, dest_path, strerror(errno));
goto done2;
}
success = mzExtractZipEntryToFile(za, entry, fileno(f));
fclose(f);
success = mzExtractZipEntryToFile(za, entry, fd);
if (fsync(fd) == -1) {
printf("fsync of \"%s\" failed: %s\n", dest_path, strerror(errno));
success = false;
}
if (close(fd) == -1) {
printf("close of \"%s\" failed: %s\n", dest_path, strerror(errno));
success = false;
}
}
done2: