PawletOS/android_bootable_recovery
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "updater: Use O_SYNC and fsync() for package_extract_file()."

Browse Source
This commit is contained in:
Tao Bao
2015-12-15 17:55:05 +00:00
committed by Gerrit Code Review
parent e062645efa d3cac34430
commit 4e72d1a81e
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
updater/install.cpp
+13 -6
View File
@@ -555,14 +555,21 @@ Value* PackageExtractFileFn(const char* name, State* state,
} }
{ {
FILE* f = fopen(dest_path, "wb"); int fd = TEMP_FAILURE_RETRY(open(dest_path, O_WRONLY | O_CREAT | O_TRUNC | O_SYNC,
if (f == NULL) { S_IRUSR | S_IWUSR));
printf("%s: can't open %s for write: %s\n", if (fd == -1) {
name, dest_path, strerror(errno)); printf("%s: can't open %s for write: %s\n", name, dest_path, strerror(errno));
goto done2; goto done2;
} }
success = mzExtractZipEntryToFile(za, entry, fileno(f)); success = mzExtractZipEntryToFile(za, entry, fd);
fclose(f); if (fsync(fd) == -1) {
printf("fsync of \"%s\" failed: %s\n", dest_path, strerror(errno));
success = false;
}
if (close(fd) == -1) {
printf("close of \"%s\" failed: %s\n", dest_path, strerror(errno));
success = false;
}
} }
done2: done2: