Commit Graph

3785 Commits

Author SHA1 Message Date
Becky Qiu ff6bc2ab5f [Overview Actions] For in-place landscape, add select only when aiai works.
When display orientation is not the same as device orientation, aiai won't work for select mode highlight. So we should only show the select button in task menu for in-place landscape when the display rotation is the same as the device rotation which is portrait.

Screenshot would be in the task menu for in-place landscape all the time.

Test: demo video: https://drive.google.com/file/d/1OQrjww2lFTTsthz4dB3BSa-jw943KLWp/view?usp=sharing
Change-Id: I58b6f6da234ea36eef0af5bb966c33ebda3625b8
2020-06-17 17:39:56 +00:00
TreeHugger Robot 4de12a2424 Merge "Fixing OAV buttons not working and removing logs." into ub-launcher3-rvc-dev 2020-06-17 17:26:14 +00:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
TreeHugger Robot cbe1251ce7 Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev 2020-06-16 23:23:12 +00:00
TreeHugger Robot ded59ac331 Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev 2020-06-16 23:18:45 +00:00
Becky Qiu 8798440600 [Overview Actions] Disable swiping on modal recentsView for talkback.
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.

Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
2020-06-16 15:47:20 -07:00
Tony Wickham f2b8c927a9 Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev 2020-06-16 22:12:28 +00:00
TreeHugger Robot 89e39a6dfa Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev 2020-06-16 22:11:56 +00:00
Samuel Fufa eb957403a8 Increase Predicted app icon sing size
Bug: 159041772
Change-Id: I0b71c6a2b2da9e4b058554e60cf0c59d242368c6
2020-06-16 14:34:36 -07:00
Samuel Fufa 345f728f2c Create hotseat predictor onCreate
ModelTask posted in setupViews does not get called.
Bug: 159151258

Change-Id: I45bfe7cf8ea18b09faaf3c0e612be90722e1e410
2020-06-16 14:22:02 -07:00
TreeHugger Robot 9354de6c91 Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev 2020-06-16 20:58:39 +00:00
vadimt 6a3de331af Attempt to workaround a leak on Taimen
It's a flake.
It was likely caused by enabling fallback tests, and we don't know
what's leaked and why.

Bug: 143488140
Change-Id: I0d0c88ac9b0de316861f16ba023a596c1f39cde4
2020-06-16 20:21:49 +00:00
Sreyas 826bb2e932 Fixing OAV buttons not working and removing logs.
Bug: 154838868
Change-Id: Icde83dc527a1aacf6a8a79325e6a33c5235a64fb
2020-06-16 12:20:25 -07:00
TreeHugger Robot cf4e6cd055 Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev 2020-06-16 19:00:24 +00:00
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
TreeHugger Robot eb9f60adab Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev 2020-06-15 22:37:26 +00:00
Pinyao Ting 817054d000 fix a11y issue where scroll next can still be triggered on final page in
RecentsView

Bug: 151450844
Test: manual verification with following steps
1. launch a few apps
2. swipe up from bottom to bring up RecentsView
3. enable talkback
4. perform a scroll next a11y gesture (without lifting finger, swipe
right then left)
5. verify nothing happens (as opposed to pushing the page back a little)

Change-Id: I6dea2559592bdaa7227a2e12ce0565d6d7b7f4a1
2020-06-15 14:51:04 -07:00
Tony Wickham f1a8f47a4a Add null check before applying fullscreen params
Bug: 159026796
Change-Id: I5c1a0ca26c8e4a187e2217870b27289ecf18238e
2020-06-15 16:41:50 -05:00
Sunny Goyal 8cd8d15886 Fixing sysui scrim not updating in landscape UI
Bug: 156422012
Change-Id: I2e1e9149e8337dd663bf564bd1b7f661ec2864e9
2020-06-15 13:42:07 -07:00
TreeHugger Robot 946696124a Merge "Don't set mLikelyToStartNewTask=true before slop for first gesture" into ub-launcher3-rvc-dev 2020-06-15 20:24:51 +00:00
Tony Wickham f3cd3762c9 Don't set mLikelyToStartNewTask=true before slop for first gesture
We should only set it to true before the slop when continuing the
gesture, otherwise gestures to home could attach the adjacent
task view before the transition even starts.

Bug: 158855957
Change-Id: I86eba9bad9c85e05d5274d7396160762a28e5cf1
2020-06-15 14:09:14 -05:00
Sunny Goyal b10e865e48 Preventing parallel motion event dispatching from view system and event proxy
1) When view system is already dispatching an event, proxy-dispatch is restricted
   to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
   takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
   proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
   dispatching only (and proxy-dispatch is already restricted to gesture only).

Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
2020-06-15 11:50:54 -07:00
TreeHugger Robot 832aa03a4b Merge "[race condition] Improve hotseat availability when launcher is recreated" into ub-launcher3-rvc-dev 2020-06-15 18:16:59 +00:00
TreeHugger Robot 8555146d9a Merge "Gates blur code behind BlurUtils#supportsBlursOnWindows." into ub-launcher3-rvc-dev 2020-06-15 18:14:01 +00:00
TreeHugger Robot 72cf3d31a5 Merge "Remove a comment that a line of code is a workaround" into ub-launcher3-rvc-dev 2020-06-15 18:06:20 +00:00
vadimt f6a179d3ae Remove a comment that a line of code is a workaround
Bug: 157099707
Change-Id: I417df10735438caf6fd7fd5833817b5c43a1e856
2020-06-15 10:19:15 -07:00
Samuel Fufa 8e90ee0362 [race condition] Improve hotseat availability when launcher is recreated
In cases where onCreate does not get called before bindPredictedItems, mHotseatPredictionController will be null. This results in the hotseat remaining empty until AiAi sends predictions.

Bug: 158867468
Test: Manual
Change-Id: I4f3c3fc41f489e96a9f91dc9505202ae9ce9cce1
2020-06-14 18:30:50 -07:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
Vadim Tryshev aeacb7c850 Merge "Enable FallbackRecentsTest" into ub-launcher3-rvc-dev 2020-06-13 00:55:06 +00:00
TreeHugger Robot 48f600c51d Merge "[Overview Actions] onBackPressed for the modal state will go to overview." into ub-launcher3-rvc-dev 2020-06-13 00:52:48 +00:00
Becky Qiu e1fdf3e059 [Overview Actions] Add a decelerateInterpolator for motion of select mode.
Test: local
Bug: 157777836

Change-Id: I8cbc14c41e9046aa5993fe4add010acdd612539a
2020-06-12 17:07:42 -07:00
Becky Qiu fb40075752 [Overview Actions] onBackPressed for the modal state will go to overview.
Test: local
Bug: 157778187
Change-Id: Ie5252d39e54ca11de389dd698bfb7751fdf8f60e
2020-06-12 17:04:18 -07:00
vadimt 01bb8125b0 Enable FallbackRecentsTest
With some temporary workarounds.

Bug: 143488140

Change-Id: Id1ed2d06fd3265a6aa7f98d2900733f580359944
2020-06-12 15:12:37 -07:00
Sunny Goyal 05179b6650 Fixing recents animation not getting completed sometimes when using 3P launcher
Bug: 158855992
Change-Id: I2c0cb74edfea5406e79aa99d6604183e63c1f0f1
2020-06-12 22:07:41 +00:00
TreeHugger Robot e3a51fec39 Merge "Fixing sysui visibility changing multiple times on startup" into ub-launcher3-rvc-dev 2020-06-12 18:45:41 +00:00
TreeHugger Robot 1eb6b2acf6 Merge "Creating correct device profile when appContext and launcher context do not match" into ub-launcher3-rvc-dev 2020-06-12 18:37:30 +00:00
Jon Miranda 7c57559930 Gates blur code behind BlurUtils#supportsBlursOnWindows.
This "fixes" the bug where wallpaper zoom does not reset to 0 when
screen turns off since we no longer require a valid surface to set the depth
when blur is disabled.

Note that the bug still exists when blur is enabled, which will need to be
fixed in a follow up CL.

Bug: 157946272
Change-Id: I43179435885c95eb2ecf406fa5c291badf5a1ed3
2020-06-12 11:03:10 -07:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
TreeHugger Robot 662796d18b Merge "Fix quick switching to any task that already appeared" into ub-launcher3-rvc-dev 2020-06-12 05:22:44 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Sunny Goyal de52876a2b Fixing sysui visibility changing multiple times on startup
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI

Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
2020-06-10 19:13:36 -07:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
TreeHugger Robot ca5e9cb7ef Merge "Notify SysUi on device rotation for back gesture" into ub-launcher3-rvc-dev 2020-06-10 23:14:06 +00:00