Currently, if we create 4 (upper limit) non-empty desks, reboot, and
enter Overview, the addDesktopButton shows up when it actully shouldn't.
This change fixes this edge case by checking if we can create a desk or
not when inflating addDesktopButton and update its visibility
accordingly.
Bug: 416052493
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: create desks and reboot
Change-Id: I7142c3aeb88cc1f06b99ddef753ea20c63b17297
- CD grids should override startAlignTaskbar.
- The DP.toBuilder method should carry forward DisplayInfoSpec instead
of always recalculating.
Fix: 416276424
Test: m
Flag: EXEMPT updating recently added logic
Change-Id: I7b1cb8eab5fedc09b29e96a765d1341655474e8a
Note: enableOverviewOnConnectedDisplays must be true to enable the
functionality (taskbar button --> home) in the first place
Bug: 378443899
Test: m
Flag: com.android.window.flags.enable_reject_home_transition
Change-Id: Icf5e5939c8e4f59a7d87c30df0d74a151bdbd1d5
Test: tested overview in a connected display with a full screen app. Verified the full screen app is shown in a small tile.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 415030147
Change-Id: I3e9313a17e9a323ecada89ac6fac29ea126cc613
Particularly with predictive back in cases that the app doesn't
support peeking the home screen, there was a thrashing animation
due to a secondary blur animation being applied. So in some cases,
it would rapidly alternate between 0 blur and the correct animation
blur. This wasn't necessarily user-visible, but likely contributed
to some performance jank.
Also ensure the scaling workspace blur uses the correct starting
depth and duration.
Demo: https://drive.google.com/file/d/1AffSvzlXycg8Yl4ULpctKADO6IdvvO3m/view?usp=drive_link&resourcekey=0--zqQ341w7U3MhRBwSYrsyA
Bug: 407534544
Test: Manual (predictive back, back without predictive peek, home)
Flag: com.android.launcher3.predictive_back_to_home_blur
Flag: com.android.launcher3.all_apps_blur
Change-Id: I76ed59e99aaef5bd44e8f5b0290f01763a8d4b0f
- Without this, the following type of issues manifest: if shade is
pulled down when folded and then the device is unfolded, the taskbars
are recreated but on the connected display the taskbar is stashed
because on unfolding the shade remains pulled down and because we
reused share state the taskbar on connected display remains stashed.
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 414767865
Change-Id: I7579f70edf342f5f34e7884a26c2decb512e3143
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated
Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
- Ignore blur changes smaller than 1dp unless going to/from 0.
- Don't apply depth animation during app launch from blurred
All Apps.
- Use DepthController directly rather than creating a new one
for other app launch animaitons. Avoids extraneous memory and
performance overhead.
Bug: 411292920
Bug: 410973453
Bug: 408284263
Test: forrest perf tests
Flag: com.android.launcher3.all_apps_blur
Change-Id: Id5c8e71b19ebb8f1c1b82f8c5c76785e001017af
Added SYSUI_STATE_IME_VISIBLE flag to MASK_HIDE_HANDLE_VIEW to hide the
bubble bar stash handle view. Also update alpha to 1 for the stash
handle view when visibility is updated to VISIBLE.
Fixes: 403363673
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Have stashed bubble bar and multiple system languages.
Go to settings (or ane other apps that has input fields). Click on
search to trigger keyboard pop up. Observe that stash handle is hidden.
Collapse the keyboard and observe that stash handle is shown again.
Change-Id: I5c8518cf02cc784243f9f55a95022279b2608760
Use task offsets to determine which spring drives which, as columns should move in unison.
Fix: 403234864
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I48f7f2a7fcfbd2850d371b4bc7eed3296a2a650a
During quick switch we will always need to have background Transparent for consistency.
Previous implementation of Quick switch state was inconsistent. Hence making quick switch state return always transparent.
Bug: 416217645
Test: Quick switch between apps.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I561dd6509bbadbbdc751308740d8152bcb0c4032
Also changed TouchInteractionService gestureNavMode to be per-display
Bug: 415269541
Flag: EXEMPT bugfix
Test: local + presubmit
Change-Id: I0da978e6fcb29f743b41f1c75c6d0efd8e7231a8
This cl simply reuses logic of setting the default taksbar window size upon rotation of device.
Test: Manual
Bug: 411587814
Flag: EXEMPT bugfix
Change-Id: I65149425b8d03240c3c4ab09ec0ec82be6b40c8f
Keep these file in synch with the nudge proto definition in //depot/google3/java/com/google/android/desktop/growth/proto.
Bug: 416054612
Test: EXEMPT add in the follow up CL
Flag: EXEMPT add separately
Change-Id: I5fe6ae7b3cb285bd1c07fd4ff54b273799ec0d98
- Use supplied TaskbarActivityContext to evaluate padding in dp instead
of Resources.getSystem that doesn't seem to provide accurate
measurement when launcher is initialising.
Fix: 414343355
Test: m
Flag: EXEMPT minor refactor
Change-Id: Ia64a7280ba60534fc949269c5886e9b32a917e03
In TaskViewUtils, the StateManager#movetoRestState method is invoked after the recents animation finishes and before the launcher state is reapplied. The issue leading to a phantom transition is that moveToRestState initiates an animation due to RecentsWindowManager#shouldAnimateStateChange always returns true.
Connected display overview is similar to 3P recents. And thus, we follow RecentsActivity#shouldAnimateStateChange to always return false.
Test: manually click on a overview tile in the connected display. No phantom animation is observed after switching to the app.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 415245440
Change-Id: I3c9600cae6ce9058749365734f433f5e3cdb9445
When the home screen is shown behind desktop mode, pressing the overview button to start a transition should still animate tasks shown on top of home screen. To ensure that freeform tasks are animated, the home screen should not be considered visible when performing transitions in this case. Therefore, make getVisibleLauncher() return null, so that switchToRecentsIfVisible() doesn't animate launcher to overview without animating the freeform tasks at the same time.
Bug: 375644149
Flag: com.android.window.flags.show_home_behind_desktop
Test: Open a window, press overview button. With no windows open, press
overview button.
Change-Id: I9b1d72e35071c5b446b98a8e6c6695ff5c666222
Remove com.android.launcher3
.enable_show_enabled_shortcuts_in_accessibility_menu flag and
references from the codebase
Fix: 415679751
Flag: EXEMPT. Cleanup
Test: OverviewMenuImageTest
Change-Id: I3a7b58b7c3fe4c6c3a5750fd1e851909630e80ff
Treehugger Robot
Jagrut Desai
Rob Mickle
Suhua Lei
Ajinkya Chalke
Sergey Pinkevich
Steven Ng
Sunny Goyal
Sebastián Franco
Andy Wickham
Mykola Podolian
Pat Manning
Merissa Mitchell
Matthew Mourgos
Thu-Huong Vu
vinayjoglekar
Will Osborn
Pierre Barbier de Reuille
Vinit Nayak
Sam Cackett