Commit Graph

1026 Commits

Author SHA1 Message Date
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Gustav Sennton 568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Gustav Sennton 0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
dakinola 8771dfe3dd Force calculator to launch in fullscreen for taskbar tests
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
2024-04-22 21:42:09 +00:00
Federico Baron e419495cc9 Merge "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent" into main 2024-04-22 21:05:47 +00:00
Federico Baron 9a5bdb3b3f Merge "Add screenrecord to test with "Only System UI views are visible" message" into main 2024-04-22 20:28:27 +00:00
fbaron 3f58b471af Add screenrecord to test with "Only System UI views are visible" message
Flag: none
Test: TaplTestsTrackpad#switchToOverview
Bug: 335674307
Change-Id: Icabc13814163deaecaa14dd12bbd41f62074b4d5
2024-04-22 11:28:25 -07:00
fbaron 4f836430a7 Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent
Bug: 334946529
Test: TaplPrivateSpaceTest#testPrivateContainerIsPresent
Flag: none
Change-Id: I8f2d97c4d29d91389c3d20558ea6e3977deb322c
2024-04-22 09:58:53 -07:00
Treehugger Robot 774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Schneider Victor-tulias 3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Liran Binyamin 4d91e16589 Merge "Give bubble team owners on launcher bubble dirs" into main 2024-04-18 18:45:54 +00:00
Liran Binyamin b8ae441c10 Give bubble team owners on launcher bubble dirs
Flag: N/A
Test: treehugger
Bug: none
Change-Id: Ic5f69f34a1561ffb5a879a88b1532754e4b38f42
2024-04-18 12:18:21 -04:00
Liran Binyamin a7d2658d96 Merge "Update new bubble animation" into main 2024-04-18 15:51:39 +00:00
Eghosa Ewansiha-Vlachavas f6ea0a3a2b Merge "Gate new desktop task menu button with device config check" into main 2024-04-18 15:02:52 +00:00
Eghosa Ewansiha-Vlachavas e885e54d90 Gate new desktop task menu button with device config check
Desktop windowing is enabled only when the desktop windowing flag is
enabled and the device is supported through setting a device config
flag. Add this device config check to the desktop task menu button so it
does not appear if the device is not compatible.

Flag: NONE
Fixes: 335178869
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: Ia2559c1ff57bb7921867e69a47d868c03eae57e7
2024-04-18 11:47:55 +00:00
Treehugger Robot d955d23028 Merge "Fix KQS first task focux when there is only one recent task" into main 2024-04-16 20:53:34 +00:00
Schneider Victor-tulias 3b6e45d095 Fix KQS first task focux when there is only one recent task
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 335257398
Test: TaplTestsKeyboardQuickSwitch#testLaunchSingleRecentTask
Change-Id: Ibf1514394c29c33ea1dde9e3704af231e2d039f2
2024-04-16 15:08:31 -04:00
Federico Baron 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
fbaron e4b0b71faa Make hotseat column span responsive
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
2024-04-16 06:19:16 +00:00
Jagrut Desai 7a6036516c Merge "Remove PortraitLandscape from the TaplTestsTransientTaskbar" into main 2024-04-15 18:51:18 +00:00
Vadim Tryshev bb760dbbbd Merge "Promote goToOverviewFromApp to presubmit" into main 2024-04-13 01:12:04 +00:00
Vadim Tryshev a46a55ed05 Promote goToOverviewFromApp to presubmit
It's stable now:
https://android-build.corp.google.com/test_hub/search/?filter=&invfilter=unhealthyInvocations&invfilter=staleInvocations&tab=tests&query=branch%3agit_main%20target%3a%28cf_x86_64_phone-trunk_staging-userdebug%7ccf_x86_64_tablet-trunk_staging-userdebug%7ccf_x86_64_foldable-trunk_staging-userdebug%29%20config%3a%28v2%2fgnl-eng%2funbundled%2flauncher%2fnexus_unit_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2fnexus_oop_test_multi_device_platform%7cv2%2fgnl-eng%2funbundled%2flauncher%2flauncher3_test_platform%29%20test%3a%22com.android.quickstep.FallbackRecentsTest%23goToOverviewFromApp%22

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I9c8777b976e2683aecdfa7f97950dee4c5661a11
2024-04-11 20:14:07 +00:00
Jagrut Desai b625c2345a Remove PortraitLandscape from the TaplTestsTransientTaskbar
Test: Presubmit
Bug: 321083190
Flag: NONE
Change-Id: Ida1d902452280a9c161edbc63b1a0b9a4aad2e3f
2024-04-11 11:21:39 -07:00
Randy Pfohl c21b0000b5 Revert^2 "fixing tests to match new abstraction"
8e4c0b7afb

Change-Id: I9875d6f9c16f1406d0818164a98e790c2b101650
2024-04-11 08:58:22 -07:00
Randy Pfohl 819b835519 Revert "Revert "abtracting Activity from recentsView through rec..."
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Reason for revert: Fix for issue has been found and will be included in this revert.

Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
2024-04-11 08:58:08 -07:00
Liran Binyamin e79120af38 Update new bubble animation
This change is a rewrite of the new bubble animation. Previously we chained the handle animation and the bubble animation so that they run sequentially.
That caused the transition from the handle to the bubble to be jarring.

We now use a single spring animation along the y axis that starts from the position of the handle to the position of where the bubble will end up.
The animation is split into 3 logical parts, where initially the bubble animates out, then the bubble starts animating in, and the last part is the overshoot of the spring animation, which is used to mark the bubble fully visible and ensure that from that point on, the bubble is only moving but doesn't change in scale or transparency as the bounce effect is playing.
Using a single animation path allows for a smooth transition from the handle to the bubble view.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hHNUBdNJPiWi9gMbqy45UJ

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic1d3244574b8500d4aad2e9c718e61c1c34bd82a
2024-04-11 11:51:10 -04:00
Priyanka Advani 3c71346147 Revert "abtracting Activity from recentsView through recentsview..."
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
2024-04-10 21:31:07 +00:00
Priyanka Advani 8e4c0b7afb Revert "fixing tests to match new abstraction"
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
2024-04-10 21:31:14 +00:00
randypfohl f75709e78b fixing tests to match new abstraction
This change will let us move from activity to other parent views for recent viewss

Change-Id: I2424d94f799f87b2d2262da96b289aac6dfadee9
2024-04-10 09:14:38 -07:00
randypfohl 547d6fc472 abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
This change will let us move from activity to other parent views for recent views.

Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.

Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.

Bug: 292269949

Flag: NONE

Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
2024-04-10 09:14:28 -07:00
Himanshu Gupta 6c089d7ac1 Merge "Adding TAPL tests for Private Space in Quickstep." into main 2024-04-09 21:12:09 +00:00
Alex Chau 55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Himanshu Gupta 0d400993a9 Adding TAPL tests for Private Space in Quickstep.
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.

More tests will be followed in next CL.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
2024-04-09 20:30:31 +01:00
Vadim Tryshev 6ae89d13ff Merge "Re-enabling stress tests in presubmit" into main 2024-04-09 16:26:17 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Uwais Ashraf fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Jordan Silva 65972d5ba4 Merge "Update save app pair test to validate when icon chip menu is disabled" into main 2024-04-08 22:08:49 +00:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Jordan Silva a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Liran Binyamin 98bbc2b46d Merge "Animate the stash handle for new bubbles" into main 2024-04-05 00:49:39 +00:00
Liran Binyamin 597ced3033 Animate the stash handle for new bubbles
The stash handle now animates out before the new bubble animates in, and animates back in after the new bubble is hidden.
There's still some additional polish needed :)

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/z30Ob1rcDUkNEphLAQsgV

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I03449286b01ec96de9834e24a707652ddbe49fb0
2024-04-04 14:26:08 -04:00
Treehugger Robot 5c8241b421 Merge "Update the WidgetPickerActivity to display recommendations for hub host" into main 2024-04-04 14:36:56 +00:00
Eghosa Ewansiha-Vlachavas 7d09d5543e Merge "Fix launcher activity leaking when desktop windowing enabled" into main 2024-04-04 06:47:03 +00:00
Holly Jiuyu Sun a0f2598840 Merge "Downgrade Test to PostSubmit" into main 2024-04-04 02:55:53 +00:00
Jagrut Desai 0e32114847 Downgrade Test to PostSubmit
Test: Presubmit
Bug: 332663601
Bug: 332532966
Flag: NONE
Change-Id: I1baf598210e4f326ac1fb53662a10a4f4359a5e5
2024-04-03 16:44:33 -07:00
Eghosa Ewansiha-Vlachavas 43b731801b Fix launcher activity leaking when desktop windowing enabled
When desktop windowing is enabled we initiate the
`SplitFromDesktopController` within the `SplitSelectStateController`
which registers a `SplitSelectListener` on the launcher instance.
However when we destroy the `SplitSelectStateController` the
`SplitFromDesktopController` is not destroyed an thus any listeners are
not unregisterd. Instead we should explicitly destroy the
`SplitFromDesktopController` by unregistering listener.

Flag: NONE
Fixes: 332667403
Bug: 331774319
Test: atest -c NexusLauncherTests:com.android.quickstep.TaplStartLauncherViaGestureTests
atest -c NexusLauncherTests:com.android.quickstep.util.SplitSelectStateControllerTest

Change-Id: I68ffcc4114644e75f751632eca8bc73e406139a8
2024-04-03 22:04:06 +00:00
Vadim Tryshev 1c8354543a Re-enabling stress tests in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I466ffb58fbd3bf5e7b3e0fc186aed12f75019e23
2024-04-01 17:52:50 -07:00
Shamali P 7ae51788da Update the WidgetPickerActivity to display recommendations for hub host
- Accepts a ui_surface param of format "widgets{_hub}" and existing
widgets on the surface to be excluded from predictions
- Refactored the widgets prediction update task to extract reusable
logic that maps the predictions to widget items and reused it.

http://screencast/cast/NjE1MTA5MDI0NzU2NTMxMnwzMGE3NTMwNi1hZg

Bug: 326092660
Test: WidgetsPredictionHelperTest and see screencast above.
Flag: N/A
Change-Id: I6ceeb752c167893bab4ed496cedc5e8081e1b950
2024-04-01 20:16:37 +00:00
Liran Binyamin 074a3a66b0 Initial animation of new bubble bar bubble
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
2024-03-28 11:30:56 -04:00