Commit Graph

658 Commits

Author SHA1 Message Date
Alex Chau 6bad4d8877 Merge "Logging for drop bar not appearing for dragged widget" into sc-v2-dev 2021-09-02 09:35:13 +00:00
vadimt 89d9423321 Logging for drop bar not appearing for dragged widget
Test: presubmit
Bug: 195031154
Change-Id: I19494fc3d6d9db252570697c057fdee7f7d44521
2021-09-01 12:33:00 -07:00
Sunny Goyal 777d49062f Revert "Revert "Migrating all model tests to Instrumentation tests""
This reverts commit 7a4a30d86d.

Test: Presubmit
Reason for revert: Fixing original bug

Bug: 196825541
Change-Id: Id4b1eb24a89564d264266d305aebea52917dfcd9
2021-08-31 10:51:52 +00:00
Alex Chau 204e749f06 Merge "Revert "Migrating all model tests to Instrumentation tests"" into sc-v2-dev 2021-08-24 17:29:06 +00:00
Alex Chau 7a4a30d86d Revert "Migrating all model tests to Instrumentation tests"
This reverts commit 455ba62b5d.

Reason for revert: Breaks tests on all targets

Bug: 196825541
Bug: 197570389
Change-Id: Ida6792a09c54dee46105b6b914a0dd1545bdf48d
2021-08-24 17:27:52 +00:00
TreeHugger Robot c817d2a633 Merge "Migrating all model tests to Instrumentation tests" into sc-v2-dev 2021-08-23 21:08:51 +00:00
Sunny Goyal 455ba62b5d Migrating all model tests to Instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Iebd46eb41eb46c187d569197f4b97b4fddc0f6f7
2021-08-23 12:34:44 -07:00
Sunny Goyal 8e3a60648a Fixing crash when the adapter is no longer available
Bug: 197176748
Test: trivial change
Change-Id: Ie55a248c1998168c45bfa346186d61d7456ff7fb
2021-08-19 10:26:35 -07:00
Sunny Goyal 177785eccf Moving all widget picker tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I946f29baedb2e6b29044f8df1bc73b74e9999efe
2021-08-18 15:06:53 -07:00
Sunny Goyal ed2a55f413 Removing widget preview caching
> All previews are generated on demand when the corresponding
  header expands
> Using ItemAnimator to animate layout changes when preview loads

Bug: 196238313
Test: Manual
Change-Id: I0cb859c8443c2c536399e4063f58baecfc7416ad
2021-08-17 17:50:30 -07:00
Sunny Goyal 48b012b148 Merge "Fixing header jump" into sc-v2-dev 2021-08-16 18:20:00 +00:00
Sunny Goyal 77acf12905 Fixing header jump
Linking header position to an empty entry in the recyclerView,
instead of calculating the vertical scroll position. This
allows the header to be in sync with the recyclerView scroll and
item animations

Other simplifications:
> Moving top collapse handle out of header view (it doesn't scroll)
> Removing background clipping logic from full-sheet
> Moving tab bar inside the header view

Bug: 196464142
Test: Verified on device
Change-Id: Iae5a0ae9af7ce258e1b391b8e85c5c270fe56197
2021-08-16 09:45:14 -07:00
Steven Ng 749f8c54cd Fix pending restore widget touch issue am: bdffb53843 am: 8facf46000
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517689

Change-Id: I4ce17b8b2c3ac35d7cecc58813e148784869fda9
2021-08-11 23:58:04 +00:00
Steven Ng b014e9098b Merge "Preview layout scaling for RemoteViews preview" into sc-v2-dev 2021-08-11 21:59:45 +00:00
Steven Ng bdffb53843 Fix pending restore widget touch issue
After http://ag/14980850, we block updateAppWidget until app widget
is restored. However, PendingAppWidgetHostView constructor relies
on updateAppWidget(null) to trigger set listener in getDefaultView().
We should call super.updateAppWidget(null) in the constructor instead.

Test: manual
Bug: 14980850
Change-Id: I30af9778a636af2ad822e7abc152b6f0bfdea1bf
2021-08-11 22:40:06 +01:00
Nick Chameyev 02c0c924a6 Merge "Add unfold animation to launcher icons and widgets" into sc-v2-dev 2021-08-11 18:04:03 +00:00
Steven Ng f64b08dcb9 Preview layout scaling for RemoteViews preview
RemoteViews may contain multiple layouts. The best fit layout is
picked after layout. Let's ensure the best fit layout is picked
before scaling a preview

Test: Manual
Fix: 196044656
Change-Id: I41b9f70040befaf96a9af95f9399a816eb0b71cb
2021-08-11 16:37:58 +01:00
Nick Chameyev 5e8dbe77e8 Add unfold animation to launcher icons and widgets
Adds unfold animation to launcher which translates
icons and widgets from the center to the sides on
foldable devices.

Bug: 193794541
Test: manual
Change-Id: I9d6e018a0451d342f02dddea47bc180781c31d43
2021-08-11 16:10:18 +01:00
Steven Ng caf2e5f350 Use target size to scale down a widget preview image
WidgetCells are being recycled in WidgetFullSheet. getWidth/getHeight
could be a recycled dimension. There is also no guarantee that measure
has taken placed before the scale down logic. Let's use the targeted
width for the scale down logic instead.

Test: Manual
Fix: 195417705
Change-Id: Idfb3cc485604d19658e210709bebde6f163003cf
2021-08-10 18:18:11 +01:00
Steven Ng 3edfa98ba7 Use the right content to estimate the span in WidgetsFullSheet
Test: Manual
Fix: 194784402
Change-Id: I150f4c7b5a0344caa2bea3f1502894cb0f32e208
2021-07-30 13:15:26 +01:00
Sunny Goyal 69a8eecdc9 Simplifying color extraction registration logic
> Calulating correct location irrespective of transient
  state (scale/translation)
> Removing extraction pause/resume logic
> Simplifying location calculation and registration (only use one location instead of a list)

Bug: 194732483
Test: Manual
Change-Id: I255d83761bff5e09c9fb0a5e398d0be0c1d0956f
2021-07-28 15:43:13 -07:00
Steven Ng 522c1506f1 Do not allow add view in DeferredAppWidgetHostView
Also set rounded corners to DeferredAppWidgetHostView

Test: manual
Fix: 193885118
Change-Id: I663b5b4a50da1f2348be1792923ee73fe8e6a2e8
2021-07-27 17:11:35 +01:00
Steven Ng 24c16de329 Use 32dp as the content margin for widgets pickers in large screen
devices

Test: manual
Bug: 194369046
Change-Id: I7376eab59d57bdd9ccc8a64e9f321358e09ee579
2021-07-27 12:00:52 +01:00
TreeHugger Robot c48e4fa64d Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: I0004e2f55347e018fa553f8b56c26a754a93e0f1
2021-07-22 19:11:55 +00:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
Steven Ng 2b90d043f6 Fix scaling on widget previews that have width / height set to
wrap_content

If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.

Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Brian Isganitis b684c1b59b Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"
This reverts commit 7de95d6767, reversing
changes made to 0a70a5a690.

Lints have been added to fix errorprone.

Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: I6866f8521ed427d096f27da0a92d8b40e1099187
2021-07-19 21:03:26 -04:00
Jonathan Miranda 7de95d6767 Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev 2021-07-20 00:45:57 +00:00
Jonathan Miranda f5fee1a7d3 Revert "Use wallpaper colors for widgets in wallpaper change preview"
Revert "Implement generateColorsOverride from LocalColorExtractor"

Revert submission 15331418-colorcp

Reason for revert: Broke the build
Reverted Changes:
Ife80b07f9:Use wallpaper colors for widgets in wallpaper chan...
I1371eb787:Implement generateColorsOverride from LocalColorEx...

Bug: 194138049

// Using original change's merged-in tag to avoid clashing
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586

Change-Id: I3835dfb8efe745dc0a654712a5b1f68c4946f446
2021-07-20 00:44:42 +00:00
TreeHugger Robot 0a70a5a690 Merge "Remove the shadow under PendingAppWidgetHostView." into sc-dev 2021-07-20 00:25:48 +00:00
Pierre Barbier de Reuille a28f864bbf Remove the shadow under PendingAppWidgetHostView.
Fix: 194007734
Test: Manual (see bug)
Change-Id: Ia46dbf8417bb9df17f35b43bfa2698206d940587
2021-07-19 22:21:06 +00:00
Pierre Barbier de Reuille 771c60d36e Remove the shadow under PendingAppWidgetHostView.
Fix: 194007734
Test: Manual (see bug)
Change-Id: Ia46dbf8417bb9df17f35b43bfa2698206d940587
2021-07-19 22:55:49 +01:00
Brian Isganitis 74e6ced362 Use wallpaper colors for widgets in wallpaper change preview
Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: Ife80b07f99da913d65bff96fba2ccd76b0a2ed48
2021-07-19 16:58:20 -04:00
Steven Ng 4f0f5d732d Fix widget cell container size
This was the same calculation used before http://ag/15177218.

Test: run AddWidgetTest, AddConfigWidgetTest
Bug: 193819550
Change-Id: I1b5e0072a4c05b656de98f8d42667ae99438c005
2021-07-16 12:43:55 +01:00
Steven Ng 4083ae30db Merge "Scale RemoteViews from requestPinAppWidget shown in AddItemActivity" into sc-v2-dev 2021-07-16 09:24:02 +00:00
Steven Ng 02c75d9897 Fix class cast issue in AddItemActivity am: 671ffb88ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: I393d4540df0b32e644e3d1a963db14564281c03c
2021-07-16 02:04:23 +00:00
Steven Ng 2b123833ad Scale RemoteViews from requestPinAppWidget shown in AddItemActivity
Test: manual
Bug: 193144010

Change-Id: Ia2b64c32f92a43a8d71ee82f164543e1e624814a
2021-07-15 17:59:45 +01:00
Steven Ng 671ffb88ca Fix class cast issue in AddItemActivity
AddItemActivity is a standalone activity. There is no Launcher activity
instance. Avoid using LauncherAppWidgetHostView in WidgetCell by
replacing it NavigableAppWidgetHostView instead

Test: Check preview layouts are correctly rendered in widgets picker
      and pin widget dialog. Also test drag and drop to verify the
      local color extraction still works when dragging a preview layout
      from widgets picker to home screen.
Fix: 193765783
Change-Id: I3a734a54941257cebcd7b7f6a4c2c9cc764c5c12
2021-07-15 16:06:51 +01:00
Steven Ng f3d23f67bd Scale widget previews
This CL covers drag requests initiated from Launcher.java but not from
other activities.

Test: Manual
Bug: 193144010
Change-Id: Ieb862d689afe81a5b35aedeb9a277de08c775230
2021-07-15 12:22:37 +01:00
Steven Ng 16c9ebabbf Merge "Fix shortcut size calcuation" into sc-dev am: 372e85106d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15259646

Change-Id: I5b37dc1971d67afbc3923774db2256459e389ae6
2021-07-13 14:10:25 +00:00
Steven Ng 372e85106d Merge "Fix shortcut size calcuation" into sc-dev 2021-07-13 13:59:41 +00:00
Steven Ng 6fe115b2ae Fix shortcut size calcuation
Shortcut size should be the size of all apps icon + padding

Test: Check shortcuts and widgets are shown without crash in the
      following surfaces with display & font set to largest and
      display cutout enabled. Repeat the same test with normal
      display setting and no cutout.
      1. Full widgets picker
      2. Bottom widgets picker
      3. Pin widget dialog
Fix: 193422438
Change-Id: Ibfebf94e92eed5e9cd1dd4196d98823b0e4dda6b
2021-07-13 12:46:31 +01:00
Steven Ng fbb82586a7 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
(cherry picked from commit 3d27207ff6)
2021-07-12 10:29:56 +00:00
Steven Ng ac21df2246 Merge "Clear WidgetCell#mItem before recylcing a WidgetCell" into sc-v2-dev 2021-07-09 22:16:03 +00:00
Steven Ng 3d27207ff6 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
2021-07-09 17:45:19 +01:00
Steven Ng 12b2742780 Merge "Restricts the width of pin widget dialog to 89% on large screen devices" into sc-v2-dev 2021-07-09 09:38:33 +00:00
Steven Ng 3572c9100a Merge "Wrap the widget preview of the add item sheet with a scroll view" into sc-v2-dev 2021-07-09 09:00:31 +00:00
Steven Ng 1afca4dce5 Wrap the widget preview of the add item sheet with a scroll view
Test: manual
Fix: 192622015
Change-Id: I1eb676a92201970962c71194682ea70ce42b3d1b
2021-07-08 22:22:17 +01:00
Steven Ng 452e8b8512 Correct # of cells estimation that can fit horizontally in widgets
picker

Fix: 192661517
Test: check widgets are fit correctly in both full & bottom widgets
      picker in portrait and landscape in different grid settings.
Change-Id: Ic1b0589b7ccf62ff1ec1fd5713b4249ba58246a5
2021-07-08 16:23:38 +01:00