Commit Graph

13761 Commits

Author SHA1 Message Date
Brian Isganitis fd21f4e200 Merge changes from topic "options-popup-dialog-type" into tm-mainline-prod am: 605b29d607
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17647857

Change-Id: Iee76510fca5ffc26716c33d1a609aab6ca87b67f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-08 18:11:01 +00:00
Brian Isganitis 605b29d607 Merge changes from topic "options-popup-dialog-type" into tm-mainline-prod
* changes:
  [automerge] Add separate AFV type for options popup dialog. 2p: 7ef4fe42cb
  Add separate AFV type for options popup dialog.
2022-04-08 17:46:07 +00:00
Luca Zuccarini 7d0323c446 Merge changes from topic "toast-polish" into tm-mainline-prod
* changes:
  [automerge] [Toast] Polish the layout of the QSB, tabs and header protection. 2p: a5e95419f5
  [Toast] Polish the layout of the QSB, tabs and header protection.
2022-04-08 17:21:32 +00:00
Luca Zuccarini 72c94f41a8 Merge changes from topic "toast-polish"
* changes:
  [automerge] [Toast] Polish the layout of the QSB, tabs and header protection. 2p: a5e95419f5 2p: e25113ead8
  [automerge] [Toast] Polish the layout of the QSB, tabs and header protection. 2p: a5e95419f5
  [Toast] Polish the layout of the QSB, tabs and header protection.
2022-04-08 17:21:32 +00:00
Stefan Andonian 2b4edef43e Merge changes from topic "presubmit-am-d0781e1f1b78407a92b2f064380bea1a" into tm-mainline-prod am: 63035a3624
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17643134

Change-Id: Ia1001059df211db03a92f3070ec71421e245dd05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-08 16:29:48 +00:00
Brian Isganitis 0cdfc0aefc [automerge] Add separate AFV type for options popup dialog. 2p: 7ef4fe42cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17647857

Bug: 227142635
Change-Id: I05aa82f92df0aa437332cfcfae6f04d35a155ac1
2022-04-07 23:34:37 +00:00
Brian Isganitis 7ef4fe42cb Add separate AFV type for options popup dialog.
Now that we close all non rebind safe AFVs onResume, the options popup dialog is getting closed. This dialog is rebind safe, but currently using TYPE_OPTIONS_POPUP which isn't.

Test: Dialog stays open on activity recreate. Also ran affected tests.
Bug: 227142635
Change-Id: Ibbac925ce5dd2de5c7770cb8f5bd8c5e438449cf
2022-04-07 16:29:44 -07:00
Presubmit Automerger Backend 11c80a00eb [automerge] Simplify AbstractFloatingView.closeOpenViews usage. 2p: d123fbd15d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17643134

Bug: 227142635
Change-Id: Id992a5babbfa8ecfd7d8d3d4afb18fdbc6edee84
2022-04-07 22:20:19 +00:00
Stefan Andonian d123fbd15d Simplify AbstractFloatingView.closeOpenViews usage.
This is a follow-up code review to ag/1754638 to address a comment that was missed before the CR was pushed.

Bug: 227142635
Test: Folders still close when launcher is paused.
Change-Id: Ib6724dc3a6ba49e259ba7de655f6810d6a692d16
2022-04-07 22:19:26 +00:00
Sebastián Franco f0174a08ed Merge changes from topic "presubmit-am-8c3e4ee583d84fa79ee76ef359ea36f2" into tm-mainline-prod
* changes:
  [automerge] Make the text for the drop target buttons fit if it's too long. 2p: d2d8e97a65
  Make the text for the drop target buttons fit if it's too long.
2022-04-07 22:14:07 +00:00
Sebastián Franco 10ca22d096 Merge changes from topic "presubmit-am-8c3e4ee583d84fa79ee76ef359ea36f2"
* changes:
  [automerge] Make the text for the drop target buttons fit if it's too long. 2p: d2d8e97a65 2p: 080bd76ccd
  [automerge] Make the text for the drop target buttons fit if it's too long. 2p: d2d8e97a65
  Make the text for the drop target buttons fit if it's too long.
2022-04-07 22:14:07 +00:00
TreeHugger Robot baf4c707ac Merge changes from topic "presubmit-am-ef022b9359c54a67bdf5fa122cdf9375" into tm-mainline-prod
* changes:
  [automerge] Removing line submited by mistake. 2p: dac0769af1
  Removing line submited by mistake.
2022-04-07 21:57:05 +00:00
TreeHugger Robot 4acf9984f7 Merge changes from topic "presubmit-am-ef022b9359c54a67bdf5fa122cdf9375"
* changes:
  [automerge] Removing line submited by mistake. 2p: dac0769af1 2p: 1e1bcb19cb
  [automerge] Removing line submited by mistake. 2p: dac0769af1
  Removing line submited by mistake.
2022-04-07 21:57:05 +00:00
Sebastián Franco 38ae9cfb0f Merge changes from topic "presubmit-am-1bfe19c9d385472a8e3256e5e61c3ade" into tm-mainline-prod
* changes:
  [automerge] Make the widget option on the PopupContainer full width 2p: dfa88d55f5
  Make the widget option on the PopupContainer full width
2022-04-07 21:49:35 +00:00
Sebastián Franco fb9c2942e8 Merge changes from topic "presubmit-am-1bfe19c9d385472a8e3256e5e61c3ade"
* changes:
  [automerge] Make the widget option on the PopupContainer full width 2p: dfa88d55f5 2p: 001367675e
  [automerge] Make the widget option on the PopupContainer full width 2p: dfa88d55f5
  Make the widget option on the PopupContainer full width
2022-04-07 21:49:35 +00:00
Schneider Victor-tulias 2ff0a66b8e Merge "Add logging to debug incorrect taskbar states caught by flaky tests." into tm-dev 2022-04-07 21:05:39 +00:00
Schneider Victor-tulias 408e8b0677 Merge changes from topic "presubmit-am-279fa1f70f1d497281418aa4023f3fdc" into tm-mainline-prod
* changes:
  [automerge] Add logging to debug incorrect taskbar states caught by flaky tests. 2p: 1823bdba6e
  Add logging to debug incorrect taskbar states caught by flaky tests.
2022-04-07 21:05:39 +00:00
Schneider Victor-tulias 1abab5be55 Merge changes from topic "presubmit-am-279fa1f70f1d497281418aa4023f3fdc"
* changes:
  [automerge] Add logging to debug incorrect taskbar states caught by flaky tests. 2p: 1823bdba6e 2p: 977f8873f3
  [automerge] Add logging to debug incorrect taskbar states caught by flaky tests. 2p: 1823bdba6e
  Add logging to debug incorrect taskbar states caught by flaky tests.
2022-04-07 21:05:39 +00:00
Stefan Andonian 52eaebead4 Merge "Close open folders when pausing launcher." into tm-dev 2022-04-07 18:53:45 +00:00
Stefan Andonian c09f3bc17c Merge changes from topic "presubmit-am-53b0d3f55ee24fb6807e6ffd6c335979" into tm-mainline-prod
* changes:
  [automerge] Close open folders when pausing launcher. 2p: 253c23b2e8
  Close open folders when pausing launcher.
2022-04-07 18:53:45 +00:00
Stefan Andonian 2da656ee8b Merge changes from topic "presubmit-am-53b0d3f55ee24fb6807e6ffd6c335979"
* changes:
  [automerge] Close open folders when pausing launcher. 2p: 253c23b2e8 2p: 1e72f48c3e
  [automerge] Close open folders when pausing launcher. 2p: 253c23b2e8
  Close open folders when pausing launcher.
2022-04-07 18:53:45 +00:00
Presubmit Automerger Backend e7e36c8e01 [automerge] Make the widget option on the PopupContainer full width 2p: dfa88d55f5 2p: 001367675e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17592804

Change-Id: Ied2ef782b56b31a6e700b4d94347492d7427ddb7
2022-04-07 17:00:51 +00:00
Sebastian Franco dfa88d55f5 Make the widget option on the PopupContainer full width
The width of the PopupContainer grows if there are multiple
SystemShortcuts and we where not updating the width of all the
options.

Fix: 227538975
Test: Long press an app like Google Maps on the HomeScreen to see
the menu. All the options should have the same width.

Change-Id: I25310d74aa1af17be37b53c27d2334f86bef325a
2022-04-07 10:00:30 -07:00
Luca Zuccarini f7a62a8490 [automerge] [Toast] Polish the layout of the QSB, tabs and header protection. 2p: a5e95419f5 2p: e25113ead8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17636491

Change-Id: I1c803698c84c3917e11feb104d99e1e1ad3ceaca
2022-04-07 16:56:27 +00:00
Luca Zuccarini e25113ead8 [automerge] [Toast] Polish the layout of the QSB, tabs and header protection. 2p: a5e95419f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17636491

Change-Id: I120b086eec433e929078800825ecd6b7793ded41
2022-04-07 16:56:19 +00:00
Luca Zuccarini a5e95419f5 [Toast] Polish the layout of the QSB, tabs and header protection.
Specs and screenshot in the bug.

Fixes: b/227902759
Test: manual
Change-Id: Ia713c923a71207cfaab7068f20c8606d816f8b43
2022-04-07 16:53:53 +00:00
Presubmit Automerger Backend 4e6b8cfcf5 [automerge] Make the text for the drop target buttons fit if it's too long. 2p: d2d8e97a65 2p: 080bd76ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17454967

Change-Id: I64c463eaa8338e068aed174ea1a90e0db194d93a
2022-04-07 16:39:50 +00:00
Sebastian Franco d2d8e97a65 Make the text for the drop target buttons fit if it's too long.
The text "Don't suggest app" is too long when the device language
is GE or JA, or if you make the text bigger in settings.

Before truncating the text completely we are going to try to make
the text smaller until it gets to a predefined value
(button_drop_target_min_text_size).

Test: Change the language to German (Deutch) and install a new app and drag it to the workspace to see the button "App nicht vorschlagen"
Test: Also, a nice way to test is to go to SecondaryDropTarget#setupUi and hardcode the option to always show "Don't suggest app"
Fix: 221480721
Change-Id: I99def4e23cd17109a297aecaa620cef7a0d137e7
2022-04-07 16:39:29 +00:00
TreeHugger Robot 0e508ba727 Merge changes from topic "presubmit-am-6e7b87d8c6594f9d9d7fb9f70b2a9861"
* changes:
  [automerge] Clone mInsets when copying DeviceProfile to taskbar 2p: e0227551cf 2p: 3d3b263bf0
  [automerge] Clone mInsets when copying DeviceProfile to taskbar 2p: e0227551cf
  Clone mInsets when copying DeviceProfile to taskbar
2022-04-07 13:44:14 +00:00
TreeHugger Robot 5118c966b6 Merge changes from topic "presubmit-am-6e7b87d8c6594f9d9d7fb9f70b2a9861" into tm-mainline-prod
* changes:
  [automerge] Clone mInsets when copying DeviceProfile to taskbar 2p: e0227551cf
  Clone mInsets when copying DeviceProfile to taskbar
2022-04-07 13:44:14 +00:00
TreeHugger Robot 833c210550 Merge "Clone mInsets when copying DeviceProfile to taskbar" into tm-dev 2022-04-07 13:44:14 +00:00
Alex Chau 9e9dd8fa43 Merge "Make AllApps bottom sheet follow finger and snap after 30% progress" into tm-dev 2022-04-07 09:50:04 +00:00
Alex Chau ca23104490 Merge changes from topic "presubmit-am-91d9a2708d3b405695b3a3a0998b8f6e" into tm-mainline-prod
* changes:
  [automerge] Make AllApps bottom sheet follow finger and snap after 30% progress 2p: c83ea5f8fb
  Make AllApps bottom sheet follow finger and snap after 30% progress
2022-04-07 09:50:04 +00:00
Alex Chau 51bf7af3df Merge changes from topic "presubmit-am-91d9a2708d3b405695b3a3a0998b8f6e"
* changes:
  [automerge] Make AllApps bottom sheet follow finger and snap after 30% progress 2p: c83ea5f8fb 2p: 49520d892d
  [automerge] Make AllApps bottom sheet follow finger and snap after 30% progress 2p: c83ea5f8fb
  Make AllApps bottom sheet follow finger and snap after 30% progress
2022-04-07 09:50:04 +00:00
TreeHugger Robot c0c1276197 Merge changes from topic "presubmit-am-d97629e947434fe09a62af1bca34a360" into tm-mainline-prod am: 7cc9dcf664
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17610880

Change-Id: Ide8fd1d4ebe9b8abc8261ce5bdd24fc922f4fd5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-07 03:54:44 +00:00
TreeHugger Robot e633cca3bc Merge "Adding finish signal to GestureNavContract." into tm-dev 2022-04-07 03:24:01 +00:00
TreeHugger Robot 7cc9dcf664 Merge changes from topic "presubmit-am-d97629e947434fe09a62af1bca34a360" into tm-mainline-prod
* changes:
  [automerge] Adding finish signal to GestureNavContract. 2p: 5c20fdd73f
  Adding finish signal to GestureNavContract.
2022-04-07 03:24:01 +00:00
Thiru Ramasamy aa49200100 Merge "Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event." into tm-dev 2022-04-07 01:07:28 +00:00
Sebastian Franco 4192306aba [automerge] Removing line submited by mistake. 2p: dac0769af1 2p: 1e1bcb19cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624450

Change-Id: Ic83fb32d6f3c3136c2d9efbc490fbf0e04fd8e01
2022-04-06 22:28:27 +00:00
Sebastian Franco 1e1bcb19cb [automerge] Removing line submited by mistake. 2p: dac0769af1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624450

Change-Id: I3350899e19b1cfc9f3b8fcff92bf5031e819fc76
2022-04-06 22:28:20 +00:00
Sebastian Franco dac0769af1 Removing line submited by mistake.
Fix: 228327426
Test: Click the Notification dots
Change-Id: I3712e07eee5d4e5194b86de4fa1d45e1ef511dae
2022-04-06 15:25:34 -07:00
Presubmit Automerger Backend a3b9aa55ff [automerge] Close open folders when pausing launcher. 2p: 253c23b2e8 2p: 1e72f48c3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17546438

Bug: 227142635
Change-Id: I11d7afaf476837350a9ceb4c5f4b2a81a38f6ff7
2022-04-06 21:47:56 +00:00
Stefan Andonian 253c23b2e8 Close open folders when pausing launcher.
Previously, folders wouldn't close after launching an app and quickly navigating back the launcher.
This is because the onStop state which contains a call to AbstractFloatingView.closeViews() wasn't being called.
This change adds an additional call to specifically close any open folders when the Launcher enters a paused state.

Bug: 227142635
Test: Verified that the issue is fixed after code change.
I logged the Launcher's lifecycle state to ensure my manual testing was reliable.

Change-Id: I838f992f83afdd754672ebbe85d0eb2a7e894417
2022-04-06 21:47:35 +00:00
Presubmit Automerger Backend 3d696ee841 [automerge] Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event. 2p: d66f433cde 2p: ea8d7ce46b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624833

Bug: 210792253
Change-Id: I4ccabfd43a260403c22c4a0833b782dd57ddbfc6
2022-04-06 21:33:02 +00:00
Presubmit Automerger Backend ea8d7ce46b [automerge] Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event. 2p: d66f433cde
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624833

Bug: 210792253
Change-Id: Ib59d79d10e3b745bb275439c435e5ca8edfd1578
2022-04-06 21:32:56 +00:00
Thiru Ramasamy d66f433cde Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event.
Test: Manual - wwdebug && wwlogcat - http://gpaste/5690465669087232
Bug: 210792253
Change-Id: Ibe0c762a9e40e1af85a4d18051ba2a74e9f6106a
2022-04-06 14:32:34 -07:00
Presubmit Automerger Backend 5d4c1490eb [automerge] Add logging to debug incorrect taskbar states caught by flaky tests. 2p: 1823bdba6e 2p: 977f8873f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624832

Bug: 227657604
Bug: 225205246
Change-Id: Iee994b293e1136d6b1ae6c315e1084836e9b9565
2022-04-06 21:29:24 +00:00
Presubmit Automerger Backend 977f8873f3 [automerge] Add logging to debug incorrect taskbar states caught by flaky tests. 2p: 1823bdba6e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17624832

Bug: 227657604
Bug: 225205246
Change-Id: I6f79835edd8495fc5b91dcabeb2e6b68b7ce52fa
2022-04-06 21:29:18 +00:00
Schneider Victor-tulias 1823bdba6e Add logging to debug incorrect taskbar states caught by flaky tests.
- Various TAPL tasts are flaking because the taskbar is present when navigating home. Several TAPL taskbar tests are also flaking because the taskbar is missing when opening an app. Adding logging to catch when FLAG_IN_APP is being set and why it isn't being applied.

Bug: 227657604
Bug: 225205246
Test: manual
Change-Id: Ia976bb0a6c7764e571fab3ac98ee21ff22ef7674
2022-04-06 14:26:47 -07:00
Presubmit Automerger Backend 3e6259671d [automerge] Adding finish signal to GestureNavContract. 2p: 5c20fdd73f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17610880

Bug: 228260232
Change-Id: Iaac9f45042aff84fab7232672cec522bacaac902
2022-04-06 20:43:30 +00:00