Commit Graph

20336 Commits

Author SHA1 Message Date
Tony Wickham fc267fbd69 Merge "Don't invalidate swipe handler until parallel anim finishes" into main 2024-10-07 19:17:03 +00:00
Liran Binyamin 9b093db2f8 Merge "Rename bubble bar flyout fields" into main 2024-10-07 18:27:14 +00:00
Fengjiang Li e79a786b3b Merge "[Dagger] Make WellbeingModel provided by DaggerSingletonObject" into main 2024-10-07 17:34:43 +00:00
Tony Wickham ee98cd4bdf Don't invalidate swipe handler until parallel anim finishes
- When invalidateHandler() is called, it calls endRunningWindowAnim()
  which includes mParallelRunningAnim. This causes a jump if
  mParallelRunningAnim was not already finished, so we now wait to
  invalidate the handler after mParallelRunningAnim ends.

Flag: EXEMPT bugfix
Test: AbsSwipeUpHandlerTestCase (added two tests for this)
Fixes: 370208192
Change-Id: I37ed281a993b1d2fa3634754378314511f3295f0
2024-10-07 16:45:19 +00:00
Liran Binyamin f44690bd69 Merge "Pass bubble flyout from wm shell to launcher" into main 2024-10-07 16:22:13 +00:00
Ats Jenk df819b6145 Merge changes Iccb870b0,Ibea2dbe0 into main
* changes:
  Inject bubble controllers directly
  Allow injecting bubble controllers in taskbar test
2024-10-07 16:12:41 +00:00
Liran Binyamin 75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Fengjiang Li 9a949ff4ca [Dagger] Make WellbeingModel provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Ie23411457185ab31380f3b0efb660e7dd9d73f29
2024-10-06 00:40:51 -07:00
Mykola Podolian 409b62cb33 Merge "3 button nav is laid out correctly." into main 2024-10-04 20:01:58 +00:00
Schneider Victor-tulias f36e9414b1 Merge "Add a AbsSwipeUpHandlerTestCase for the RecentsWindowSwipeHandler" into main 2024-10-04 19:53:01 +00:00
Vinay Joglekar b0354e7be9 Merge "Fix a bug where the running task would be drawn below recents task" into main 2024-10-04 18:25:58 +00:00
Matt Sziklay f843e5dd53 Merge "Add split instructions view to desktop split." into main 2024-10-04 18:00:36 +00:00
Schneider Victor-Tulias 12aff98cd8 Add a AbsSwipeUpHandlerTestCase for the RecentsWindowSwipeHandler
- Added RecentsWindowSwipeHandlerTestCase
- Slightly refactored AbsSwipeUpHandlerTestCase for simplicity

Flag: EXEMPT adding test code
Bug: 292269949
Test: RecentsWindowSwipeHandlerTestCase
Change-Id: Iacd8ff8261ad262d4645ba97c35d296050e61195
2024-10-04 13:37:01 -04:00
Vinay Joglekar ca94ef431f Merge "Fix a bug where the last large task index was not being set correctly." into main 2024-10-04 17:30:34 +00:00
Treehugger Robot 8f7dd208ba Merge "[NPE] Fix NPE of TaskInfo in FloatingWidgetView#getDefaultBackgroundColor" into main 2024-10-04 17:05:34 +00:00
Jordan Silva c407f1aa5a Fix a bug where the running task would be drawn below recents task
When the live tile is the adjacent app to be launched, it will wrongly update the pivot and translate all the tasks to the side, resulting in a broken animation.

This bug was introduced in ag/29639296, while fixing the launch of the the adjacent task while the live tile was in the center of the screen. To solve this excessive translation, we need to update pivot only when adjacent task is not a live tile.

Bug: 361744056
Change-Id: I56cbabcc351b0becd791b58dd94f65cd0b533bc2
Test: Launch central/side large tile with different live tile combinations
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
2024-10-04 07:55:25 +00:00
Jordan Silva 06dbdcea4e Fix a bug where the last large task index was not being set correctly.
This was causing the focused task shift to be calculated incorrectly, which was resulting in the focused task being shifted too far to the left.


Bug: 330342294
Fix: 371490320
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual. Open 1 DesktopTask, 1 FocusedTask, 2 other tasks in the grid. Dismiss the focused task. The rebalance should work keeping the new focused task next to desktop task.
Change-Id: If6f95814942c2cbadc30a0082649569f21dea60a
2024-10-04 07:28:42 +00:00
Treehugger Robot 5a90a5ab96 Merge "Fix for recents button quick switch with only focus and desktop task" into main 2024-10-04 05:05:37 +00:00
vinayjoglekar b6ac8b2ae9 Fix for recents button quick switch with only focus and desktop task
This CL also fixes : Home -> Recents -> Recents opens the last large tile (Which was broken when there is desktop window tile in recents.)

Test: Manual
BUG: 365756337
Fix: 365756337
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0b8fe3a0a7074355f14ced23ae282fe2943d8ce9
2024-10-03 18:58:48 -07:00
mpodolian 989aa8ac83 3 button nav is laid out correctly.
Updated logic of laying out the 3 nav buttons container. Also updated
placement of the hotseat, so it is not shifted on the phone.

Test: Manual. Fold and unfold felix with and without bubbles. Reboot
the devices and perform the same test.
Fixes: 370773620
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7d5ba51f7ded275f7456a8690d04001b9651f6c5
2024-10-03 16:57:58 -07:00
Ats Jenk 2f3d7b16c6 Merge "Apply bubble bar background alpha to stroke paint" into main 2024-10-03 20:20:08 +00:00
Ats Jenk 35b87d33b2 Inject bubble controllers directly
Replace injecting bubble controllers class with each controller
separately.c

Bug: 371017282
Test: TaskbarStashControllerTest
Flag: TEST_ONLY
Change-Id: Iccb870b0976b51fcd5a987cf208531da413921d1
2024-10-03 10:09:30 -07:00
Mady Mellor 2aedf52b8f Merge "If we're going to overview we might need to unstash" into main 2024-10-03 16:12:09 +00:00
Orhan Uysal 4acf699619 Merge "Fix overview animation after reboot." into main 2024-10-03 14:01:57 +00:00
Shamali Patwa b5c32d4c4f Merge "Add logs in ProxyActivityStarter when it fails to launch an activity" into main 2024-10-03 02:35:54 +00:00
Treehugger Robot 1bbcff3d48 Merge "Fix an issue where bubble bar would collapse when rotating" into main 2024-10-03 02:07:02 +00:00
Ats Jenk 936fec94bd Allow injecting bubble controllers in taskbar test
Update TaskbarUnitTestRule @InjectController annotation to support
injecting bubble controllers.
Bubble controllers are optional and only initialized if the feature flag
is enabled.
Add a test to check that bubble controllers are only initialized when
the flag is on.

Bug: 371017282
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Change-Id: Ibea2dbe0db854d530ef93ac53204a361572fa5b2
2024-10-02 15:56:08 -07:00
Shamali P 66b501eae2 Add logs in ProxyActivityStarter when it fails to launch an activity
Apparently, it doesn't log when it fails due to some reason.

In 369422714, we see it being started but the appwidget's config
 activity not being launched. The absorbed exception makes it harder to
  know. There isn't a system log as well.

  At least looking at logs, we think for some reason appwidget's
   configuration activity wasn't launched by launcher.

Bug: 369422714
Test: N/A logging
Flag: EXEMPT BUGFIX

Change-Id: I56294ef37d7ddceb61c4e6d0e10d0f24fde42cb2
2024-10-02 22:33:39 +00:00
Fengjiang Li a909cc2dd7 [NPE] Fix NPE of TaskInfo in FloatingWidgetView#getDefaultBackgroundColor
Fix: 370315165
Flag: NONE - prod crash
Test: presubmit
Change-Id: I50e71f0611fc9c664cfe51fbe9c3fc21462e10ed
2024-10-02 14:30:08 -07:00
Mady Mellor 3e8cc610b3 Fix an issue where bubble bar would collapse when rotating
When the device is rotated, everything gets recreated, in this case,
bubble bar state is typically set to be stashed. However, if taskbar
and bubble bar were unstashed while rotating, bubble bar would be
incorrectly stashed. To fix this, only do the stash if taskbar is
also stashed in this case.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - be in an app, unstash bubbles, rotate device
             => observe that bubble bar is unstashed like taskbar
                after rotation
Bug: 353884121
Change-Id: Ia37397c62a1a6819c1bd42261f8a9955db511da3
2024-10-02 13:55:55 -07:00
Ats Jenk ad7a938268 Apply bubble bar background alpha to stroke paint
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.

Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
2024-10-02 10:20:06 -07:00
Liran Binyamin d8c3328d4d Pass bubble flyout from wm shell to launcher
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Change-Id: I8666765937a491903c6fc042d2d629374be4c70d
2024-10-02 12:27:52 -04:00
Liran Binyamin 1663bb3004 Merge "Bubble bar flyout polish" into main 2024-10-02 16:15:53 +00:00
Treehugger Robot d8daf184bc Merge "Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into main 2024-10-02 15:55:45 +00:00
Schneider Victor-Tulias 9240b68dd6 Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Flag: EXEMPT bug fix
Fixes: 369359244
Test: performance testing
Change-Id: Id70c4b02738fd1abd62027fcddd0fac3c99fe95e
2024-10-02 14:15:56 +00:00
Bill Yi bf752db081 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-02 05:37:39 +00:00
Treehugger Robot 5c3e15b0e0 Merge "Fix small bug with TaskView tile expansion" into main 2024-10-02 02:13:04 +00:00
Treehugger Robot b4b2d16bcc Merge "Fix translation when focused task or desktop task is dismissed. (3/4)" into main 2024-10-02 00:38:10 +00:00
Treehugger Robot 6d763a301c Merge "Fix Taskbar unlock transition" into main 2024-10-02 00:14:04 +00:00
Treehugger Robot da290bcacf Merge "Make large task tile snap to position after scrolling" into main 2024-10-01 23:01:37 +00:00
Treehugger Robot ff97ec0d22 Merge "Fix comment in TransientBubbleStashControllerTest" into main 2024-10-01 22:38:17 +00:00
Kevin Lim adac5834e3 Merge "Use context#getDrawable instead of AppCompatResources#getDrawable to fix test failure." into main 2024-10-01 21:21:20 +00:00
Ats Jenk da477af93d Fix comment in TransientBubbleStashControllerTest
Bug: 345488489
Change-Id: Ide38c1e36a0da53e9fcc7a5c6b0c3241eff24add
Test: na
Flag: DOCS_ONLY
2024-10-01 21:06:02 +00:00
mattsziklay 2f3a57eb5d Add split instructions view to desktop split.
Fixes issues with desktop split caused by the instructions view not
being present. Makes desktop split select more uniform with other split select transitions.

Fix: 369961040
Fix: 370038890
Test: Manual
Flag: EXEMPT bug fix
Change-Id: Icfc6228f3e2692fda59ce5ab7c847ebe5314b25e
2024-10-01 21:02:17 +00:00
Tony Wickham 7519b7c2e6 Fix Taskbar unlock transition
- There are multiple signals that come just after FLAG_DEVICE_LOCKED
  is removed, and those should still be considered part of the unlock
  transition. We already did this for TaskbarStashController so I copied
  it to TaskbarLauncherStateController.
- Also animate when changing SYSUI_STATE_OVERVIEW_DISABLED, since this
  happens when the device is locked/unlocked and changes the visibility
  of TaskbarView icons.

Test: manually unlock over both home screen and in-app, verify clean
transition without jump (e.g. Hotseat is immediately visible as part of
Workspace, and Taskbar fades in during unlock to an app)
Flag: EXEMPT bug fix
Fixes: 364586744

Change-Id: If0497fcc17bb0ec44294c4ea1163104b4d8be459
2024-10-01 20:09:05 +00:00
Mady Mellor fd6772ab84 If we're going to overview we might need to unstash
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:PersistentBubbleStashControllerTest
Test: atest NexusLauncherTests:TransientBubbleStashControllerTest
Test: manual - swipe up to overview from home & from in an app, ensure
               bubble bar is unstashed
             - switch between home / overview / in app in transient
               and persistent taskbar to make sure things work
Bug: 368364143
Change-Id: I34c22b000d1fcc75489ea6da497f14def9649a20
2024-10-01 11:57:26 -07:00
Ats Jenk da8487eb33 Merge "Update bubble stash test for transient taskbar" into main 2024-10-01 18:53:36 +00:00
Jeremy Sim 21f504e0f1 Fix small bug with TaskView tile expansion
There was a small typo that resulted in the wrong measurement being returned for the remaining TaskView. This CL fixes it.

Fixes: 365476600
Test: Manual
Flag: NONE bugfix
Change-Id: I1abf993abcaa8d06e5475f31c0322017f6e96e6f
2024-10-01 11:50:54 -07:00
Treehugger Robot 62d8cac481 Merge "Override pivot in TaskViewSimulator as well for zoom in launch animation" into main 2024-10-01 18:31:29 +00:00
Bill Yi d77f2c1692 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I281ab493777a8d86477c5f5ca1f069cd368af5c3
2024-10-01 10:28:27 -07:00