Commit Graph

18040 Commits

Author SHA1 Message Date
Charlie Anderson fbf41783fc Asynchronously call snapToPage so Talkback correctly scrolls to added widget
Bug: 326269165
Test: locally tested via Talkback
Flag: N/A

Change-Id: I2be6e9758617e4eca18b3ea1ebed8189145c4108
2024-03-18 16:41:53 +00:00
Andrew Cole 6667611f59 Merge "Moving FORCE_MONOCHROME_APP_ICONS to New Flag System" into main 2024-03-18 16:10:03 +00:00
Rohit Goyal 1a59da4e82 Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev am: f51bd26b3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26599264

Change-Id: I1451fff8e1be77d7f3bb45e1406ba48fdda1df08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-18 13:58:54 +00:00
Rohit Goyal f51bd26b3d Merge "Bugfixes: Handle session failure unarchival cases so that icon and title are accurate." into 24D1-dev 2024-03-18 13:45:51 +00:00
Alex Buynytskyy 30c0325275 Merge "Fix NewApi warning" into main 2024-03-16 22:38:06 +00:00
Willie Koomson 078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Shamali Patwa 61adb489d1 Merge "Distribute the padding between search&rec container and tabs/applist" into main 2024-03-15 22:42:23 +00:00
Andrew Cole 16b68816ce Moving FORCE_MONOCHROME_APP_ICONS to New Flag System
In order to continue work on theming all app icons we are moving the developer flag over. This is cleanup work

Bug: 270396209
Test: None
Flag: ACONFIG FLAG_FORCE_MONOCHROME_APP_ICONS disabled
Change-Id: Ia290a6761aec68eadd2e78f64ac5dbd233af6033
2024-03-15 14:19:22 -07:00
Willie Koomson cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Sunny Goyal d51f91a7d0 Fixing PendingWidgets getting attached to real host
Bug: 318539160
Flag: aconfig enable_workspace_inflation DISABLED
Test: TaplBindWidgetTest#testPendingWidget_notRestored_activeInstall
Change-Id: I013811e83b90ea32221904a27790dd677dd63b4b
2024-03-15 10:16:33 -07:00
fbaron b41c826c6a Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
(cherry picked from commit 5645c3ec55)
2024-03-15 16:11:26 +00:00
Fengjiang Li 00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Shamali P 02a75fc924 Distribute the padding between search&rec container and tabs/applist
When there are no recommendations (pre-V as well), the margins/paddings
between search container & apps list / tabs was 8dp extra.

Additionally, cleaning up -
1. requestLayout call on page switch is now not needed after limiting
the table space for recommendations in two pane picker.
2. After preview container sizes, TOP alignment actually looks a bit
better - and widget preview itself is automatically center aligned as
we club only same preview container sizes in a row now.

* http://screen/6e6YzjqXJrdZ7Bt
* http://screen/AVLpzoYSGpyr2rs
* http://screen/7xnmrtLvBMPX5iX
* http://screencast/cast/NjYyNzM4NDY3MjM4NzA3Mnw2NDY0MmU4ZC0xMw (phone)
* http://screencast/cast/NTYwMzE1NDI1ODI5NjgzMnw2NmM1MjRkZS0zNA (fold)
* http://screencast/cast/NTIzODk3NTM5MTMzNDQwMHxlYmE2NDEwNS0xZg (tablet)

Bug: 319152349
Flag: N/A
Test: Screenshot and manual
Change-Id: I164419624d02fb47e80ea844eea0ee2a869ad4df
2024-03-15 13:36:20 +00:00
Shamali Patwa a835a2dc92 Merge "Rename the color attr for paging dot indicator used in launcher." into main 2024-03-15 13:33:40 +00:00
Rohit Goyal 86a1b1abf5 Bugfixes: Handle session failure unarchival cases so that icon and title are accurate.
* Remove old package icon entry from IconCache in case of a session failure.
* Allow package entry to fallback to fallback state where missing icon & titles are filled using PackageManager.
* Re-bind archived application in all apps if an unarchival fails.

Test: verified bugfixes locally.
Bug: 326494527
Bug: 328314141
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Merged-In: Ib132bece397001e9a14933c2f6d733a04a089ef9
Change-Id: Ib132bece397001e9a14933c2f6d733a04a089ef9
2024-03-15 12:14:43 +00:00
Jakob Schneider 46df9dfec4 Fix NewApi warning
Bug: 329770619
Change-Id: I70268c0f1871e87d431c89ad057712e73051cebe
2024-03-15 11:38:53 +00:00
Fengjiang Li e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Fengjiang Li a34b40fa26 Merge "[Predictive Back] Support WidgetBottomSheet" into main 2024-03-15 06:54:01 +00:00
Fengjiang Li 78adef7601 Merge "[Predictive Back] Fix widget edu back swipe" into main 2024-03-15 06:53:10 +00:00
Anushree Ganjam f774a101b6 Merge "Enable Omnient master flags in client code." into 24D1-dev 2024-03-15 06:09:00 +00:00
Fengjiang Li 7881183078 [Predictive Back] Fix widget edu back swipe
Fix: 329389275
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: Manual - attach video to bug
Change-Id: Ia8fb438068b0d324f4a535ff9e8b05fec46138f1
2024-03-14 18:33:06 -07:00
Fengjiang Li ba8347d926 [Predictive Back] Support WidgetBottomSheet
Fix: 329713475
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: Manual - attach video to bug
Change-Id: Iaa33eb55f69b572a9fb2a4fb92b763b691039dd6
2024-03-14 14:39:16 -07:00
Sebastián Franco 892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00
Federico Baron f6fd1f3d46 Merge "Fix bug where folder with 1 icon can exist" into main 2024-03-14 20:02:04 +00:00
Shamali P 34d1db731b Rename the color attr for paging dot indicator used in launcher.
Additionally, make the widgetPickerActivity theme support dark mode.

http://screencast/cast/NDY5OTUzNTA0ODcwNDAwMHxmZWU3ZDBjZS04ZQ

Bug: 326092660
Test: Manual
Flag: N/A
Change-Id: Ic2816853bd25bd04e07d661682d720d1940c268c
2024-03-14 19:38:37 +00:00
Sihua Ma 80a35cce2e Merge "Fix out-of-sync updates during grid change" into main 2024-03-14 18:09:15 +00:00
Pinyao Ting ebd958dc94 Merge "Remote legacy shortcut when failed to migrate" into main 2024-03-14 17:17:45 +00:00
Sebastian Franco 5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
fbaron 5645c3ec55 Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
Luca Zuccarini bb937b2556 Merge "Introduce a new Home animation for workspace and the outgoing task." into main 2024-03-14 16:11:46 +00:00
Rohit Goyal cbb8328272 Merge "Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps." into 24D1-dev am: aca99b60ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26554316

Change-Id: I53fc3448db4f8fdbf861df4b6b37f4177faa815e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-14 15:43:11 +00:00
Brandon Dayauon 69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Luca Zuccarini c9cbc9d5a1 Introduce a new Home animation for workspace and the outgoing task.
The values are currently the same for all display and orientation
configurations, but they might change before launch.

There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
  great
* Sometimes, if the window movement reaches its final location faster
  than the background is done scaling, there is a small snap in icon
  position

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off

Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
2024-03-14 10:48:02 +00:00
Pinyao Ting f5505bf50e Remote legacy shortcut when failed to migrate
Bug: 329421105
Test: manual
Flag: NA
Change-Id: I84071a1711a36a49ad2ef71dc017ae78e4dd1267
2024-03-13 23:48:18 +00:00
Brandon Dayauon a7bd5cf6ee Merge changes I209e3ec7,If70df129 into main
* changes:
  Change collapse to use adapterItems instead of getting the childCount()
  Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00
Sebastián Franco 920d333e3a Merge "In the case the gird migration goes to a taller grid keep the grid configuration" into main 2024-03-13 22:26:42 +00:00
Sihua Ma f418b2e16d Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
2024-03-13 15:21:34 -07:00
Winson Chung b5c4820a5b Merge "Change existing callers to use no matching id constant" into main 2024-03-13 19:11:20 +00:00
Winson Chung 30a9a212cd Change existing callers to use no matching id constant
- Otherwise it can unintentionally match a predicted icon

Fixes: 329353320
Test: None
Change-Id: I9e46126d5fe45a50d4a36140f7ce0317cd2b1b23
2024-03-13 19:11:03 +00:00
Sebastian Franco 2eaf15c37a In the case the gird migration goes to a taller grid keep the grid configuration
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.

Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.

Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
2024-03-13 11:13:38 -07:00
Shamali Patwa 1a72429687 Merge changes from topic "preview-sizes" into main
* changes:
  Limit the recommendations space in two pane picker
  Update the widget previews to use the container sizes
  Avoid cropping image previews.
  Add preview container size helper to display previews in picker.
2024-03-13 13:32:05 +00:00
Rohit Goyal b313ac7a30 Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps.
Test: verified bugfixes locally.
Bug: 329145005
Flag: NA
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3a6318ab5e2dee0b85c3270467477854301497a1)
Merged-In: I9f3145390d0596e55229d7dda08a4a3034d75f31
Change-Id: I9f3145390d0596e55229d7dda08a4a3034d75f31
2024-03-13 10:52:29 +00:00
Anushree Ganjam 023157f330 Enable Omnient master flags in client code.
Bug: 327638681
Test: Manual
Flag: legacy ENABLE_LONG_PRESS_NAV_HANDLE ENABLED
Change-Id: Id8990ed145b4f035e5cd14e901676ebbd03733dd
2024-03-13 06:47:22 +00:00
Holly Jiuyu Sun 5beb2498ac Merge "[PS] Do not use AppInfo and use PrivateSpaceInstallAppButtonInfo instead." into main 2024-03-13 03:48:37 +00:00
Shamali P 1076f176c2 Limit the recommendations space in two pane picker
- This makes the suggestion section non-overwhelming
- Currently it shows too many suggestions for user to find any value
- Limiting the height also allows pagination to feel smooth when showing
in categories

Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: Iab1f9a15bdd46ee1560734e30551bfb7c8a74a82
2024-03-12 23:47:07 +00:00
Shamali P 927dd27ece Update the widget previews to use the container sizes
Additionally, adjusts the margins on sides, to make space for displaying
multiple previews side by side.

As a result of this change, previews aren't cropped anymore (indirectly
also fixing b/317366201).

There is one more follow up pending - to limit the height of
recommendations in two pane sheet to only visible area to keep the
suggestions quick to look and concise. It will also help with better
scroll experience when size is same across pages.

* http://screencast/cast/NTQ0Njc4ODgyNjc5MTkzNnxjYzZiYTU2Ny02Yw
* http://screencast/cast/NTk4ODMyMDkxOTE1ODc4NHw3NzdlNTgxZS1kMw
* http://screencast/cast/NTYxOTc5NjIxNjM4MTQ0MHxiMjQ2Njc3OC0zOQ
* http://screencast/cast/NDk4MjIxNjI0MDEzNjE5MnxjY2IwYmIxNi00Mw

Bug: 319152349
Flag: N/A
Test: Image test and table utils test
Change-Id: I07465bd4d84597b560a2b998ff1ccbf9867c0192
2024-03-12 23:47:07 +00:00
Shamali P c93f687f12 Avoid cropping image previews.
In most cases, cropping image-based previews to just fit width leads to
degraded UX. Instead we try to fit them to the widget size if possible.

* Before: See attached bug for examples of cropped previews.
* After: http://screen/Bg7Eoydr4qBQdVZ

Additionally center align previews vertically for non-categorized
suggestions too.

Bug: 319152349, 317366201
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I4447f99028129d5d5379ead9ca404f7a011d1551
2024-03-12 23:47:07 +00:00
Shamali P a1dbbeab7e Add preview container size helper to display previews in picker.
While we want previews to be displayed at true size, today, there is
less consistency among different widgets. This change is a first step
towards consistent sizes. In this change, we provide helper classes
that provide the size of the container in terms of grid spans.

Note: This does not change the size for rendering widget previews; but,
we take that original rendered preview and scale it maintaining the
aspect ratio to display it in one of closest container sizes.

Bug: 319152349
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I335373aa1be9a41fe039c98cded0113a007ad8c4
2024-03-12 23:47:07 +00:00
Sebastián Franco e9ebd2d70a Merge "Revert^4 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-12 22:00:36 +00:00
Himanshu Gupta 201626b553 Merge "Using LauncherApps API for PS Settings and Setup Flow." into main 2024-03-12 21:17:22 +00:00