Commit Graph

6715 Commits

Author SHA1 Message Date
Stefan Andonian fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Jagrut Desai 50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Jagrut Desai 4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel.
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
2023-01-10 22:57:35 +00:00
Alex Chau 616de308b7 Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev 2023-01-10 18:34:08 +00:00
Ats Jenk 83a8dad319 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev 2023-01-10 18:09:16 +00:00
Shan Huang f43527d5df Merge "DO NOT MERGE Rename BackEvent to BackMotionEvent in LauncherBackAnimationController." into tm-qpr-dev 2023-01-10 16:46:55 +00:00
Thales Lima bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Luca Zuccarini d23cd42875 Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev 2023-01-10 13:50:50 +00:00
Thales Lima 03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Jagrut Desai d8ea04a7f6 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev 2023-01-09 16:19:04 +00:00
Alex Chau 04658bcd42 Add debug logs for hotseat disapperaed bug
Bug: 260135164
Test: manual
Change-Id: Ic911ba0353b742feb753024543ca19930f11b47d
2023-01-09 12:43:16 +00:00
Vinit Nayak 72b186aefd Merge "Improves overview split adjacent launch animation" into tm-qpr-dev 2023-01-07 00:36:16 +00:00
Schneider Victor-tulias 53808c3ed8 Merge "Fix NPE from getting swipe pip to home animator finish transation after the surface has been released" into tm-qpr-dev 2023-01-06 18:38:21 +00:00
Vinit Nayak daffdfa35c Merge "Toggle taskbar button nav assistant availability" into tm-qpr-dev 2023-01-05 21:28:23 +00:00
Vinit Nayak da2819ed5f Improves overview split adjacent launch animation
* Translation gets scaled along with the parent,
so the secondary thumbnailView which has a translate on
it gets exaggerated as the parent goes to fullscreen
scale.
* Now we inversely scale translationX/Y properties,
however it seems like the interpolation is still slighly
off at the beginning of the animation (or maybe some other
value, such as pivot, etc)

Bug: 260814999
Test: Manually slowed down animation and observed
Change-Id: I831476b4ffb582fecbd166525ceea33623e66bdd
Merged-In: I831476b4ffb582fecbd166525ceea33623e66bdd
2023-01-05 11:54:22 -08:00
TreeHugger Robot c46b47853b Merge "LauncherTaskbarUIController should only translate nav buttons on inAppProgresst if icon is aligned with hotseat" into tm-qpr-dev 2023-01-05 15:29:05 +00:00
Luca Zuccarini 3913716ece Make LauncherAnimationRunner compatible with RemoteAnimationRunner.
Nothing changes in its current usage and behavior, but instead of a
RemoteAnimationFactory we can now also pass a RemoteAnimationRunner.

Bug: 250588519
Test: manual
Change-Id: I51f5a95360401d5f17104519ef91a81aef60923f
2023-01-05 14:12:13 +00:00
Ats Jenk f6ba9499de Fixes to support transient taskbar in desktop mode
Track gesture progress in desktop visibility controller. We need to
allow launcher to resume when gesture is in progress and freeform tasks
are visible.
Update overview state handling in desktop visibility controller. When
overview is enabled, launcher should be made visible, regardless of
freeform state. When exiting overview state, check freeform state to see
what should be shown and enabled.

Bug: 263264985
Test: manual, enable transient taskbar, move app to desktop, invoke transient
taskbar
Test: manual, enable transient taskarb, enable desktop mode, invoke
transient taskbar
Test: manual, disable transient taskbar, move app to desktop, swipe up
to overview
Test: manual, disable transient taskbar, enable desktop mode, swipe up
to overview

Change-Id: I63000441d9cf72769e6efb9d247ab4112c01839d
2023-01-04 17:27:54 -08:00
Schneider Victor-tulias 8aa0471591 Merge "Add check for loading ever applied in check for page scrolls initialized" into tm-qpr-dev 2023-01-04 22:08:12 +00:00
Schneider Victor-tulias d8a07fa030 Fix NPE from getting swipe pip to home animator finish transation after the surface has been released
Fixes: 243154747
Test: programmatically added delay to finish transation later
Change-Id: Ia667372678f2224406147f5659c5fc6f61f270ad
2023-01-04 13:53:37 -08:00
Jagrut Desai 7764627216 Moving Accessibility Annoucement to Task Closed to onEnd animation callback.
Test: Manual
Fix: 220198279

Change-Id: I3d9d522cd81b4873fb4b03671384f23b7bb6777f
2023-01-04 16:18:43 -05:00
Vinit Nayak 0d784ee7fb Toggle taskbar button nav assistant availability
* New signals coming in from Sysui reflect the toggle
in Settings for long pressing on home button to
invoke assistant.

Fixes: 255909545
Test: Manual + added unit test for TaskbarNavButtonController
Change-Id: Ic65a80b0b9697990931b7e89756773fb086cc3bd
2023-01-03 20:07:27 -08:00
Ikram Gabiyev 6d3ad6820d Turn off filter ui if flag is off
Fix a bug in a condition determining when to show
filter ui for a certain taskview, making sure
that the ui is off when the feature flag for
multi-instance is off.

Test: reproduced the steps laid out in the bug

Bug: 264218764
Change-Id: Ie745789ad834d56b79de47e5196737eb08b081fa
2023-01-04 00:16:34 +00:00
Alex Chau a5c6aad231 LauncherTaskbarUIController should only translate nav buttons on inAppProgresst if icon is aligned with hotseat
Fix: 261364559
Test: Pull notification shade in overview, 3-buttons stay in place
Test: Pull notification shade in home, 3-buttons translated down
Test: Go to -1, 3-buttosn translated down
Test: Go to AllApps, 3-buttons translated down
Test: Go to widget picker, 3-buttons translated down
Change-Id: I53da354266c60e86599011ba3ddd8b44cde70beb
2023-01-03 18:41:21 +00:00
TreeHugger Robot 39688d2d61 Merge "Update taskbar to spec" into tm-qpr-dev 2023-01-03 17:42:41 +00:00
Shan Huang 81f7d0bbf5 DO NOT MERGE Rename BackEvent to BackMotionEvent in LauncherBackAnimationController.
This cherry-picks ag/20484685 to QPR to mitigate future merge conflicts.

Bug: 238475284
Test: m -j
Change-Id: Ie13c738d0d4a10f4265fbf116ff7b4206d3bfc62
2022-12-29 21:20:40 +00:00
Ikram Gabiyev 231e061ae1 Merge "Filter recents view instances by package name" into tm-qpr-dev 2022-12-29 01:17:42 +00:00
Tony Wickham 2a058f5be1 Update taskbar to spec
- Space between icons is 24dp in all cases (transient, persistent,
  small tablet, large tablet)
- Persistent taskbar icon size remains 44dp, but transient taskbar icon
  sizes have changed slightly: 57dp -> 52dp for large tablets and
  50dp -> 48dp for small tablets
- Also moved all values to quickstep package to avoid confusion

Test: manual, visual
Fixes: 263465844
Change-Id: I563d64dca2d920762233dd6147395c5bba3ffcf3
2022-12-28 18:56:43 +00:00
Luca Zuccarini 2da05f367d Merge "Revert "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2022-12-28 14:03:58 +00:00
Ikram Gabiyev 448e0ade10 Filter recents view instances by package name
Filter instances of GroupTasks based on package name
as a part of support for multi-instance

Add a feature flag to toggle multi-instance features

See the video below for how to use the demo.
Note: some extra UI elements were added since video
was recorded, but the filtering process is the same.
http://recall/-/da585DRwKRZK3S2xxcQrSm/gW9HZnbCvGyH1DQiVizOW2

See go/multi-instance for more info about the feature

Bug: 253520408

Test: manually tested the instance filtering

Change-Id: I19c947ca353699096388b9fbbdca6d75cb0041a7
2022-12-28 00:10:48 +00:00
Luca Zuccarini 5dd5296527 Merge changes from topic "b/260218332-1" into tm-qpr-dev
* changes:
  Add a CUJ for closing All Apps manually.
  Add Tapl support for swiping from All Apps to Workspace.
2022-12-27 14:27:48 +00:00
Luca Zuccarini e18ac479e5 Revert "Update timings for the Home <> All Apps transition."
Revert submission 20641089-b/254835725

Reason for revert: b/263221786

Reverted changes: /q/submissionid:20641089-b/254835725

Change-Id: I6aa0955b4ac7ed47ea254514b364b0ab94b632bf
2022-12-27 14:18:05 +00:00
Pat Manning eef0b1640b Merge "Do not animate moving to rest state on CHANGE_ACTIVE_SCREEN." into tm-qpr-dev 2022-12-22 17:47:57 +00:00
Brandon Dayauon 2d3f189b80 Merge "Move VibratorWrapper to AOSP" into tm-qpr-dev 2022-12-22 08:18:12 +00:00
Tony Wickham 1f155d6fd7 Merge "Adjust taskbar VIS and bottom mandatory gesture insets" into tm-qpr-dev 2022-12-21 23:25:59 +00:00
Luca Zuccarini d3841f36a1 Add a CUJ for closing All Apps manually.
Bug: 260218332
Test: pending
Change-Id: Iafe3b932aca985fb4585dac46c6eaaa6e88c8dd6
2022-12-21 15:39:51 +00:00
Pat Manning cc31ba5360 Do not animate moving to rest state on CHANGE_ACTIVE_SCREEN.
Fix: 259380717
Test: manual
Change-Id: Icec103b26603290c7998977fa9c4d89132620a9d
2022-12-21 11:37:47 +00:00
Ats Jenk ebfe6b6776 Merge "Taskbar fixes when apps move to desktop and back" into tm-qpr-dev 2022-12-20 23:29:26 +00:00
Alex Chau d79e53a5c8 Merge "Add transientTaskbarMargin above taskbar in overview" into tm-qpr-dev 2022-12-20 18:40:48 +00:00
Ats Jenk 0ea4768a02 Taskbar fixes when apps move to desktop and back
Fixes to taskbar state when tasks are moved to desktop and fullscreen.

When freeform tasks are visible and we start a new task from taskbar, it
first launches in fullscreen. Transition handler in WMSHell switches it
to freeform as needed. This switch causes launcher activity to be paused
and then resumed. Resuming launcher activity while freeform tasks are
visible, puts the launcher into an incorrect state. (Launcher should
appear paused while freeform tasks are visible).

When a freeform task switches to fullscreen, freeform tasks are no
longer visible. This causes us to resume the launcher activity. We
should not do that if a fullscreen task is visible as it puts the
launcher into an incorrect state. It appears resumed even though the
activity is paused. Added a check to DesktopVisibilityController that
checks if the activity is actually resumed before marking it appear as
resumed.

Test: manual, switch a task to freeform, launch another freeform task
  from taskbar, taskbar should continue to be available
Test: manual, switch a task to freeform, switch the task back to
  fullscreen, taskbar should continue to be available
Bug: 261234278

Change-Id: Ia8d208619fabfcc9bffff6d8d227b236cb62a00c
2022-12-20 10:34:07 -08:00
Brandon Dayauon 5a31c9262e Move VibratorWrapper to AOSP
bug: 233751149
test: manually run and presubmit
Change-Id: I89ada0adf7254396238cb96d27bc265e28093f50
2022-12-20 10:27:21 -08:00
Alex Chau 44dd5b7b28 Merge "Only skip stash animation when going to/from Launcher" into tm-qpr-dev 2022-12-20 09:32:04 +00:00
Sihua Ma 04c89fe38e Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev 2022-12-19 18:22:38 +00:00
Alex Chau 1b276a1ba7 Add transientTaskbarMargin above taskbar in overview
- Also removed transient_taskbar_two_panels_size and use sw720dp override instead, to be consistent with how we handle small vs large tablet in overview
- Also made isTransientTaskbar mockable so we can test that in DeviceProfileDumpTest

Bug: 260596114
Test: DeviceProfileDumpTest
Change-Id: I3c2236b95d91246e9581531478e3c97601cfb2ec
2022-12-19 17:23:27 +00:00
Alex Chau bd535c46d7 Only skip stash animation when going to/from Launcher
- Added a cehck on chagnedFlags before skipping stash animation, in additional to !isHotseatIconOnTopWhenAligned check

Fix: 262835548
Test: manual
Change-Id: I5a90213bc0b3f34609a074ba887adbf113e04120
2022-12-19 17:16:08 +00:00
Alex Chau 4537638dfd Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev 2022-12-19 11:37:39 +00:00
Luca Zuccarini 49d07b1688 Merge "Update timings for the Home <> All Apps transition." into tm-qpr-dev 2022-12-19 11:10:14 +00:00