Commit Graph

16725 Commits

Author SHA1 Message Date
Treehugger Robot 7b01dbd811 Merge "Add seam space for performReorder in MultipageCellLayout" into udc-dev 2023-05-18 23:20:40 +00:00
Fengjiang Li c7613ebf17 Merge "Fix NPE of FolderPagedView#setFocusOnFirstChild" into udc-dev am: 0d07a85299 am: 63144d9a29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23254588

Change-Id: I6f203417d5699fc57149dcc81ce465594fca4782
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:14:46 +00:00
Fengjiang Li 0d07a85299 Merge "Fix NPE of FolderPagedView#setFocusOnFirstChild" into udc-dev 2023-05-18 22:42:47 +00:00
Sebastian Franco 96c46e7fba Add seam space for performReorder in MultipageCellLayout
In the other method createAreaForResize we add 1 to the cellX
to account for the seam in the Multipace CellLayout but we don't
account for that on performReorder and we need to add a cellWidth

Also, some methods are not running when the seam is added so their
result are wrong. Now all methods are being accounted for.

Fix: 277709417
Test: atest ReorderAlgorithm
Test: atest MulticellReorderAlgorithm
Change-Id: I7a4ca55f7b9cd7cf94481c880fe152e0a3bb3cf3
2023-05-18 14:47:47 -07:00
Federico Baron 8230b45cf5 Merge "Update colors for popup menus" into udc-dev am: 3eba77ca4b am: 90edc421ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23152777

Change-Id: I6c755c00b4c10e2d1a4860b9e98578659c973ca8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 21:36:47 +00:00
Federico Baron 3eba77ca4b Merge "Update colors for popup menus" into udc-dev 2023-05-18 21:03:19 +00:00
Stefan Andonian 324b6e0ff5 Fix NPE in FolderPagedView
Bug: 282945356
Test: Compilation worked properly.
Change-Id: Ice59274ec0979550388c5d8a8f17f6e912d7ccb3
2023-05-17 20:22:12 +00:00
TreeHugger Robot e607fdb2a2 Merge "Removing support for lagacy shortcuts" into udc-qpr-dev 2023-05-17 19:25:45 +00:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Thales Lima 52fbedf2f1 Merge "Calculate sizes for responsive grid" into udc-dev am: d282d5956e am: dc7d900708
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22764617

Change-Id: I29151c20fb9a05163a0f17b0317bff1ebf14588e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 15:36:07 +00:00
Alex Chau ab926886f7 Merge "DisplayController should deep compare mPerDisplayBounds" into udc-qpr-dev 2023-05-17 14:27:02 +00:00
Thales Lima d282d5956e Merge "Calculate sizes for responsive grid" into udc-dev 2023-05-17 14:12:50 +00:00
Himanshu Gupta cd35486198 Merge "Revert "Do not display clone apps in launcher work tab."" into udc-dev am: ee311b3e9c am: cddca58573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23264596

Change-Id: I731dba4ec7f1ad490e0b556853f64fe865cac1b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 13:32:08 +00:00
Thales Lima c98b7815c6 Calculate sizes for responsive grid
This shouldn't change anything in the grids, only calculate the sizes of the grid.

Bug: 277064708
Test: CalculatedWorkspaceSpecTest
Test: WorkspaceSpecsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Id1f90ef44f5b869113d063bad17589e7e88d1d20
2023-05-17 10:33:36 +00:00
Alex Chau 7af659da9e DisplayController should deep compare mPerDisplayBounds
- In CHANGE_SUPPORTED_BOUNDS check, it uses Map.equals, but as the value is a primitive array WindowBounds[], equals check does not deep compare the arrays and may result in false negative
- One example is when fontScale changes, DisplayController re-create bounds from WindowManagerProxy, result in new WindowBounds[] created, and the shallow compare results in unexpected CHANGE_SUPPORTED_BOUNDS

Fix: 282736623
Test: DisplayControllerTest
Change-Id: I3897595c58559192b951ecfee7c9f62a07dafe1f
2023-05-17 09:40:46 +00:00
Fengjiang Li 01db37f773 Merge changes I1136ede4,I5f0877fe into udc-dev am: 106d91d04c am: f080503675
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23251138

Change-Id: I48d71ee70b7d3e6e91c10e01baca9dd6022efb57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 23:35:41 +00:00
Himanshu Gupta 8ef1845c3d Revert "Do not display clone apps in launcher work tab."
This reverts commit 45ef9b6c01.

Reason for revert: As promised, sysUi changes introduced in Launcher for AppCloning are being reverted. (This is the only CL that was merged)

Change-Id: I9fc72c333d48ca51558578d0d79038b49b3ebb5b
Test: Manual by building sysUi
2023-05-16 23:43:22 +01:00
fbaron 1a76d5c72d Update colors for popup menus
Bug: 268521231
Test: Verify that popup menu colors match the figma attached in the bug
Change-Id: I24025576a789775dfcf17694d16c0d5f6ee844fd
2023-05-16 15:07:30 -07:00
Fengjiang Li 106d91d04c Merge changes I1136ede4,I5f0877fe into udc-dev
* changes:
  [Folder] Fix bug where folder name and page indicator is visible when cancelling folder open animation
  Fix bug where quickly ending folder animation with back swipe caused icons not clipped to folder
2023-05-16 21:20:09 +00:00
Charlie Anderson 6afbcd785e Merge "Adding a new Edit Mode LauncherState" into udc-dev am: afb447ee0d am: c7786d86fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22890120

Change-Id: If0dd0e77bad60113c254212900dfa6b6ce90db22
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 21:05:31 +00:00
Stefan Andonian 10ced3a750 Merge "Fix NPE in LauncherPreviewRenderer." into udc-dev am: 7158f9c427 am: 80232bdcc4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122640

Change-Id: Ib88380aa985c171b7d47aff96cb3bae8e61b38da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 21:05:14 +00:00
Vinit Nayak 95a2656f08 Merge "Don't throw exception for SafeCloseable objects" into udc-dev am: a6e7a4b574 am: 759b5b08f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23247739

Change-Id: I5c20e5fd2ce9994175a616defb7971e99e2df169
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 19:04:04 +00:00
Charlie Anderson afb447ee0d Merge "Adding a new Edit Mode LauncherState" into udc-dev 2023-05-16 18:42:34 +00:00
Stefan Andonian 7158f9c427 Merge "Fix NPE in LauncherPreviewRenderer." into udc-dev 2023-05-16 18:33:43 +00:00
Vinit Nayak a6e7a4b574 Merge "Don't throw exception for SafeCloseable objects" into udc-dev 2023-05-16 17:52:54 +00:00
Fengjiang Li 533275683b [Folder] Fix bug where folder name and page indicator is visible when cancelling folder open animation
We should resgiter all AnimatorListeners before starting folder open animation.

Fix: 282158620
Test: https://b.corp.google.com/issues/282822254#comment2
Change-Id: I1136ede464f37c174296921594ef887d90844eb5
2023-05-16 10:51:51 -07:00
Fengjiang Li c80d0221be Fix bug where quickly ending folder animation with back swipe caused icons not clipped to folder
1. Fix a race condition that the new animation is reading stale UI state which should have been reset in previous animation.
2. Don't set clipChildren=true on folder page view during open folder animation

Fix: 282158620
Test: open folder and quickly back swipe, verify app icons are still clipped
Change-Id: I5f0877fe4157533563df922ba50a6ad540c9ba6e
2023-05-16 10:51:31 -07:00
Hyunyoung Song ff760834df Merge "Revert "[Toast] Enable background drawables by default in Teamfood."" into udc-dev am: deec0f628b am: 3c7798cb93
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23113219

Change-Id: I9f1da94151935ebd3c2fbb3f3ab7660e5168bd55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 07:50:45 +00:00
Hyunyoung Song deec0f628b Merge "Revert "[Toast] Enable background drawables by default in Teamfood."" into udc-dev 2023-05-16 06:41:20 +00:00
Fengjiang Li 47d72ffccb Fix NPE of FolderPagedView#setFocusOnFirstChild
Test: open and close folder with swipe back quickly
Fix: 282814528
Change-Id: I163c2f9d54b48684738f8104be8c085f26b52ceb
2023-05-15 21:52:19 -07:00
Treehugger Robot 0a14007530 Merge "Add flag for enabling widget transition animation" into udc-dev am: bbb54462a8 am: af85e7dcc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23247754

Change-Id: Iaacfcd2d8c1c2ce4f59fae8ed0c6986c67a6b1c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 02:06:15 +00:00
Vinit Nayak fa5a61c8db Don't throw exception for SafeCloseable objects
* SafeCloseable objects will have their close() method
called when SandboxContext is destroyed, so we can leave
them out of the allowList.
* Long term we may want to remove the allowList altogether
and just rely on safeCloseable

Test: Locally passes
Flag: not needed
Bug: 280463854
Change-Id: I317a9d6639b25a522fe9dbcf2655b55ec68fded6
2023-05-15 18:56:55 -07:00
Treehugger Robot bbb54462a8 Merge "Add flag for enabling widget transition animation" into udc-dev 2023-05-16 00:50:32 +00:00
TreeHugger Robot ce7ecd8aa3 Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev am: f0c96721ba am: 0333de8878
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22999970

Change-Id: Id04287f7ff48917fccdfd91372726a12c3999a3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 00:20:45 +00:00
Treehugger Robot 02777887e7 Merge "Turn on ENABLE_TRACKPAD_GESTURE in udc-qpr-dev" into udc-qpr-dev 2023-05-15 23:56:32 +00:00
TreeHugger Robot a9b32d852f Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev am: 15bc0d388a am: a99509339c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23214378

Change-Id: I2ac11a2a50d249c8bc8d983d7bc268d4f8961624
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15 23:16:24 +00:00
Treehugger Robot 72ba26bcf9 Merge "Cleanup WIDGETS_IN_LAUNCHER_PREVIEW." into udc-dev am: f8b4a4cc08 am: 10ac903861
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23245066

Change-Id: Ib8952a875979216169c219842023f8b5d8e3e152
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15 23:16:08 +00:00
Tony Wickham 9ad0ea5e68 Merge "Remove unused/obsolete feature flags" into udc-dev am: 4f69ca52ef am: b4802d7837
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23219342

Change-Id: I62c140775adcb7a2e82c6114e5b5103d00f579ba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15 23:15:53 +00:00
TreeHugger Robot f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
Stefan Andonian 9d7bffe37b Fix NPE in LauncherPreviewRenderer.
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.

Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.

Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
2023-05-15 22:41:04 +00:00
TreeHugger Robot 15bc0d388a Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev 2023-05-15 22:20:32 +00:00
Pavel Grafov 9cc261caa7 Merge "Guard ACTION_PROFILE_INACCESSIBLE with version check" into udc-dev am: 564cd388c6 am: 3530786cd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23192128

Change-Id: I20b50e63b172229cd39ee65fbc36daa436b3c29b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15 22:12:33 +00:00
Treehugger Robot f8b4a4cc08 Merge "Cleanup WIDGETS_IN_LAUNCHER_PREVIEW." into udc-dev 2023-05-15 21:52:35 +00:00
Tony Wickham 4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Sihua Ma a5ccdbb048 Add flag for enabling widget transition animation
Test: N/A
Flag: ENABLE_WIDGET_TRANSITION_FOR_RESIZING
Bug: 268553314
Change-Id: I84793249af94076b675a69696ea2a3e34816f704
2023-05-15 14:20:28 -07:00
Treehugger Robot 94d3dce6c4 Merge "Update notification dot color" into udc-dev am: 21339533b1 am: 890a73c274
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23170209

Change-Id: I73e63e963f409c3c41ef16f45d1b34f792844af1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15 21:08:00 +00:00
Pavel Grafov 564cd388c6 Merge "Guard ACTION_PROFILE_INACCESSIBLE with version check" into udc-dev 2023-05-15 21:00:02 +00:00
Treehugger Robot 21339533b1 Merge "Update notification dot color" into udc-dev 2023-05-15 20:21:45 +00:00
Tracy Zhou e715071855 Turn on ENABLE_TRACKPAD_GESTURE in udc-qpr-dev
Bug: 271010401
Change-Id: Iac8bf88038ccf4640ca30e9e21c5af86cc72a06d
Test: N/A
2023-05-15 18:43:49 +00:00
Schneider Victor-tulias eb8dce01ce Add handling for toggling keyboard stashing from the keyboard
Flag: ENABLE_KEYBOARD_TASKBAR_TOGGLE
Bug: 281726846
Fixes: 246660615
Test: toggled the transient taskbar with the meta+t input
Change-Id: I315f83850b11d24d8b55061d7111300effb43936
2023-05-15 18:41:25 +00:00