Commit Graph

16725 Commits

Author SHA1 Message Date
Sunny Goyal 171bb04407 Removing some obsolete features
Bug: 270386012
Test: Presubmit
Change-Id: I9d68b3d17e02d6e79ab726eb7c8da1e5a4d337ef
2023-02-22 23:17:15 +00:00
Stefan Andonian d78817b455 Merge changes from topic "idp_grid_name" into tm-qpr-dev am: 78187b3812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529902

Change-Id: Ib632a7112fe19dc39d6f7f78fca7b668e00d35d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 22:32:15 +00:00
Stefan Andonian 2bbdb87ae6 Merge "Re-add LockedUserState util that was reverted after TAPL test failures." into tm-qpr-dev am: b334c03c74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532181

Change-Id: I0ed0d81062e264b997e97034ff19bb8ec0aa0951
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 22:32:03 +00:00
Stefan Andonian 78187b3812 Merge changes from topic "idp_grid_name" into tm-qpr-dev
* changes:
  Add unit test and fix bug related to "Migrate IDP_GRID_NAME usage to LauncherPrefs" CL.
  Revert "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs""
2023-02-22 22:09:42 +00:00
Stefan Andonian b334c03c74 Merge "Re-add LockedUserState util that was reverted after TAPL test failures." into tm-qpr-dev 2023-02-22 22:02:51 +00:00
Schneider Victor-tulias 6b94a960c0 Add debug logs to debug flaky workspace binding
Bug: 270216650
Test: ReorderWidgets
Change-Id: I6fa2eab98c0268000ef4c44980c2917d5ef1bc89
2023-02-22 13:05:13 -08:00
Alex Chau eabf2c39f7 Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""
This reverts commit 5dfd939d41.

Reason for revert: b/270395565
Bug: 253338238

Change-Id: I6b2e44c92a67f6675d6947f34167a5f0c1cc6a45
2023-02-22 20:31:10 +00:00
Alex Chau ce9766da2d ENABLE_WIDGET_PICKER_DEPTH
Fix: 270393895
Test: manual
Change-Id: I167354425e5469663c283919f84c8bdf664cceec
2023-02-22 20:18:39 +00:00
Sebastián Franco a112bfd9ed Merge "Correctly add seam to MultipageCellLayout when resizing widget" into tm-qpr-dev am: ee24d3f9f4 am: d8ea26c2de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529646

Change-Id: I9aa1a0a02271162d964dcd9b317ebff32116751d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 19:36:20 +00:00
Sebastian Franco ee1baba8f4 Accoutning for the seam on createAreaForResize for cellX position
I fix the left side resize issues but that broke right side resizes
because I wasn't accounting for the seam and the other functions don't
need to because they don't receive x,y cell position but they receive
pixel position which are already accounted for by simulateSeam.

Fix: 270227019
Test: atest FoldableItemsIntegrity
Test: atest ReorderWidgets
Change-Id: Ida09629111ea6f78a089f19a14bd806bd10bbff8
2023-02-22 19:30:11 +00:00
Stefan Andonian 246eeaaea1 Add unit test and fix bug related to "Migrate IDP_GRID_NAME usage to LauncherPrefs" CL.
The issue was that kotlin initializes class variables before contructor
variables, but allows constructor variables to be referenced by
the class variables before they are initialized. This led to `isBackedUp`
always being false, and then the SharedPreference store always and only
checking if values were in DEVICE_PREFERENCES rather than the standard
backed up preferences.

The fix is to make the class variable sharedPrefFile lazily retrieved.
That way, isBackedUp will have been initialized and behave correctly.

Bug: 269569568
Test: Everything works on device and manual and unit tests
verified original bug is not present.

Change-Id: I8ab4a5752886ce8f4a2988295fa61c8a2c38ec7c
2023-02-22 19:05:00 +00:00
Sebastián Franco d8ea26c2de Merge "Correctly add seam to MultipageCellLayout when resizing widget" into tm-qpr-dev am: ee24d3f9f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529646

Change-Id: I8560e17377ea4ae6ce9d32c317a5e8643b77fe5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 18:55:30 +00:00
Sunny Goyal 81495403fc Merge "Simplifying some scrollbar binding logic in all-apps" into tm-qpr-dev am: 936cd17a11 am: 4391018119
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21272506

Change-Id: Ibfe5b213133f4dd226e85914c965220cb7a64651
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 18:54:44 +00:00
Stefan Andonian 4c9612be30 Revert "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs""
This reverts commit df11959779.

Bug: 269569568
Test: In follow-up CL, everything works on device and manual and unit tests
verified original bug from this CL is not present.

Change-Id: I125bbbfd6442cd3fa1e88c9109de536b88981dc6
2023-02-22 18:53:26 +00:00
Stefan Andonian 429460beae Re-add LockedUserState util that was reverted after TAPL test failures.
Bug: 251502424
Test: Unit tests all passed.
Change-Id: I80f1d521d430edf6c4d5e027d14e2087ed7e04f1
2023-02-22 18:49:21 +00:00
Sunny Goyal 4391018119 Merge "Simplifying some scrollbar binding logic in all-apps" into tm-qpr-dev am: 936cd17a11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21272506

Change-Id: Icff6d6a26d28c17c55ff9f965f4863f792a6ccdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 18:27:59 +00:00
Sebastián Franco ee24d3f9f4 Merge "Correctly add seam to MultipageCellLayout when resizing widget" into tm-qpr-dev 2023-02-22 18:24:09 +00:00
Tony Wickham b83d56bc27 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493 am: c8207a7e23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764

Change-Id: I4af1a2fe1e79d2f36d275a057178efd7e750b0e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 18:10:26 +00:00
Sunny Goyal 936cd17a11 Merge "Simplifying some scrollbar binding logic in all-apps" into tm-qpr-dev 2023-02-22 18:09:32 +00:00
Tony Wickham c8207a7e23 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764

Change-Id: I04cbb24dc071677a8e6f5c4fa8981efc5bec6d34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 16:59:30 +00:00
Tony Wickham 3d1bb16493 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev 2023-02-22 16:24:48 +00:00
Pat Manning 4faa11aea1 Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03 am: 3eadaa7d77
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663

Change-Id: Icd9a71482cfbb235d03b0fadfbfd6f74d4bc44d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 14:09:34 +00:00
Pat Manning 3eadaa7d77 Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663

Change-Id: I3fc5d3fde2fadf3e95383c3827be7901b3712ef5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 13:00:42 +00:00
Thales Lima 1db4318a5d Merge "Rename variables for better understanding" into tm-qpr-dev am: 85f734b587 am: e786623053
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883272

Change-Id: I4fcd6bc321aa5db2f63f732df2ecf1012dcda926
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 11:32:10 +00:00
Andy Wickham 0f5743e960 Merge "Set All Apps scale to 1 to start." into tm-qpr-dev am: 41d0cec7de am: dd5f417e9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407989

Change-Id: I925f5eee59c4611083a6d56783f2d3e6516e950a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 11:27:22 +00:00
Pat Manning 1b27affb03 Merge "Animate grid tasks to modal state." into tm-qpr-dev 2023-02-22 11:18:47 +00:00
Thales Lima e786623053 Merge "Rename variables for better understanding" into tm-qpr-dev am: 85f734b587
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883272

Change-Id: I72a03881b833a58627bbeb71cf04ca11e063aa07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 10:33:06 +00:00
Andy Wickham dd5f417e9a Merge "Set All Apps scale to 1 to start." into tm-qpr-dev am: 41d0cec7de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407989

Change-Id: If64eea2e13f4207d6bac18afab50ff9ddc5c57cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 10:28:19 +00:00
Thales Lima 85f734b587 Merge "Rename variables for better understanding" into tm-qpr-dev 2023-02-22 09:36:43 +00:00
Andy Wickham 41d0cec7de Merge "Set All Apps scale to 1 to start." into tm-qpr-dev 2023-02-22 09:23:14 +00:00
Kevin Lim 888a3fe0ca Merge "[DenserUI] Add feature flag for app icon in inline shortcuts." into tm-qpr-dev am: 2d5c2399ed am: 9acf5f147f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407092

Change-Id: I0f53da52a09f6914323c8d9c6938451396e47e54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 06:23:53 +00:00
Kevin Lim 9acf5f147f Merge "[DenserUI] Add feature flag for app icon in inline shortcuts." into tm-qpr-dev am: 2d5c2399ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407092

Change-Id: Idb18cd3d009cd7f1b6cd4871987bd07191091be6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 05:24:45 +00:00
Kevin Lim 2d5c2399ed Merge "[DenserUI] Add feature flag for app icon in inline shortcuts." into tm-qpr-dev 2023-02-22 04:05:40 +00:00
Brandon Dayauon b4ce6989d0 Merge "Make shortcuts on people row themed" into tm-qpr-dev am: 97baa50a07 am: 2cdd533c77
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21271707

Change-Id: I70c1e758cec25e5cec513082e6277e23fd50487f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 03:50:10 +00:00
Tony Wickham 00f89fbbf6 Fix taskbar drag view scale when returning to original icon
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
  this accounts for padding as well as extra ring inset for
  PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
  the system drag and drop, instead of using the current scale which
  might be in the process of animating

Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838

Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
Brandon Dayauon 2cdd533c77 Merge "Make shortcuts on people row themed" into tm-qpr-dev am: 97baa50a07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21271707

Change-Id: Ibfcd0841a96442552b3851ed1324d9eac7ab2fb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 02:50:19 +00:00
Brandon Dayauon 97baa50a07 Merge "Make shortcuts on people row themed" into tm-qpr-dev 2023-02-22 01:44:04 +00:00
Winson Chung 071aff5b49 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606 am: 0e9de04dfb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928

Change-Id: I282754b27a97e70223554050d31c2754cb52eb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 01:16:54 +00:00
Sebastian Franco 317c4faeea Correctly add seam to MultipageCellLayout when resizing widget
Fix: 270227019
Test: atest FoldableItemsIntegrity
Test: atest ReorderWidgets
Change-Id: Idf3d820112fe53202f0dab00c78682c31a692bc1
2023-02-21 17:09:45 -08:00
Federico Baron 8f6523a3d6 Move 'no widgets found' to right pane and add rounded edges to right pane.
Previously 'no widgets found' appeared on the left pane, but in large screen landscape we want it to appear on the right pane. Additionally, we added rounded edges to the right pane that turn into sharp edges when we scroll.

Fix: 268558448
Fix: 268557435
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and on tablet landscape mode go to the widget picker and search for a widget that doesn't exist, verify that 'no widgets found' appears on the right pane. Also verify that right pane has rounded corner that turn into sharp corners as we scroll
Change-Id: I6c89c63941e3b0680836828d0c7849d789cbce61
2023-02-22 00:34:10 +00:00
Federico Baron e8217b3c1b Add ripple effect when a header in widget picker is selected.
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.

Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
2023-02-21 16:33:18 -08:00
Winson Chung 0e9de04dfb Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928

Change-Id: I0e22beac88c2dd89078767d1846fb3470a8b26d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 00:17:27 +00:00
Winson Chung d30ef72606 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev 2023-02-21 22:50:31 +00:00
TreeHugger Robot 1bbecc6bc4 Merge "Make sure we start new activity only in UI thread." into tm-qpr-dev am: fd2471b990 am: 52f3078c7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21484427

Change-Id: Idd5019c6f5f95219ac13cc70b2e4842dbac70392
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 22:46:45 +00:00
TreeHugger Robot 52f3078c7f Merge "Make sure we start new activity only in UI thread." into tm-qpr-dev am: fd2471b990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21484427

Change-Id: I851ac58eb0dafa863bbf6efb6e19299d04ae3e2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:45:16 +00:00
Kevin Lim d8c97f669f [DenserUI] Add feature flag for app icon in inline shortcuts.
Bug: 268667774
Test: Tested in functional change: ag/21409510
Change-Id: Ifbd0bf1ed244e09b85236c02be289bfc026599e3
2023-02-21 21:39:38 +00:00
Stefan Andonian b77643bd16 Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev am: b7221177b4 am: c55e9d52e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21522366

Change-Id: I8d2eab7b9c18900c6b386fab7eb75ed7a9dfef10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:27:14 +00:00
TreeHugger Robot fd2471b990 Merge "Make sure we start new activity only in UI thread." into tm-qpr-dev 2023-02-21 21:13:26 +00:00
Stefan Andonian c55e9d52e4 Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev am: b7221177b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21522366

Change-Id: Ibad7a921788a1b86a972fcdb6a7f084dd4d4cfe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 19:47:30 +00:00
Stefan Andonian b7221177b4 Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev 2023-02-21 18:12:55 +00:00