Commit Graph

16725 Commits

Author SHA1 Message Date
Alex Chau f647016cce Merge "Make quick switch track finger 1:1" into sc-v2-dev 2021-06-03 19:44:55 +00:00
Bill Lin a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin 945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00
Alex Chau 822acf4d25 Make quick switch track finger 1:1
- When calculating motion delta, it should consider the scale of pagedView
- Adjust significant threshold of tablet quick switch to 15% of page width (roughly 100dp)

Fixes: 188786242
Test: manual on quick switch
Change-Id: Idaa6c5b721decb573e97158c5fbcd67fa224f9d1
2021-06-03 18:07:52 +01:00
Jon Miranda 4981118478 Only inset widgets if workspaceTopPadding is greater than the widget padding.
This prevents widget from becoming too close to status bar.

Bug: 189724771
Test: manual
Change-Id: I86f83b6a35bd2802bdbdf175340a379b498f481d
2021-06-03 09:54:45 -07:00
Stevie Kideckel d7dc5702f6 Use scrollToPositionWithOffset in widget list and account for padding
Also, scroll after collapsing as well to preserve the header position.
LinearLayoutManager seems to not count/double count the top padding of
the RecyclerView when scrolling to the position. Scrolling with the
offset and deducting the top padding works around the issue.

There's still some occasional weirdness that needs to be investigated,
but this works well...most of the time.

Bug: 183378651
Test: locally
Change-Id: I0ba85fb65411991ef781f08a69faaa993a7d7fd0
2021-06-03 16:18:32 +00:00
Stevie Kideckel f94a93ad2c Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev am: f15214597e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800533

Change-Id: I1107db2070a28d7de9ae2450760c9ac38108ee59
2021-06-03 14:30:05 +00:00
Stevie Kideckel f15214597e Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev 2021-06-03 14:15:00 +00:00
Stevie Kideckel 3256647b03 Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev am: 5cc44eb73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800536

Change-Id: Ic11f1bc2afc3a7430967b103faf7af56257f5dcd
2021-06-03 11:08:22 +00:00
Alina Zaidi e57ae67013 Merge "Update scrim in widget pickers." into sc-dev am: c599c90eaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776603

Change-Id: Idbdeab5c1af6a57b8779ed6a1ac7b8ab70b077ed
2021-06-03 11:08:18 +00:00
Stevie Kideckel 5cc44eb73e Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev 2021-06-03 11:00:32 +00:00
Pat Manning de40c75730 Merge "Prevent clearing home between display size changes." into sc-v2-dev 2021-06-03 10:47:57 +00:00
Stevie Kideckel eb367e471b Scroll to the selected widget picker row after headers are clicked
This keeps the row in view. Currently, this will scroll the row to the
centre-bottom of the screen due to the top padding being double counted,
but that will remedied in a future CL.

This also resolves the issue where the last row's widgets aren't visible
by handling that case specially

Fix: 188665456
Bug: 183378651
Test: verified locally
Change-Id: I9acb9087a8cdaf130ac5955c810c96462b368f36
2021-06-03 09:48:21 +00:00
Stevie Kideckel abd33b38e2 Use the LayoutManager as the source of truth for visible positions
During animations, the view group child may not correspond to the
visible views that appear at the top.

The previous logic is kept in the case that the layout manager returns
null for any reason, which can happen before layout has occurred for the
position.

Fix: 189588014
Test: verified locally
Change-Id: Ie8b5dcef50287e9e90a21f86e30a1ebcbbcba30f
2021-06-03 09:36:22 +00:00
Alina Zaidi 8796707172 Update scrim in widget pickers.
Also adjust padding in pin widget bottom sheet.

Test: Tested manually
Bug: 189802334
Change-Id: Ic25547ab1519139afdbf07aaefeb9168cf3501ff
2021-06-02 20:39:28 +01:00
Pat Manning 67094bfdfb Prevent clearing home between display size changes.
Split display support was previously based on the sizes of supported device profiles. If a device supporting split display increased display size too much, it could trigger a grid migration (due to number of hotseat icons displayed vs in the DB changing as it was no longer seen as split display). The migration would not run however, as the grid had not actually changed, but would still have cleard the DB in preparation of the migration.

By counting the number of supported profiles instead, we can estimate the number of screens invariant of display size changes and avoid undesired grid migrations.

Test: manual
Fix: 187689871
Bug: 187689871
Change-Id: If740c501cab0e80ef6144356ec5618ee30134ed7
2021-06-02 16:18:55 +00:00
TreeHugger Robot da91a85359 Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev am: f5af5ce11f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14793398

Change-Id: Ic5a7e1fc9f5ac07f84b10496b1f3ece2bf8e8b8f
2021-06-01 23:41:10 +00:00
TreeHugger Robot f5af5ce11f Merge "Revert "Add haptic feedback to Launcher recent apps scrolling"" into sc-dev 2021-06-01 23:39:39 +00:00
Wale Ogunwale 0e25d2eba8 Revert "Add haptic feedback to Launcher recent apps scrolling"
This reverts commit b1ef5e5c55.

Reason for revert: b/182382085#comment4

Change-Id: I001944da64dc05324b14cc9dd3db5921faf8806c
Bug: 182382085
2021-06-01 22:10:18 +00:00
Steven Ng 8e74a1f2a7 Merge "Show app widget resize frame after launcher state change" into sc-dev am: c58b204926
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14733440

Change-Id: I347e1fae2221f478cc7cab478e3924ea8a131eb8
2021-06-01 21:31:34 +00:00
Steven Ng 6ed0112871 Merge "Fix add extra empty screen logic" into sc-dev am: a45ea6cf33
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14717704

Change-Id: I69033f2b4ca9f3508ed31125bb9b74a09dd32829
2021-06-01 21:31:30 +00:00
TreeHugger Robot c3629c8e9c Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev am: b13200c6b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14735875

Change-Id: Icea54a23541cdd1791d9adc1c5dde67bbd6583c9
2021-06-01 21:31:25 +00:00
TreeHugger Robot d46e3b0322 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev am: 9ccd3c5e12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14773075

Change-Id: Ifbfcb12c653035489552644e3afe4f524ee69c23
2021-06-01 21:31:20 +00:00
Steven Ng c58b204926 Merge "Show app widget resize frame after launcher state change" into sc-dev 2021-06-01 21:11:01 +00:00
Steven Ng a45ea6cf33 Merge "Fix add extra empty screen logic" into sc-dev 2021-06-01 21:04:55 +00:00
TreeHugger Robot b13200c6b1 Merge "Cleanup state properly when interacting during gesture nav transition" into sc-dev 2021-06-01 21:02:29 +00:00
TreeHugger Robot 9ccd3c5e12 Merge "Fixing deadlock when surface creation is waiting on surface destroy" into sc-dev 2021-06-01 21:00:19 +00:00
Brian Isganitis 25bf26ff4d Merge "Create settings activity layout with explicit toolbar" into sc-dev am: d9463fbfdd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738956

Change-Id: I26c09f9a1da137cc194a0215d085ffc4fa09a4f0
2021-06-01 20:36:26 +00:00
Brian Isganitis d9463fbfdd Merge "Create settings activity layout with explicit toolbar" into sc-dev 2021-06-01 20:15:15 +00:00
Jonathan Miranda 1676ef9700 Merge "Turn off app close flag, Revert back to R implementation." into sc-dev am: d8035e1821
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14750661

Change-Id: Iee90e5897e98c8e06ea957c0b5f8418936c7d866
2021-06-01 19:52:01 +00:00
Jonathan Miranda 2abc3933ed Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev am: dfde41cf1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14754919

Change-Id: I7d4b2b8f1dbd68032677134a20b09b2a28fdb2b5
2021-06-01 19:51:40 +00:00
Alina Zaidi f14a4682b6 Merge "Add more education tips for widgets. (2/3)" into sc-dev am: 8a8c36cca9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14678271

Change-Id: I54f4236c54a56fa6c6945f2bd72f9530badccd00
2021-06-01 19:50:57 +00:00
Sunny Goyal 4c29af3a6d Fixing deadlock when surface creation is waiting on surface destroy
Bug: 189049869
Test: Manual
Change-Id: I0f92d3666dab81bc381163d93530119d45c4fdbd
2021-06-01 12:36:38 -07:00
Jonathan Miranda d8035e1821 Merge "Turn off app close flag, Revert back to R implementation." into sc-dev 2021-06-01 18:18:38 +00:00
Jonathan Miranda dfde41cf1e Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev 2021-06-01 18:17:17 +00:00
Alina Zaidi 8a8c36cca9 Merge "Add more education tips for widgets. (2/3)" into sc-dev 2021-06-01 17:34:18 +00:00
TreeHugger Robot 23bb5e0bfc Merge "Further adjust work profile tabs paddings in the widgets picker" into sc-dev am: 04ef35f854
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14748539

Change-Id: I606a60882b3635d3e67535ec5727e39a30eac876
2021-06-01 13:33:27 +00:00
TreeHugger Robot 04ef35f854 Merge "Further adjust work profile tabs paddings in the widgets picker" into sc-dev 2021-06-01 13:13:03 +00:00
Alina Zaidi f2c79dea0d Add more education tips for widgets. (2/3)
Show education dialog on WidgetsFullSheet.
-Have a button in widget education dialog to intent into PixelTips apps.
-Make sure arrow tip view shows after dismissing education dialog on
WidgetsFullSheet if there is a widget to show it on.
-Update colors and layout for arrow tips.

Test: Tested manually
Bug: 185354491
Change-Id: I5cbdd02fc4f19a49a42dac4451b071e3d604747f
2021-06-01 13:58:18 +01:00
Steven Ng 7e3d96c620 Show app widget resize frame after launcher state change
When this bug occurs, the resize frame coordinate is incorrect because
the launcher state animation has not finished when the drag view
finishes animating back to its original position.

Test: Quickly long press and release a widget from the home screen.
      Observe the resize frame is correctly shown around the widget.

Bug: 186370472
Change-Id: I6bfba2e85e3354a215c26203dd22df13db3b8b83
2021-06-01 12:20:32 +01:00
Steven Ng a0d49dcfb4 Further adjust work profile tabs paddings in the widgets picker
Test: Open widgets picker and observe tabs paddings are correctly set.
Bug: 188872382
Change-Id: Ib6a735bf2b0710f86b8641533cadb27116049341
2021-06-01 11:40:36 +01:00
Steven Ng 02045feb20 Merge "Don't dismiss keyboard after clicking X button on the widgets search bar" into sc-dev am: 755723403b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14748544

Change-Id: Id13572638904399f37f24ae3ff4c6f527128d972
2021-06-01 10:32:13 +00:00
Steven Ng 755723403b Merge "Don't dismiss keyboard after clicking X button on the widgets search bar" into sc-dev 2021-06-01 10:05:26 +00:00
Sunny Goyal 52a82bac34 Merge "Enabling themed icon feature" into sc-dev am: 8a7f973264
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738710

Change-Id: I65bbaa5b25d63dd1d0b4e1773fdb6dcd85f3b1d9
2021-05-28 19:20:29 +00:00
Sunny Goyal 8a7f973264 Merge "Enabling themed icon feature" into sc-dev 2021-05-28 18:53:40 +00:00
Jon Miranda de907805d1 Change folderFillColor to colorBackgroundFloating.
There seems to be some nuance that prevents me from defining it once in
the base theme, so just updated all of them individually to prevent
any edge case from slipping through.

Bug: 188095988
Test: manual
Change-Id: I1dea639f174fa4ec09bda93a6e2017993b2007a5
2021-05-28 01:21:21 +00:00
Brian Isganitis 08fdf4d269 Create settings activity layout with explicit toolbar
This layout will be overridden to have a collapsible toolbar on API 31.

Test: Settings layout unchanged
Bug: 187732263
Change-Id: I0c098dd0a09a1787a10035a3d3f35ecf461cfc20
2021-05-27 18:41:18 -04:00
Brian Isganitis a9a063294e Merge "Give each preference screen its own activity and toolbar title" into sc-dev am: 8d6ca68786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14709732

Change-Id: I058985cbd1edbdb9cf1487eed4a51f9863cda0e7
2021-05-27 22:32:56 +00:00
Brian Isganitis 8d6ca68786 Merge "Give each preference screen its own activity and toolbar title" into sc-dev 2021-05-27 22:29:28 +00:00
Jon Miranda 62769f10d7 Turn off app close flag, Revert back to R implementation.
Need more time to experiment with interpolated + springs based approach,
will aim for QPR instead.

Bug: 189120868
Bug: 173107751
Test: manual
Change-Id: I5698bd61c92b4fa719d82f2553125fc7f65b5969
2021-05-27 15:14:52 -07:00